[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[
https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963342#comment-13963342
]
Hadoop QA commented on HBASE-10929:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639226/HBASE-10929.patch
against trunk revision .
ATTACHMENT ID: 12639226
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9226//console
This message is automatically generated.
> Change ScanQueryMatcher to use Cells instead of KeyValue.
> -
>
> Key: HBASE-10929
> URL: https://issues.apache.org/jira/browse/HBASE-10929
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10929.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963787#comment-13963787 ] stack commented on HBASE-10929: --- Patch lgtm. Any numbers Ram comparing old and new paths? Good stuff. > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[
https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965078#comment-13965078
]
Hadoop QA commented on HBASE-10929:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639541/HBASE-10929_1.patch
against trunk revision .
ATTACHMENT ID: 12639541
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail.
{color:red}-1 findbugs{color}. The patch appears to cause Findbugs
(version 1.3.9) to fail.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9243//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9243//console
This message is automatically generated.
> Change ScanQueryMatcher to use Cells instead of KeyValue.
> -
>
> Key: HBASE-10929
> URL: https://issues.apache.org/jira/browse/HBASE-10929
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10929.patch, HBASE-10929_1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[
https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965844#comment-13965844
]
Hadoop QA commented on HBASE-10929:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639614/HBASE-10929_2.patch
against trunk revision .
ATTACHMENT ID: 12639614
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:368)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9249//console
This message is automatically generated.
> Change ScanQueryMatcher to use Cells instead of KeyValue.
> -
>
> Key: HBASE-10929
> URL: https://issues.apache.org/jira/browse/HBASE-10929
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10929.patch, HBASE-10929_1.patch,
> HBASE-10929_2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966230#comment-13966230 ] ramkrishna.s.vasudevan commented on HBASE-10929: Ping !!! > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968594#comment-13968594 ] ramkrishna.s.vasudevan commented on HBASE-10929: Ping!! > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973835#comment-13973835 ] ramkrishna.s.vasudevan commented on HBASE-10929: Will commit this unless objections. See HBASE-10801 for comments on performance. > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[
https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974137#comment-13974137
]
Ted Yu commented on HBASE-10929:
lgtm
{code}
-kv = KeyValueUtil.ensureKeyValue(f.transformCell(kv));
+kv = f.transformCell(kv);
{code}
transformCell() returns Cell. Please add a new variable of type Cell.
> Change ScanQueryMatcher to use Cells instead of KeyValue.
> -
>
> Key: HBASE-10929
> URL: https://issues.apache.org/jira/browse/HBASE-10929
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10929.patch, HBASE-10929_1.patch,
> HBASE-10929_2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[
https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974800#comment-13974800
]
Hadoop QA commented on HBASE-10929:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12640846/HBASE-10929_3.patch
against trunk revision .
ATTACHMENT ID: 12640846
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+int ret = this.rowComparator.compareRows(row, this.rowOffset,
this.rowLength, cell.getRowArray(),
+ && (EnvironmentEdgeManager.currentTimeMillis() -
cell.getTimestamp()) <= timeToPurgeDeletes) {
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestTableMapReduceBase.testMultiRegionTable(TestTableMapReduceBase.java:96)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9342//console
This message is automatically generated.
> Change ScanQueryMatcher to use Cells instead of KeyValue.
> -
>
> Key: HBASE-10929
> URL: https://issues.apache.org/jira/browse/HBASE-10929
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10929.patch, HBASE-10929_1.patch,
> HBASE-10929_2.patch, HBASE-10929_3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[
https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975443#comment-13975443
]
Hadoop QA commented on HBASE-10929:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12641027/HBASE-10929_4.patch
against trunk revision .
ATTACHMENT ID: 12641027
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9349//console
This message is automatically generated.
> Change ScanQueryMatcher to use Cells instead of KeyValue.
> -
>
> Key: HBASE-10929
> URL: https://issues.apache.org/jira/browse/HBASE-10929
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10929.patch, HBASE-10929_1.patch,
> HBASE-10929_2.patch, HBASE-10929_3.patch, HBASE-10929_4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975803#comment-13975803 ] ramkrishna.s.vasudevan commented on HBASE-10929: Can i commit the latest patch? > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch, HBASE-10929_3.patch, HBASE-10929_4.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975955#comment-13975955 ] stack commented on HBASE-10929: --- I skimmed v4. lgtm. > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch, HBASE-10929_3.patch, HBASE-10929_4.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976403#comment-13976403 ] Lars Hofhansl commented on HBASE-10929: --- Belated +1. Nice change. Had been thinking to remove the manual ripping-apart of the KVs done by SQM, never got to it. Glad to see that is has no performance impact... Although... Speaking of the numbers in HBASE-10801: With a large value portion (1000 bytes) we're obviously not going to see performance changes in small keys. > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch, HBASE-10929_3.patch, HBASE-10929_4.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977240#comment-13977240 ] Hudson commented on HBASE-10929: SUCCESS: Integrated in HBase-TRUNK #5107 (See [https://builds.apache.org/job/HBase-TRUNK/5107/]) HBASE-10929-Change ScanQueryMatcher to use Cells instead of KeyValue.(Ram) (ramkrishna: rev 1589018) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch, HBASE-10929_3.patch, HBASE-10929_4.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978534#comment-13978534 ] stack commented on HBASE-10929: --- +1 on addendum. Makes sense. > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch, HBASE-10929_3.patch, HBASE-10929_4.patch, > HBASE-10929_addendum.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979301#comment-13979301 ] ramkrishna.s.vasudevan commented on HBASE-10929: Committed the addendum. Thanks for the review. > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch, HBASE-10929_3.patch, HBASE-10929_4.patch, > HBASE-10929_addendum.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10929) Change ScanQueryMatcher to use Cells instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979814#comment-13979814 ] Hudson commented on HBASE-10929: SUCCESS: Integrated in HBase-TRUNK #5112 (See [https://builds.apache.org/job/HBase-TRUNK/5112/]) HBASE-10929 - Addendum that extracts out qualifierOffset, qualifierLength and timestamp (ramkrishna: rev 1589590) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java > Change ScanQueryMatcher to use Cells instead of KeyValue. > - > > Key: HBASE-10929 > URL: https://issues.apache.org/jira/browse/HBASE-10929 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10929.patch, HBASE-10929_1.patch, > HBASE-10929_2.patch, HBASE-10929_3.patch, HBASE-10929_4.patch, > HBASE-10929_addendum.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
