[jira] [Commented] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[ https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030358#comment-14030358 ] Hudson commented on HBASE-11107: FAILURE: Integrated in HBase-TRUNK #5200 (See [https://builds.apache.org/job/HBase-TRUNK/5200/]) HBASE-11107 Provide utility method equivalent to 0.92's Result.getBytes().getSize() (Gustavo Anatoly) (tedyu: rev 62a78ab661ef432dfe054d0c15258057250fbc78) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java Provide utility method equivalent to 0.92's Result.getBytes().getSize() --- Key: HBASE-11107 URL: https://issues.apache.org/jira/browse/HBASE-11107 Project: HBase Issue Type: Task Reporter: Ted Yu Assignee: Gustavo Anatoly Priority: Trivial Fix For: 0.99.0 Attachments: HBASE-11107.patch Currently user has to write code similar to the following for replacement of Result.getBytes().getSize() : {code} +Cell[] cellValues = resultRow.rawCells(); + +long size = 0L; +if (null != cellValues) { + for (Cell cellValue : cellValues) { +size += KeyValueUtil.ensureKeyValue(cellValue).heapSize(); + } +} {code} In ClientScanner, we have: {code} for (Cell kv : rs.rawCells()) { // TODO make method in Cell or CellUtil remainingResultSize -= KeyValueUtil.ensureKeyValue(kv).heapSize(); } {code} A utility method should be provided which computes summation of Cell sizes in a Result. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[ https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030543#comment-14030543 ] Gustavo Anatoly commented on HBASE-11107: - Thank you, Ted. Thank you, Chunhui Provide utility method equivalent to 0.92's Result.getBytes().getSize() --- Key: HBASE-11107 URL: https://issues.apache.org/jira/browse/HBASE-11107 Project: HBase Issue Type: Task Reporter: Ted Yu Assignee: Gustavo Anatoly Priority: Trivial Fix For: 0.99.0 Attachments: HBASE-11107.patch Currently user has to write code similar to the following for replacement of Result.getBytes().getSize() : {code} +Cell[] cellValues = resultRow.rawCells(); + +long size = 0L; +if (null != cellValues) { + for (Cell cellValue : cellValues) { +size += KeyValueUtil.ensureKeyValue(cellValue).heapSize(); + } +} {code} In ClientScanner, we have: {code} for (Cell kv : rs.rawCells()) { // TODO make method in Cell or CellUtil remainingResultSize -= KeyValueUtil.ensureKeyValue(kv).heapSize(); } {code} A utility method should be provided which computes summation of Cell sizes in a Result. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[ https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030004#comment-14030004 ] Hadoop QA commented on HBASE-11107: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12650152/HBASE-11107.patch against trunk revision . ATTACHMENT ID: 12650152 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9758//console This message is automatically generated. Provide utility method equivalent to 0.92's Result.getBytes().getSize() --- Key: HBASE-11107 URL: https://issues.apache.org/jira/browse/HBASE-11107 Project: HBase Issue Type: Task Reporter: Ted Yu Assignee: Gustavo Anatoly Priority: Trivial Attachments: HBASE-11107.patch Currently user has to write code similar to the following for replacement of Result.getBytes().getSize() : {code} +Cell[] cellValues = resultRow.rawCells(); + +long size = 0L; +if (null != cellValues) { + for (Cell cellValue : cellValues) { +size += KeyValueUtil.ensureKeyValue(cellValue).heapSize(); + } +} {code} In ClientScanner, we have: {code} for (Cell kv : rs.rawCells()) { // TODO make method in Cell or CellUtil remainingResultSize -= KeyValueUtil.ensureKeyValue(kv).heapSize(); } {code} A utility method should be provided which computes summation of Cell sizes in a Result. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[ https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030155#comment-14030155 ] chunhui shen commented on HBASE-11107: -- lgtm, +1 Provide utility method equivalent to 0.92's Result.getBytes().getSize() --- Key: HBASE-11107 URL: https://issues.apache.org/jira/browse/HBASE-11107 Project: HBase Issue Type: Task Reporter: Ted Yu Assignee: Gustavo Anatoly Priority: Trivial Attachments: HBASE-11107.patch Currently user has to write code similar to the following for replacement of Result.getBytes().getSize() : {code} +Cell[] cellValues = resultRow.rawCells(); + +long size = 0L; +if (null != cellValues) { + for (Cell cellValue : cellValues) { +size += KeyValueUtil.ensureKeyValue(cellValue).heapSize(); + } +} {code} In ClientScanner, we have: {code} for (Cell kv : rs.rawCells()) { // TODO make method in Cell or CellUtil remainingResultSize -= KeyValueUtil.ensureKeyValue(kv).heapSize(); } {code} A utility method should be provided which computes summation of Cell sizes in a Result. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[ https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020851#comment-14020851 ] Gustavo Anatoly commented on HBASE-11107: - Hi, [~rekhajoshm]. I will assign this task for me :) Thanks. Provide utility method equivalent to 0.92's Result.getBytes().getSize() --- Key: HBASE-11107 URL: https://issues.apache.org/jira/browse/HBASE-11107 Project: HBase Issue Type: Task Reporter: Ted Yu Assignee: Rekha Joshi Priority: Trivial Currently user has to write code similar to the following for replacement of Result.getBytes().getSize() : {code} +Cell[] cellValues = resultRow.rawCells(); + +long size = 0L; +if (null != cellValues) { + for (Cell cellValue : cellValues) { +size += KeyValueUtil.ensureKeyValue(cellValue).heapSize(); + } +} {code} In ClientScanner, we have: {code} for (Cell kv : rs.rawCells()) { // TODO make method in Cell or CellUtil remainingResultSize -= KeyValueUtil.ensureKeyValue(kv).heapSize(); } {code} A utility method should be provided which computes summation of Cell sizes in a Result. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[ https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13994413#comment-13994413 ] Rekha Joshi commented on HBASE-11107: - [~gustavoanatoly] : got work to be done for now, so sure.please go ahead. Provide utility method equivalent to 0.92's Result.getBytes().getSize() --- Key: HBASE-11107 URL: https://issues.apache.org/jira/browse/HBASE-11107 Project: HBase Issue Type: Task Reporter: Ted Yu Assignee: Rekha Joshi Priority: Trivial Currently user has to write code similar to the following for replacement of Result.getBytes().getSize() : {code} +Cell[] cellValues = resultRow.rawCells(); + +long size = 0L; +if (null != cellValues) { + for (Cell cellValue : cellValues) { +size += KeyValueUtil.ensureKeyValue(cellValue).heapSize(); + } +} {code} In ClientScanner, we have: {code} for (Cell kv : rs.rawCells()) { // TODO make method in Cell or CellUtil remainingResultSize -= KeyValueUtil.ensureKeyValue(kv).heapSize(); } {code} A utility method should be provided which computes summation of Cell sizes in a Result. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[ https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990648#comment-13990648 ] Gustavo Anatoly commented on HBASE-11107: - Hi, [~rekhajoshm] I would like know if is possible that I provide a patch, if you're not working yet with this issue. Thanks. Provide utility method equivalent to 0.92's Result.getBytes().getSize() --- Key: HBASE-11107 URL: https://issues.apache.org/jira/browse/HBASE-11107 Project: HBase Issue Type: Task Reporter: Ted Yu Assignee: Rekha Joshi Priority: Trivial Currently user has to write code similar to the following for replacement of Result.getBytes().getSize() : {code} +Cell[] cellValues = resultRow.rawCells(); + +long size = 0L; +if (null != cellValues) { + for (Cell cellValue : cellValues) { +size += KeyValueUtil.ensureKeyValue(cellValue).heapSize(); + } +} {code} In ClientScanner, we have: {code} for (Cell kv : rs.rawCells()) { // TODO make method in Cell or CellUtil remainingResultSize -= KeyValueUtil.ensureKeyValue(kv).heapSize(); } {code} A utility method should be provided which computes summation of Cell sizes in a Result. -- This message was sent by Atlassian JIRA (v6.2#6252)