[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003350#comment-14003350 ] Hudson commented on HBASE-11134: FAILURE: Integrated in hbase-0.96 #399 (See [https://builds.apache.org/job/hbase-0.96/399/]) HBASE-11134 Add a -list-snapshots option to SnapshotInfo (mbertozzi: rev 1594856) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001113#comment-14001113 ] Hudson commented on HBASE-11134: SUCCESS: Integrated in HBase-0.98 #307 (See [https://builds.apache.org/job/HBase-0.98/307/]) HBASE-11134 Add a -list-snapshots option to SnapshotInfo (mbertozzi: rev 1594855) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000770#comment-14000770 ] Hudson commented on HBASE-11134: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #291 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/291/]) HBASE-11134 Add a -list-snapshots option to SnapshotInfo (mbertozzi: rev 1594855) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999272#comment-13999272 ] Hudson commented on HBASE-11134: SUCCESS: Integrated in HBase-0.94-security #483 (See [https://builds.apache.org/job/HBase-0.94-security/483/]) HBASE-11134 Add a -list-snapshots option to SnapshotInfo (mbertozzi: rev 1594857) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999375#comment-13999375 ] Hudson commented on HBASE-11134: ABORTED: Integrated in HBase-TRUNK #5132 (See [https://builds.apache.org/job/HBase-TRUNK/5132/]) HBASE-11134 Add a -list-snapshots option to SnapshotInfo (mbertozzi: rev 1594854) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999303#comment-13999303 ] Hudson commented on HBASE-11134: SUCCESS: Integrated in HBase-0.94-JDK7 #135 (See [https://builds.apache.org/job/HBase-0.94-JDK7/135/]) HBASE-11134 Add a -list-snapshots option to SnapshotInfo (mbertozzi: rev 1594857) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999395#comment-13999395 ] Hudson commented on HBASE-11134: FAILURE: Integrated in HBase-0.94 #1367 (See [https://builds.apache.org/job/HBase-0.94/1367/]) HBASE-11134 Add a -list-snapshots option to SnapshotInfo (mbertozzi: rev 1594857) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999376#comment-13999376 ] Hudson commented on HBASE-11134: FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #84 (See [https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/84/]) HBASE-11134 Add a -list-snapshots option to SnapshotInfo (mbertozzi: rev 1594857) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996125#comment-13996125 ] Lars Hofhansl commented on HBASE-11134: --- +1 on v1 > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993933#comment-13993933 ] Jonathan Hsieh commented on HBASE-11134: Binding these vars to FSUtils so they can be picked up later seems strange -- can't this be made more explicit (e.g. when remote is specified we set some vars, if not we load defaults, and then make the static that lists use those vars) {code} +} else if (cmd.equals("-remote-dir")) { + Path sourceDir = new Path(args[++i]); + URI defaultFs = sourceDir.getFileSystem(conf).getUri(); + FSUtils.setFsDefault(conf, new Path(defaultFs)); + FSUtils.setRootDir(conf, sourceDir); {code} {code} + * Returns the list of available snapshots in the specified location + * @param conf the {@link Configuration} to use + * @return the list of snapshots + */ + public static List getSnapshotList(final Configuration conf) + throws IOException { +Path rootDir = FSUtils.getRootDir(conf); +FileSystem fs = FileSystem.get(rootDir.toUri(), conf); {code} > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
[ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993951#comment-13993951 ] Matteo Bertozzi commented on HBASE-11134: - {quote}Binding these vars to FSUtils so they can be picked up later seems strange – can't this be made more explicit (e.g. when remote is specified we set some vars, if not we load defaults, and then make the static that lists use those vars){quote} This isn't specific of list snapshot. this is a quick way to specify a different location. currently you have to do -Dhbase.root=REMOTE_DIR -Dfs.defaultFS=REMOTE_DIR I don't want pass around locations all around the code because you may want a different root-dir than the one that you have in the conf file. It is just an helper. getSnapshotList() is doing just what is supposed to do, from the configuration that you have specified list the snapshots. > Add a -list-snapshots option to SnapshotInfo > > > Key: HBASE-11134 > URL: https://issues.apache.org/jira/browse/HBASE-11134 > Project: HBase > Issue Type: Improvement > Components: snapshots >Affects Versions: 0.99.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch > > > Add a -list-snapshots option to SnapshotInfo to show all the snapshots > available. Also add a -remote-dir option to simplify the usage of > SnapshotInfo in case the snapshot dir is not the one of the current hbase > cluster > {code} > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots > SNAPSHOT | CREATION TIME| TABLE NAME > foo | 2014-05-07T22:40:13 | testtb > bar | 2014-05-07T22:40:16 | testtb > $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir > file:///backup/ -snapshot my_local_snapshot > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)