[jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
[
https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001112#comment-14001112
]
Hudson commented on HBASE-11189:
SUCCESS: Integrated in HBase-0.98 #307 (See
[https://builds.apache.org/job/HBase-0.98/307/])
HBASE-11189 Subprocedure should be marked as complete upon failure (tedyu: rev
1595356)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ProcedureMember.java
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/Subprocedure.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedure.java
Subprocedure should be marked as complete upon failure
--
Key: HBASE-11189
URL: https://issues.apache.org/jira/browse/HBASE-11189
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.99.0, 0.98.3
Attachments: 11189-v1.txt, 11189-v2.txt
ProcedureMember#submitSubprocedure() uses the following check:
{code}
if (!rsub.isComplete()) {
LOG.error(Subproc ' + procName + ' is already running. Bailing
out);
return false;
}
{code}
If a subprocedure of that name previously ran but failed, its complete field
would stay false, leading to early bailout.
A failed subprocedure should mark itself complete.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
[
https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000662#comment-14000662
]
Hudson commented on HBASE-11189:
SUCCESS: Integrated in HBase-TRUNK #5133 (See
[https://builds.apache.org/job/HBase-TRUNK/5133/])
HBASE-11189 Subprocedure should be marked as complete upon failure (tedyu: rev
1595357)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ProcedureMember.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/Subprocedure.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedure.java
Subprocedure should be marked as complete upon failure
--
Key: HBASE-11189
URL: https://issues.apache.org/jira/browse/HBASE-11189
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.99.0, 0.98.3
Attachments: 11189-v1.txt, 11189-v2.txt
ProcedureMember#submitSubprocedure() uses the following check:
{code}
if (!rsub.isComplete()) {
LOG.error(Subproc ' + procName + ' is already running. Bailing
out);
return false;
}
{code}
If a subprocedure of that name previously ran but failed, its complete field
would stay false, leading to early bailout.
A failed subprocedure should mark itself complete.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
[
https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000769#comment-14000769
]
Hudson commented on HBASE-11189:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #291 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/291/])
HBASE-11189 Subprocedure should be marked as complete upon failure (tedyu: rev
1595356)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ProcedureMember.java
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/Subprocedure.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedure.java
Subprocedure should be marked as complete upon failure
--
Key: HBASE-11189
URL: https://issues.apache.org/jira/browse/HBASE-11189
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.99.0, 0.98.3
Attachments: 11189-v1.txt, 11189-v2.txt
ProcedureMember#submitSubprocedure() uses the following check:
{code}
if (!rsub.isComplete()) {
LOG.error(Subproc ' + procName + ' is already running. Bailing
out);
return false;
}
{code}
If a subprocedure of that name previously ran but failed, its complete field
would stay false, leading to early bailout.
A failed subprocedure should mark itself complete.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
[
https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999613#comment-13999613
]
Hadoop QA commented on HBASE-11189:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645106/11189-v1.txt
against trunk revision .
ATTACHMENT ID: 12645106
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
58 warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9521//console
This message is automatically generated.
Subprocedure should be marked as complete upon failure
--
Key: HBASE-11189
URL: https://issues.apache.org/jira/browse/HBASE-11189
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.99.0, 0.98.3
Attachments: 11189-v1.txt
ProcedureMember#submitSubprocedure() uses the following check:
{code}
if (!rsub.isComplete()) {
LOG.error(Subproc ' + procName + ' is already running. Bailing
out);
return false;
}
{code}
If a subprocedure of that name previously ran but failed, its complete field
would stay false, leading to early bailout.
A failed subprocedure should mark itself complete.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
[
https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999693#comment-13999693
]
Ted Yu commented on HBASE-11189:
Test failure was not related to the patch. This test sometimes failed in other
QA reports as well.
Javadoc warnings were not introduced by the patch.
Subprocedure should be marked as complete upon failure
--
Key: HBASE-11189
URL: https://issues.apache.org/jira/browse/HBASE-11189
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.99.0, 0.98.3
Attachments: 11189-v1.txt
ProcedureMember#submitSubprocedure() uses the following check:
{code}
if (!rsub.isComplete()) {
LOG.error(Subproc ' + procName + ' is already running. Bailing
out);
return false;
}
{code}
If a subprocedure of that name previously ran but failed, its complete field
would stay false, leading to early bailout.
A failed subprocedure should mark itself complete.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
[
https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000141#comment-14000141
]
Hadoop QA commented on HBASE-11189:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645263/11189-v2.txt
against trunk revision .
ATTACHMENT ID: 12645263
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
58 warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9522//console
This message is automatically generated.
Subprocedure should be marked as complete upon failure
--
Key: HBASE-11189
URL: https://issues.apache.org/jira/browse/HBASE-11189
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.99.0, 0.98.3
Attachments: 11189-v1.txt, 11189-v2.txt
ProcedureMember#submitSubprocedure() uses the following check:
{code}
if (!rsub.isComplete()) {
LOG.error(Subproc ' + procName + ' is already running. Bailing
out);
return false;
}
{code}
If a subprocedure of that name previously ran but failed, its complete field
would stay false, leading to early bailout.
A failed subprocedure should mark itself complete.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
[
https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000187#comment-14000187
]
Matteo Bertozzi commented on HBASE-11189:
-
+1 on v2
Subprocedure should be marked as complete upon failure
--
Key: HBASE-11189
URL: https://issues.apache.org/jira/browse/HBASE-11189
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.99.0, 0.98.3
Attachments: 11189-v1.txt, 11189-v2.txt
ProcedureMember#submitSubprocedure() uses the following check:
{code}
if (!rsub.isComplete()) {
LOG.error(Subproc ' + procName + ' is already running. Bailing
out);
return false;
}
{code}
If a subprocedure of that name previously ran but failed, its complete field
would stay false, leading to early bailout.
A failed subprocedure should mark itself complete.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
[
https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999699#comment-13999699
]
Matteo Bertozzi commented on HBASE-11189:
-
It look ok, but I doubt we have a test verifying what happens when we get a
failure. Can you add that?
Subprocedure should be marked as complete upon failure
--
Key: HBASE-11189
URL: https://issues.apache.org/jira/browse/HBASE-11189
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 0.99.0, 0.98.3
Attachments: 11189-v1.txt
ProcedureMember#submitSubprocedure() uses the following check:
{code}
if (!rsub.isComplete()) {
LOG.error(Subproc ' + procName + ' is already running. Bailing
out);
return false;
}
{code}
If a subprocedure of that name previously ran but failed, its complete field
would stay false, leading to early bailout.
A failed subprocedure should mark itself complete.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
