[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103759#comment-14103759
 ] 

Hudson commented on HBASE-11553:


FAILURE: Integrated in HBase-TRUNK #5414 (See 
[https://builds.apache.org/job/HBase-TRUNK/5414/])
HBASE-11553 Abstract visibility label related services into an interface. 
(anoopsamjohn: rev 062f6a6aac99a11e3f833a6d460d458452624425)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java


 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_0.98.patch, HBASE-11553_0.99.patch, HBASE-11553_V2.patch, 
 HBASE-11553_V3.patch, HBASE-11553_V4.patch, HBASE-11553_V5.patch, 
 HBASE-11553_V6.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103837#comment-14103837
 ] 

Hudson commented on HBASE-11553:


FAILURE: Integrated in HBase-0.98 #461 (See 
[https://builds.apache.org/job/HBase-0.98/461/])
HBASE-11553 Abstract visibility label related services into an interface. 
(anoopsamjohn: rev d79861213da95df663136ba53930a789c4531e3f)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java


 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_0.98.patch, HBASE-11553_0.99.patch, HBASE-11553_V2.patch, 
 HBASE-11553_V3.patch, HBASE-11553_V4.patch, HBASE-11553_V5.patch, 
 HBASE-11553_V6.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103841#comment-14103841
 ] 

Hudson commented on HBASE-11553:


FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #434 (See 
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/434/])
HBASE-11553 Abstract visibility label related services into an interface. 
(anoopsamjohn: rev d79861213da95df663136ba53930a789c4531e3f)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java


 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_0.98.patch, HBASE-11553_0.99.patch, HBASE-11553_V2.patch, 
 HBASE-11553_V3.patch, HBASE-11553_V4.patch, HBASE-11553_V5.patch, 
 HBASE-11553_V6.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103907#comment-14103907
 ] 

Hudson commented on HBASE-11553:


FAILURE: Integrated in HBase-1.0 #115 (See 
[https://builds.apache.org/job/HBase-1.0/115/])
HBASE-11553 Abstract visibility label related services into an interface. 
(anoopsamjohn: rev 98067274d9065a7aa7e4ff7cf40e66ef86e79b0e)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java


 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_0.98.patch, HBASE-11553_0.99.patch, HBASE-11553_V2.patch, 
 HBASE-11553_V3.patch, HBASE-11553_V4.patch, HBASE-11553_V5.patch, 
 HBASE-11553_V6.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-18 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100457#comment-14100457
 ] 

Hadoop QA commented on HBASE-11553:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12662447/HBASE-11553_V5.patch
  against trunk revision .
  ATTACHMENT ID: 12662447

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 15 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10475//console

This message is automatically generated.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch, HBASE-11553_V4.patch, 
 HBASE-11553_V5.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-18 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100501#comment-14100501
 ] 

ramkrishna.s.vasudevan commented on HBASE-11553:


Just 2 minor nits in RB. Rest looks great.  +1 from me.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch, HBASE-11553_V4.patch, 
 HBASE-11553_V5.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-18 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101521#comment-14101521
 ] 

Andrew Purtell commented on HBASE-11553:


My earlier +1 stands, but the recent comments addressed were from [~busbey]. 
Any additional  comments Sean?

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch, HBASE-11553_V4.patch, 
 HBASE-11553_V5.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-17 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100277#comment-14100277
 ] 

Anoop Sam John commented on HBASE-11553:


All comment are addressed. Can I get some +1s for commit pls?

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch, HBASE-11553_V4.patch, 
 HBASE-11553_V5.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-11 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092519#comment-14092519
 ] 

ramkrishna.s.vasudevan commented on HBASE-11553:


+1 on commit.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-11 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092520#comment-14092520
 ] 

Anoop Sam John commented on HBASE-11553:


Thanks for the review Andy and Ram. 
I will commit tomorrow unless objection.  Ping [~enis] for branch-1
(Will fix the typo Ram raised on commit)

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-11 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093252#comment-14093252
 ] 

Sean Busbey commented on HBASE-11553:
-

I have some feedback in a review I'm ||-- this close to submitting, just as 
soon as I can test my intuition on one of the issues.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-11 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093268#comment-14093268
 ] 

Andrew Purtell commented on HBASE-11553:


Let's hold off on commit for more feedback 

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-08 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091606#comment-14091606
 ] 

Andrew Purtell commented on HBASE-11553:


Thanks. 

+1


 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-07 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14089542#comment-14089542
 ] 

Anoop Sam John commented on HBASE-11553:


Pls see ExpAsStringVisibilityLabelServiceImpl for an alternate impl for 
VisibilityLabelService.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-07 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14089631#comment-14089631
 ] 

Andrew Purtell commented on HBASE-11553:


Can you update RB with the latest patch Anoop? There are a lot of lines of 
change here.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-07 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14090210#comment-14090210
 ] 

Anoop Sam John commented on HBASE-11553:


Yes [~apurtell] the RB is already updated with latest patch.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-06 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087802#comment-14087802
 ] 

Hadoop QA commented on HBASE-11553:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12660153/HBASE-11553_V2.patch
  against trunk revision .
  ATTACHMENT ID: 12660153

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 10 new 
or modified tests.

{color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to 
fail.

Compilation errors resume:
[ERROR] COMPILATION ERROR : 
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[88,28]
 error: cannot find symbol
[ERROR]   symbol:   variable VIS_SERIALIZATION_TAG
[ERROR]   symbol:   variable VISIBILITY_TAG_TYPE
[ERROR]   symbol:   variable VISIBILITY_TAG_TYPE
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project hbase-server: Compilation failure: Compilation failure:
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[88,28]
 error: cannot find symbol
[ERROR] symbol:   variable VIS_SERIALIZATION_TAG
[ERROR] location: class VisibilityUtils
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[92,38]
 error: cannot find symbol
[ERROR] symbol:   variable VISIBILITY_TAG_TYPE
[ERROR] location: class VisibilityUtils
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[100,42]
 error: cannot find symbol
[ERROR] symbol:   variable VISIBILITY_TAG_TYPE
[ERROR] location: class VisibilityUtils
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[107,40]
 error: cannot find symbol
[ERROR] - [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn goals -rf :hbase-server


Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10318//console

This message is automatically generated.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-06 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087912#comment-14087912
 ] 

Hadoop QA commented on HBASE-11553:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12660168/HBASE-11553_V2.patch
  against trunk revision .
  ATTACHMENT ID: 12660168

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 10 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 findbugs{color}.  The patch appears to introduce 1 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):   
at 
org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStartedServerIsAlive(TestHttpServerLifecycle.java:72)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10320//console

This message is automatically generated.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-06 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14088856#comment-14088856
 ] 

Hadoop QA commented on HBASE-11553:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12660297/HBASE-11553_V3.patch
  against trunk revision .
  ATTACHMENT ID: 12660297

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 13 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10333//console

This message is automatically generated.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 2.0.0, 0.98.6

 Attachments: HBASE-11553.patch, HBASE-11553.patch, 
 HBASE-11553_V2.patch, HBASE-11553_V3.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-08-01 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082002#comment-14082002
 ] 

Anoop Sam John commented on HBASE-11553:


Will work on the comments and rebase patch once HBASE-11384 is committed.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 0.98.5, 2.0.0

 Attachments: HBASE-11553.patch, HBASE-11553.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-07-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070030#comment-14070030
 ] 

Hadoop QA commented on HBASE-11553:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12657087/HBASE-11553.patch
  against trunk revision .
  ATTACHMENT ID: 12657087

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 7 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 
warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestScan

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10144//console

This message is automatically generated.

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 0.98.5, 2.0.0

 Attachments: HBASE-11553.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-07-22 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070409#comment-14070409
 ] 

Andrew Purtell commented on HBASE-11553:


bq. Patch looks big as I renamed 2 files and and others also like code movement 
from VC to the VisibilityLabelService impl class.

Can we put it up on RB?

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 0.98.5, 2.0.0

 Attachments: HBASE-11553.patch, HBASE-11553.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface

2014-07-22 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070434#comment-14070434
 ] 

Anoop Sam John commented on HBASE-11553:


https://reviews.apache.org/r/23815/

 Abstract visibility label related services into an interface
 

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 0.98.5, 2.0.0

 Attachments: HBASE-11553.patch, HBASE-11553.patch


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-11553) Abstract visibility label related services into an interface encapsulating

2014-07-21 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068603#comment-14068603
 ] 

Andrew Purtell commented on HBASE-11553:


Good idea :-)

 Abstract visibility label related services into an interface encapsulating
 --

 Key: HBASE-11553
 URL: https://issues.apache.org/jira/browse/HBASE-11553
 Project: HBase
  Issue Type: Improvement
  Components: security
Reporter: Anoop Sam John
Assignee: Anoop Sam John
 Fix For: 0.99.0, 0.98.5, 2.0.0


 - storage and retrieval of label dictionary and authentication sets 
 - marshalling and unmarshalling of visibility expression representations 
 in operation attributes and cell tags
 - management of assignment of authorizations to principals
 This will allow us to introduce additional serde implementations for 
 visibility expressions, for example storing as strings in some places and 
 compressed/tokenized representation in others in order to support additional 
 use cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)