[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082567#comment-14082567
]
stack commented on HBASE-11632:
---
+1
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.5
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082720#comment-14082720
]
Andrew Purtell commented on HBASE-11632:
+1 for 0.98
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.4
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083101#comment-14083101
]
Hudson commented on HBASE-11632:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #407 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/407/])
HBASE-11632 Region split needs to clear force split flag at the end of
SplitRequest run (Jerry He) (tedyu: rev
f2fef2d39a8c69c56ed4ca9c0a52b86d7eb2d03a)
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.4
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.99.0, 0.98.5, 2.0.0
Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
HBASE-11632-v2-0.98.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083271#comment-14083271
]
Hudson commented on HBASE-11632:
SUCCESS: Integrated in HBase-0.98 #432 (See
[https://builds.apache.org/job/HBase-0.98/432/])
HBASE-11632 Region split needs to clear force split flag at the end of
SplitRequest run (Jerry He) (tedyu: rev
f2fef2d39a8c69c56ed4ca9c0a52b86d7eb2d03a)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.4
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.99.0, 0.98.5, 2.0.0
Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
HBASE-11632-v2-0.98.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083326#comment-14083326
]
Hudson commented on HBASE-11632:
FAILURE: Integrated in HBase-1.0 #82 (See
[https://builds.apache.org/job/HBase-1.0/82/])
HBASE-11632 Region split needs to clear force split flag at the end of
SplitRequest run (Jerry He) (tedyu: rev
9db8ecba746498573e9885d86f8be6bbdb77f78a)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.4
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.99.0, 0.98.5, 2.0.0
Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
HBASE-11632-v2-0.98.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083359#comment-14083359
]
Hudson commented on HBASE-11632:
FAILURE: Integrated in HBase-TRUNK #5364 (See
[https://builds.apache.org/job/HBase-TRUNK/5364/])
HBASE-11632 Region split needs to clear force split flag at the end of
SplitRequest run (Jerry He) (tedyu: rev
eb79a4358029653817ddf8bee0dde392c3368ecb)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.4
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.99.0, 0.98.5, 2.0.0
Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
HBASE-11632-v2-0.98.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081214#comment-14081214
]
Ted Yu commented on HBASE-11632:
lgtm
Is it hard to come up with a test corresponding to the scenario above ?
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.5
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Attachments: HBASE-11632-master.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081349#comment-14081349
]
Jerry He commented on HBASE-11632:
--
Hi, [~yuzhih...@gmail.com]
Let me try. Not easy for exact scenario :-)
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.5
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Attachments: HBASE-11632-master.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081461#comment-14081461
]
Hadoop QA commented on HBASE-11632:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12658974/HBASE-11632-master.patch
against trunk revision .
ATTACHMENT ID: 12658974
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
org.apache.hadoop.hbase.TestIOFencing
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10247//console
This message is automatically generated.
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.5
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Attachments: HBASE-11632-master.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081874#comment-14081874
]
Jerry He commented on HBASE-11632:
--
The test case failures from the previous QA run don't seem to be related.
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.5
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081871#comment-14081871
]
Jerry He commented on HBASE-11632:
--
Attached v2 that added another catch to clear the force split flag, and added a
test case.
Region split needs to clear force split flag at the end of SplitRequest run
---
Key: HBASE-11632
URL: https://issues.apache.org/jira/browse/HBASE-11632
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.99.0, 0.98.5
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch
force split flag is used when a user requests region split and specifies a
split key.
{code}
region.forceSplit(splitPoint);
{code}
We need to clear force split flag at the end of SplitRequest run. If the
region split is successful, this parent region will go away and there is no
need to clear this flag. But we will have problem when the split is not
successful or rejected. Here is the case:
1. User requested region split at rownkey-n.
2. We set forceSplit in the region with rownkey-n.
3. The split request got rejected because the region had references.
4. After a while, there was a system request split for the same region.
5. The region would use forceSplit and rownkey-n to split. What should have
happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
