[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090255#comment-14090255 ] stack commented on HBASE-11697: --- We are listing out buckets of bucketcache. If too many, we only list the first portion. I think we need to flag that we are not showing all. > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090219#comment-14090219 ] Hudson commented on HBASE-11697: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #415 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/415/]) HBASE-11697 Improve the 'Too many blocks' message on UI blockcache status page (Mikhail Antonov) (apurtell: rev 6283ec730596b2e47666e8bef3a0fdb0442f55e6) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090112#comment-14090112 ] Hudson commented on HBASE-11697: FAILURE: Integrated in HBase-TRUNK #5382 (See [https://builds.apache.org/job/HBase-TRUNK/5382/]) HBASE-11697 Improve the 'Too many blocks' message on UI blockcache status page (Mikhail Antonov) (apurtell: rev e11e89e5afc55d1e1256e85138e84f8a25b4ed96) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090107#comment-14090107 ] Hudson commented on HBASE-11697: SUCCESS: Integrated in HBase-0.98 #441 (See [https://builds.apache.org/job/HBase-0.98/441/]) HBASE-11697 Improve the 'Too many blocks' message on UI blockcache status page (Mikhail Antonov) (apurtell: rev 6283ec730596b2e47666e8bef3a0fdb0442f55e6) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090058#comment-14090058 ] Hudson commented on HBASE-11697: FAILURE: Integrated in HBase-1.0 #90 (See [https://builds.apache.org/job/HBase-1.0/90/]) HBASE-11697 Improve the 'Too many blocks' message on UI blockcache status page (Mikhail Antonov) (apurtell: rev 0c1daa6efdac8338c268da486de446f2c55d15ce) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089929#comment-14089929 ] Andrew Purtell commented on HBASE-11697: Agree, I don't think we need the message, but this change has 3 +1s so I'm committing it now. > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089916#comment-14089916 ] Lars Hofhansl commented on HBASE-11697: --- +1 (Do we need that message at all? We're just getting some stats, doesn't matter than we only sampled a subset.) > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089882#comment-14089882 ] stack commented on HBASE-11697: --- +1 Thanks for cleaning up my scary message [~mantonov] > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089830#comment-14089830 ] Mikhail Antonov commented on HBASE-11697: - Sure - thanks [~apurtell]! > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089826#comment-14089826 ] Andrew Purtell commented on HBASE-11697: +1 Will commit shortly unless objection. Thanks for the patch [~mantonov]! > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Mikhail Antonov >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11697.patch, TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11697) Improve the 'Too many blocks' message on UI blockcache status page
[ https://issues.apache.org/jira/browse/HBASE-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089501#comment-14089501 ] stack commented on HBASE-11697: --- You are right Andrew. The message was meant to convey "Too many blocks to show in the UI without overwhelmingnothing wrong w/ your blockcache" > Improve the 'Too many blocks' message on UI blockcache status page > -- > > Key: HBASE-11697 > URL: https://issues.apache.org/jira/browse/HBASE-11697 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: TooManyBlocks.png > > > If metrics calculations over blockcache contents stopped after examining > hbase.ui.blockcache.by.file.max items, the UI will put up a message. However, > this notion of "too many blocks" / fullness refers to structures used for > calculating blockcache metrics. See BlockCacheUtil. We should improve this > message so it does not leave a user the impression the blockcache may be in a > bad state. -- This message was sent by Atlassian JIRA (v6.2#6252)
