[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233816#comment-14233816 ] Enis Soztutar commented on HBASE-11764: --- Sounds good. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.0.0, 2.0.0, 0.98.9 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-branch-1.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233717#comment-14233717 ] Andrew Purtell commented on HBASE-11764: The RC is out. Going to commit tomorrow. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.0.0, 2.0.0, 0.98.9 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-branch-1.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232319#comment-14232319 ] Enis Soztutar commented on HBASE-11764: --- Appreciate it. The patch applies cleanly, but I want to see the blue jenkins builds as well for at least a couple of iterations. Let's commit this afterwards. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.9, 0.99.2 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-branch-1.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230967#comment-14230967 ] Andrew Purtell commented on HBASE-11764: So [~enis], I should hold off on any branch-1 commit of until after the 0.99.2RC I presume. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.9, 0.99.2 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-branch-1.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217242#comment-14217242
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12682293/HBASE-11764.patch
against master branch at commit 22f29ca8efe910540f2912ec35fe307daf5eed0a.
ATTACHMENT ID: 12682293
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 17 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3811 checkstyle errors (more than the master's current 3807 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+|| i == parser.getAttributesKeyColumnIndex() || i ==
parser.getCellVisibilityColumnIndex()
+|| i == parser.getAttributesKeyColumnIndex() || i ==
parser.getCellVisibilityColumnIndex()
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11743//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.9, 0.99.2
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764-0.98.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215560#comment-14215560
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12682028/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12682028
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 17 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3792 checkstyle errors (more than the trunk's current 3788 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+|| i == parser.getAttributesKeyColumnIndex() || i ==
parser.getCellVisibilityColumnIndex()
+|| i == parser.getAttributesKeyColumnIndex() || i ==
parser.getCellVisibilityColumnIndex()
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11722//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.9, 0.99.2
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190702#comment-14190702 ] Andrew Purtell commented on HBASE-11764: Time permitting I'd do that ahead of commit for release... > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190700#comment-14190700 ] Andrew Purtell commented on HBASE-11764: I don't see a stability risk but do intend to (micro)profile this during the next RC qualification. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190648#comment-14190648 ] Lars Hofhansl commented on HBASE-11764: --- Scanned patch again. Looks good. +1 [~apurtell] you're confident enough that this won't destabilize 0.98? > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190424#comment-14190424 ] Andrew Purtell commented on HBASE-11764: Yessir, [~stack] > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190400#comment-14190400 ] stack commented on HBASE-11764: --- Still looking for +1s on this [~apurtell]? > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189665#comment-14189665
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12678119/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12678119
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3786 checkstyle errors (more than the trunk's current 3784 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11514//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.8, 0.99.2
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159697#comment-14159697
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12673013/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12673013
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11220//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.8, 0.99.1
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159260#comment-14159260 ] Andrew Purtell commented on HBASE-11764: Under active review. Moving out of 0.98.7, should land in 0.98.8 > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.1 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159018#comment-14159018 ] Andrew Purtell commented on HBASE-11764: [~anoop.hbase] had some good suggestions on reviewboard. Will post an updated patch soon. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158850#comment-14158850 ] Andrew Purtell commented on HBASE-11764: Updated without HBASE-11763 as requested [~lhofhansl] > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch, > HBASE-11764-0.98.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158849#comment-14158849
]
Andrew Purtell commented on HBASE-11764:
Latest 0.98 passes all unit tests:
{noformat}
...
[INFO] Building HBase - Common 0.98.7-SNAPSHOT
...
Tests run: 164, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Building HBase - Client 0.98.7-SNAPSHOT
...
Tests run: 51, Failures: 0, Errors: 0, Skipped: 1
...
[INFO] Building HBase - Hadoop Compatibility 0.98.7-SNAPSHOT
...
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Building HBase - Hadoop Two Compatibility 0.98.7-SNAPSHOT
...
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Building HBase - Prefix Tree 0.98.7-SNAPSHOT
...
Tests run: 277, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Building HBase - Server 0.98.7-SNAPSHOT
...
Tests run: 830, Failures: 0, Errors: 0, Skipped: 2
Tests run: 1263, Failures: 0, Errors: 0, Skipped: 8
...
[INFO] Building HBase - Thrift 0.98.7-SNAPSHOT
...
Tests run: 77, Failures: 0, Errors: 0, Skipped: 0
...
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 51:02 min
[INFO] Finished at: 2014-10-03T18:27:04-08:00
[INFO] Final Memory: 49M/370M
{noformat}
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764-0.98.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158761#comment-14158761
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12672878/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12672878
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Iterator tagIterator =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+updatedCells.add(new KeyValue(cell.getRowArray(),
cell.getRowOffset(), cell.getRowLength(),
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+if (t.getType() == TagType.TTL_TAG_TYPE &&
increment.getTTL() != Long.MAX_VALUE) {
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11215//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764-0.98.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158706#comment-14158706
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12672858/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12672858
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Iterator tagIterator =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+updatedCells.add(new KeyValue(cell.getRowArray(),
cell.getRowOffset(), cell.getRowLength(),
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+if (t.getType() == TagType.TTL_TAG_TYPE &&
increment.getTTL() != Long.MAX_VALUE) {
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestKeepDeletes
org.apache.hadoop.hbase.regionserver.TestMinVersions
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11213//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764-0.98.patch,
> HBASE-11764-0.98.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157532#comment-14157532 ] Andrew Purtell commented on HBASE-11764: I was sidetracked by other stuff. Let me put up a patch tomorrow. Apologies for the delay. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156800#comment-14156800 ] Andrew Purtell commented on HBASE-11764: I moved HBASE-11763 out. Let me rebase the patch on this issue without that change. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156748#comment-14156748 ] Lars Hofhansl commented on HBASE-11764: --- Glanced over the patch. Looks good. I think we should separate this one from HBASE-11763 and commit this one first and then do the refactoring. (as discussed offline). Lemme locally apply this patch and explore via Eclipse. I promise I'll do it this morning. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: HBASE-11764-0.98.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155143#comment-14155143
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12672342/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12672342
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Iterator tagIterator =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+updatedCells.add(new KeyValue(cell.getRowArray(),
cell.getRowOffset(), cell.getRowLength(),
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+if (t.getType() == TagType.TTL_TAG_TYPE &&
increment.getTTL() != Long.MAX_VALUE) {
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestZooKeeper
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.master.TestRestartCluster
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:339)
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.testSimpleLoad(TestLoadIncrementalHFiles.java:100)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11170//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152229#comment-14152229
]
Andrew Purtell commented on HBASE-11764:
The reported test failures are unrelated to this patch. I checked out the tip
of master branch and ran the indicated tests and they fail for me locally. For
example TestReplicaWithCluster#testReplicaAndReplication will time out after 30
seconds.
The 0.98 unit test suite can complete cleanly. Here is a run using the 0.98
version of this patch. The changes are identical to the master patch modulo
substitutions of KeyValue for Cell.
{noformat}
[INFO] Building HBase - Common 0.98.7-SNAPSHOT
Tests run: 164, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Building HBase - Client 0.98.7-SNAPSHOT
Tests run: 51, Failures: 0, Errors: 0, Skipped: 1
...
[INFO] Building HBase - Hadoop Compatibility 0.98.7-SNAPSHOT
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Building HBase - Hadoop Two Compatibility 0.98.7-SNAPSHOT
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Building HBase - Prefix Tree 0.98.7-SNAPSHOT
Tests run: 248, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Building HBase - Server 0.98.7-SNAPSHOT
Tests run: 831, Failures: 0, Errors: 0, Skipped: 3
Tests run: 1256, Failures: 0, Errors: 0, Skipped: 8
...
[INFO] Building HBase - Thrift 0.98.7-SNAPSHOT
Tests run: 77, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 55:05 min
[INFO] Finished at: 2014-09-29T13:15:18-08:00
[INFO] Final Memory: 48M/408M
{noformat}
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152053#comment-14152053
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671818/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12671818
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Iterator tagIterator =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+updatedCells.add(new KeyValue(cell.getRowArray(),
cell.getRowOffset(), cell.getRowLength(),
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+if (t.getType() == TagType.TTL_TAG_TYPE &&
increment.getTTL() != Long.MAX_VALUE) {
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
org.apache.hadoop.hbase.mapreduce.TestImportExport
org.apache.hadoop.hbase.util.TestProcessBasedCluster
org.apache.hadoop.hbase.client.TestReplicaWithCluster
{color:red}-1 core zombie tests{color}. There are 4 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:339)
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.testSimpleLoad(TestLoadIncrementalHFiles.java:100)
at
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsOnRSRestart(TestVisibilityLabels.java:406)
at
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService.testAddVisibilityLabelsOnRSRestart(TestVisibilityLabelsWithDefaultVisLabelService.java:115)
at
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsOnKillingOfRSContainingLabelsTable(TestVisibilityLabels.java:359)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11123//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/br
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151863#comment-14151863
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671817/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12671817
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11122//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11764-0.98.patch, HBASE-11764.patch,
> HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch,
> HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147271#comment-14147271 ] Andrew Purtell commented on HBASE-11764: Looks like I botched the rebate > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch, > HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147270#comment-14147270
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671100/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12671100
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Iterator tagIterator =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+updatedCells.add(new KeyValue(cell.getRowArray(),
cell.getRowOffset(), cell.getRowLength(),
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestTags
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService
org.apache.hadoop.hbase.client.TestRpcControllerFactory
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
org.apache.hadoop.hbase.regionserver.TestAtomicOperation
org.apache.hadoop.hbase.client.TestFromClientSide
org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths
org.apache.hadoop.hbase.security.access.TestAccessController
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.client.TestMultiParallel
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11064//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attach
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147149#comment-14147149
]
Andrew Purtell commented on HBASE-11764:
{quote}
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestOperation
{quote}
That's legit. Fixing
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147147#comment-14147147
]
Hadoop QA commented on HBASE-11764:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671091/HBASE-11764.patch
against trunk revision .
ATTACHMENT ID: 12671091
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Iterator tagIterator =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+updatedCells.add(new KeyValue(cell.getRowArray(),
cell.getRowOffset(), cell.getRowLength(),
+ Iterator i =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
+ long readPointToUse, long earliestPutTs, long oldestUnexpiredTS, long
now, byte[] dropDeletesFromRow,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestOperation
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hdfs.TestDatanodeDeath.testSimple1(TestDatanodeDeath.java:420)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11060//console
This message is automatically generated.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145956#comment-14145956 ] Andrew Purtell commented on HBASE-11764: This patch is stale due to more replacement of KeyValue with Cell. Will redo. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: HBASE-11764.patch, HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105609#comment-14105609 ] Andrew Purtell commented on HBASE-11764: bq. If we have to handle the case of per cell TTL > cf TTL, we have to track the per cell TTLs and write down this meta in HFile so that file level early out optimizations can be continued I have more time to work on this. I will proceed a bit here and maybe put up a patch containing the additional changes needed for that, we can decide. Thanks for having a look. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.6 > > Attachments: HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104999#comment-14104999 ] ramkrishna.s.vasudevan commented on HBASE-11764: bq.Cell tags cannot extend the lifetime of a cell beyond the family setting +1. Will take a look at the patch too. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.6 > > Attachments: HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104978#comment-14104978 ] Anoop Sam John commented on HBASE-11764: bq. Cell tags cannot extend the lifetime of a cell beyond the family setting I am +1 for that. CF can be set with max possible TTL and when there is a need to store some cells with more TTL value than this, one can always alter the CF setting.(Will get applied to new files created from then on (?) ) If we have to handle the case of per cell TTL > cf TTL, we have to track the per cell TTLs and write down this meta in HFile so that file level early out optimizations can be continued. Given the current way being simple, that would be good enough. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.6 > > Attachments: HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104958#comment-14104958 ] Andrew Purtell commented on HBASE-11764: Note that in the absence of a family setting, the default is forever, so cell TTLs have complete freedom in this case. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.6 > > Attachments: HBASE-11764.patch, HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102508#comment-14102508 ] Andrew Purtell commented on HBASE-11764: Anyway, the above is easy to deal with, I just have to break out the expiration tests into one check for cell TTL and another for family and skip or move to next column based on each test individually. Just calling your attention to the issue with the current patch > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.6 > > Attachments: HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[
https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102496#comment-14102496
]
Andrew Purtell commented on HBASE-11764:
bq. So you will add setter in Mutation (Non Delete) to pass the per cell TTL
right?
Yes.
Also, I realized this morning that this part of HBASE-11763 will need to be
changed in the patch on this issue:
{code}
@@ -362,9 +360,16 @@ public class ScanQueryMatcher {
}
// note the following next else if...
// delete marker are not subject to other delete markers
-} else if (!this.deletes.isEmpty()) {
- DeleteResult deleteResult = deletes.isDeleted(cell);
- switch (deleteResult) {
+} else {
+ // If the cell is expired and we have enough versions, skip
+ if (columns.hasMinVersions() && HStore.isExpired(cell,
oldestUnexpiredTS)) {
+return columns.getNextRowOrNextColumn(cell.getQualifierArray(),
qualifierOffset,
+qualifierLength);
+ }
+ // Check deletes
+ if (!this.deletes.isEmpty()) {
+DeleteResult deleteResult = deletes.isDeleted(cell);
+switch (deleteResult) {
case FAMILY_DELETED:
case COLUMN_DELETED:
return columns.getNextRowOrNextColumn(cell.getQualifierArray(),
{code}
We can't assume based on a cell TTL that we can skip to the next column. We can
only skip the current cell. This may affect scanning performance
unconditionally. Up to now additional costs like the tag iterator would be
avoided wherever cells do not have tags.
> Support per cell TTLs
> -
>
> Key: HBASE-11764
> URL: https://issues.apache.org/jira/browse/HBASE-11764
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 0.99.0, 0.98.6
>
> Attachments: HBASE-11764.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101835#comment-14101835 ] Anoop Sam John commented on HBASE-11764: So you will add setter in Mutation (Non Delete) to pass the per cell TTL right? > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.6 > > Attachments: HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11764) Support per cell TTLs
[ https://issues.apache.org/jira/browse/HBASE-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101636#comment-14101636 ] Andrew Purtell commented on HBASE-11764: Notes on current implementation: - Cell tags always override any family setting - If a cell has multiple TTLs we resolve the conflict by using the first TTL tag encountered - Unlike in schema cell TTLs are stored in milliseconds, no need to convert On the last point, no problem to use seconds for TTL tags as we do with schema. Either option is ugly in different ways. We either have way too many bits for seconds or the ability to set TTLs so small as to be useless. > Support per cell TTLs > - > > Key: HBASE-11764 > URL: https://issues.apache.org/jira/browse/HBASE-11764 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.6 > > Attachments: HBASE-11764.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
