[jira] [Commented] (HBASE-12192) Remove EventHandlerListener
[ https://issues.apache.org/jira/browse/HBASE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176132#comment-14176132 ] stack commented on HBASE-12192: --- [~ryanobjc] FYI, master changes get marked 2.0.0. If its backported to branch-1, it ALSO gets 0.99.2 (the next 0.99 release). FYI. Remove EventHandlerListener --- Key: HBASE-12192 URL: https://issues.apache.org/jira/browse/HBASE-12192 Project: HBase Issue Type: Bug Components: master Reporter: ryan rawson Assignee: ryan rawson Fix For: 2.0.0 Attachments: HBASE-12192.txt EventHandlerListener isn't actually being used by internal HBase code right now. No one actually calls 'ExecutorService.registerListener()' according to IntelliJ. It might be possible that some coprocessors use it. Perhaps people can comment if they find this functionality useful or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12192) Remove EventHandlerListener
[ https://issues.apache.org/jira/browse/HBASE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176171#comment-14176171 ] Hudson commented on HBASE-12192: SUCCESS: Integrated in HBase-TRUNK #5674 (See [https://builds.apache.org/job/HBase-TRUNK/5674/]) HBASE-12192 Remove EventHandlerListener (ryanobjc: rev 451798cefb008b32bd2c1f18962e9dded9a887eb) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java * hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java Remove EventHandlerListener --- Key: HBASE-12192 URL: https://issues.apache.org/jira/browse/HBASE-12192 Project: HBase Issue Type: Bug Components: master Reporter: ryan rawson Assignee: ryan rawson Fix For: 2.0.0 Attachments: HBASE-12192.txt EventHandlerListener isn't actually being used by internal HBase code right now. No one actually calls 'ExecutorService.registerListener()' according to IntelliJ. It might be possible that some coprocessors use it. Perhaps people can comment if they find this functionality useful or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12192) Remove EventHandlerListener
[ https://issues.apache.org/jira/browse/HBASE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175527#comment-14175527 ] ryan rawson commented on HBASE-12192: - thanks stack shall i commit it up? Remove EventHandlerListener --- Key: HBASE-12192 URL: https://issues.apache.org/jira/browse/HBASE-12192 Project: HBase Issue Type: Bug Components: master Reporter: ryan rawson Assignee: ryan rawson Attachments: HBASE-12192.txt EventHandlerListener isn't actually being used by internal HBase code right now. No one actually calls 'ExecutorService.registerListener()' according to IntelliJ. It might be possible that some coprocessors use it. Perhaps people can comment if they find this functionality useful or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12192) Remove EventHandlerListener
[ https://issues.apache.org/jira/browse/HBASE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175554#comment-14175554 ] stack commented on HBASE-12192: --- Yes sir Remove EventHandlerListener --- Key: HBASE-12192 URL: https://issues.apache.org/jira/browse/HBASE-12192 Project: HBase Issue Type: Bug Components: master Reporter: ryan rawson Assignee: ryan rawson Attachments: HBASE-12192.txt EventHandlerListener isn't actually being used by internal HBase code right now. No one actually calls 'ExecutorService.registerListener()' according to IntelliJ. It might be possible that some coprocessors use it. Perhaps people can comment if they find this functionality useful or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12192) Remove EventHandlerListener
[ https://issues.apache.org/jira/browse/HBASE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174561#comment-14174561 ] Hadoop QA commented on HBASE-12192: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12675156/HBASE-12192.txt against trunk revision . ATTACHMENT ID: 12675156 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11384//console This message is automatically generated. Remove EventHandlerListener --- Key: HBASE-12192 URL: https://issues.apache.org/jira/browse/HBASE-12192 Project: HBase Issue Type: Bug Components: master Reporter: ryan rawson Assignee: ryan rawson Attachments: HBASE-12192.txt EventHandlerListener isn't actually being used by internal HBase code right now. No one actually calls 'ExecutorService.registerListener()' according to IntelliJ. It might be possible that some coprocessors use it. Perhaps people can comment if they find this functionality useful or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12192) Remove EventHandlerListener
[ https://issues.apache.org/jira/browse/HBASE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162301#comment-14162301 ] stack commented on HBASE-12192: --- Try purging it? Remove EventHandlerListener --- Key: HBASE-12192 URL: https://issues.apache.org/jira/browse/HBASE-12192 Project: HBase Issue Type: Bug Components: master Reporter: ryan rawson EventHandlerListener isn't actually being used by internal HBase code right now. No one actually calls 'ExecutorService.registerListener()' according to IntelliJ. It might be possible that some coprocessors use it. Perhaps people can comment if they find this functionality useful or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12192) Remove EventHandlerListener
[ https://issues.apache.org/jira/browse/HBASE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162311#comment-14162311 ] ryan rawson commented on HBASE-12192: - I will do so. Remove EventHandlerListener --- Key: HBASE-12192 URL: https://issues.apache.org/jira/browse/HBASE-12192 Project: HBase Issue Type: Bug Components: master Reporter: ryan rawson EventHandlerListener isn't actually being used by internal HBase code right now. No one actually calls 'ExecutorService.registerListener()' according to IntelliJ. It might be possible that some coprocessors use it. Perhaps people can comment if they find this functionality useful or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)