[jira] [Commented] (HBASE-12293) Tests are logging too much

[Nicolas Liochon (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178404#comment-14178404
 ] 

Nicolas Liochon commented on HBASE-12293:
-

tests should be at info level at the minimum, as in production: if not we will 
discover in production/integration test that we log too much (or worse triggers 
NPE or stuff like this). For the same reason, I prefer to use the debug level 
in tests, to be sure that I won't have surprises (NPE) if I try to use them.

What I did in the past is reusing the info from the apache build (run time and 
logs), and looked at the both the log size and the log rate per test to 
prioritize the tests I was looking at. Then I was just improving the logs 
around these area.

 Tests are logging too much
 --

 Key: HBASE-12293
 URL: https://issues.apache.org/jira/browse/HBASE-12293
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Dima Spivak
Assignee: Dima Spivak
Priority: Minor

 In trying to solve HBASE-12285, it was pointed out that tests are writing too 
 much to output again. At best, this is a sloppy practice and, at worst, it 
 leaves us open to builds breaking when our test tools can't handle the flood. 
 If [~nkeywal] would be willing give me a little bit of mentoring on how he 
 dealt with this problem a few years back, I'd be happy to add it to my plate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12293) Tests are logging too much

[Elliott Clark (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176423#comment-14176423
 ] 

Elliott Clark commented on HBASE-12293:
---

The easiest thing would be to change the log4j properties on tests to warn:
https://github.com/apache/hbase/blob/master/hbase-server/src/test/resources/log4j.properties#L59

Then it's just a matter of looking for the few tests that change things to be 
Trace and removing those lines.

 Tests are logging too much
 --

 Key: HBASE-12293
 URL: https://issues.apache.org/jira/browse/HBASE-12293
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Dima Spivak
Assignee: Dima Spivak
Priority: Minor

 In trying to solve HBASE-12285, it was pointed out that tests are writing too 
 much to output again. At best, this is a sloppy practice and, at worst, it 
 leaves us open to builds breaking when our test tools can't handle the flood. 
 If [~nkeywal] would be willing give me a little bit of mentoring on how he 
 dealt with this problem a few years back, I'd be happy to add it to my plate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)