[jira] [Commented] (HBASE-12387) committer guidelines should include patch signoff
[
https://issues.apache.org/jira/browse/HBASE-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105609#comment-16105609
]
Mike Drob commented on HBASE-12387:
---
It looks like this got included almost verbatim already at some point (see
example 60) in https://hbase.apache.org/book.html#committing.patches
> committer guidelines should include patch signoff
> -
>
> Key: HBASE-12387
> URL: https://issues.apache.org/jira/browse/HBASE-12387
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>
> Right now our guide for committers apply patches has them use {{git am}}
> without a signoff flag. This works okay, but it misses adding the
> "signed-off-by" blurb in the commit message.
> Those messages make it easier to see at a glance with e.g. {{git log}} which
> committer applied the patch.
> this section:
> {quote}
> The directive to use git format-patch rather than git diff, and not to use
> --no-prefix, is a new one. See the second example for how to apply a patch
> created with git diff, and educate the person who created the patch.
> {code}
> $ git checkout -b HBASE-
> $ git am ~/Downloads/HBASE--v2.patch
> $ git checkout master
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary or ask the submitter to do it
> $ git pull --rebase # Better safe than sorry
> $ git push origin master
> $ git checkout branch-1
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary
> $ git pull --rebase # Better safe than sorry
> $ git push origin branch-1
> $ git branch -D HBASE-
> {code}
> {quote}
> Should be
> {quote}
> The directive to use git format-patch rather than git diff, and not to use
> --no-prefix, is a new one. See the second example for how to apply a patch
> created with git diff, and educate the person who created the patch.
> Note that the {{--signoff}} flag to {{git am}} will insert a line in the
> commit message that the patch was checked by your author string. This
> addition to your inclusion as the commit's committer makes your participation
> more prominent to users browsing {{git log}}.
> {code}
> $ git checkout -b HBASE-
> $ git am --signoff ~/Downloads/HBASE--v2.patch
> $ git checkout master
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary or ask the submitter to do it
> $ git pull --rebase # Better safe than sorry
> $ git push origin master
> $ git checkout branch-1
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary
> $ git pull --rebase # Better safe than sorry
> $ git push origin branch-1
> $ git branch -D HBASE-
> {code}
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-12387) committer guidelines should include patch signoff
[
https://issues.apache.org/jira/browse/HBASE-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105323#comment-16105323
]
Sean Busbey commented on HBASE-12387:
-
It didn't. since the ref guide includes a reference to a DISCUSS thread about
the old attribution approach of "HBASE-121334 foo bar thing (contributor)", we
should have one before we push on this.
Mind starting the thread [~mdrob]? If you don't think you have enough context,
let me know and I'll do it.
> committer guidelines should include patch signoff
> -
>
> Key: HBASE-12387
> URL: https://issues.apache.org/jira/browse/HBASE-12387
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>
> Right now our guide for committers apply patches has them use {{git am}}
> without a signoff flag. This works okay, but it misses adding the
> "signed-off-by" blurb in the commit message.
> Those messages make it easier to see at a glance with e.g. {{git log}} which
> committer applied the patch.
> this section:
> {quote}
> The directive to use git format-patch rather than git diff, and not to use
> --no-prefix, is a new one. See the second example for how to apply a patch
> created with git diff, and educate the person who created the patch.
> {code}
> $ git checkout -b HBASE-
> $ git am ~/Downloads/HBASE--v2.patch
> $ git checkout master
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary or ask the submitter to do it
> $ git pull --rebase # Better safe than sorry
> $ git push origin master
> $ git checkout branch-1
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary
> $ git pull --rebase # Better safe than sorry
> $ git push origin branch-1
> $ git branch -D HBASE-
> {code}
> {quote}
> Should be
> {quote}
> The directive to use git format-patch rather than git diff, and not to use
> --no-prefix, is a new one. See the second example for how to apply a patch
> created with git diff, and educate the person who created the patch.
> Note that the {{--signoff}} flag to {{git am}} will insert a line in the
> commit message that the patch was checked by your author string. This
> addition to your inclusion as the commit's committer makes your participation
> more prominent to users browsing {{git log}}.
> {code}
> $ git checkout -b HBASE-
> $ git am --signoff ~/Downloads/HBASE--v2.patch
> $ git checkout master
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary or ask the submitter to do it
> $ git pull --rebase # Better safe than sorry
> $ git push origin master
> $ git checkout branch-1
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary
> $ git pull --rebase # Better safe than sorry
> $ git push origin branch-1
> $ git branch -D HBASE-
> {code}
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-12387) committer guidelines should include patch signoff
[
https://issues.apache.org/jira/browse/HBASE-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105247#comment-16105247
]
Mike Drob commented on HBASE-12387:
---
Did the proposed DISCUSS thread ever happen?
> committer guidelines should include patch signoff
> -
>
> Key: HBASE-12387
> URL: https://issues.apache.org/jira/browse/HBASE-12387
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>
> Right now our guide for committers apply patches has them use {{git am}}
> without a signoff flag. This works okay, but it misses adding the
> "signed-off-by" blurb in the commit message.
> Those messages make it easier to see at a glance with e.g. {{git log}} which
> committer applied the patch.
> this section:
> {quote}
> The directive to use git format-patch rather than git diff, and not to use
> --no-prefix, is a new one. See the second example for how to apply a patch
> created with git diff, and educate the person who created the patch.
> {code}
> $ git checkout -b HBASE-
> $ git am ~/Downloads/HBASE--v2.patch
> $ git checkout master
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary or ask the submitter to do it
> $ git pull --rebase # Better safe than sorry
> $ git push origin master
> $ git checkout branch-1
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary
> $ git pull --rebase # Better safe than sorry
> $ git push origin branch-1
> $ git branch -D HBASE-
> {code}
> {quote}
> Should be
> {quote}
> The directive to use git format-patch rather than git diff, and not to use
> --no-prefix, is a new one. See the second example for how to apply a patch
> created with git diff, and educate the person who created the patch.
> Note that the {{--signoff}} flag to {{git am}} will insert a line in the
> commit message that the patch was checked by your author string. This
> addition to your inclusion as the commit's committer makes your participation
> more prominent to users browsing {{git log}}.
> {code}
> $ git checkout -b HBASE-
> $ git am --signoff ~/Downloads/HBASE--v2.patch
> $ git checkout master
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary or ask the submitter to do it
> $ git pull --rebase # Better safe than sorry
> $ git push origin master
> $ git checkout branch-1
> $ git pull --rebase
> $ git cherry-pick
> # Resolve conflicts if necessary
> $ git pull --rebase # Better safe than sorry
> $ git push origin branch-1
> $ git branch -D HBASE-
> {code}
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-12387) committer guidelines should include patch signoff
[
https://issues.apache.org/jira/browse/HBASE-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191567#comment-14191567
]
Anoop Sam John commented on HBASE-12387:
So we should always go with making author to contributor and signed off? Even
now also many patch commits are like old way (adding contributor name in commit
message). What do you say Stack?
committer guidelines should include patch signoff
-
Key: HBASE-12387
URL: https://issues.apache.org/jira/browse/HBASE-12387
Project: HBase
Issue Type: Task
Components: documentation
Reporter: Sean Busbey
Right now our guide for committers apply patches has them use {{git am}}
without a signoff flag. This works okay, but it misses adding the
signed-off-by blurb in the commit message.
Those messages make it easier to see at a glance with e.g. {{git log}} which
committer applied the patch.
this section:
{quote}
The directive to use git format-patch rather than git diff, and not to use
--no-prefix, is a new one. See the second example for how to apply a patch
created with git diff, and educate the person who created the patch.
{code}
$ git checkout -b HBASE-
$ git am ~/Downloads/HBASE--v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
Should be
{quote}
The directive to use git format-patch rather than git diff, and not to use
--no-prefix, is a new one. See the second example for how to apply a patch
created with git diff, and educate the person who created the patch.
Note that the {{--signoff}} flag to {{git am}} will insert a line in the
commit message that the patch was checked by your author string. This
addition to your inclusion as the commit's committer makes your participation
more prominent to users browsing {{git log}}.
{code}
$ git checkout -b HBASE-
$ git am --signoff ~/Downloads/HBASE--v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12387) committer guidelines should include patch signoff
[
https://issues.apache.org/jira/browse/HBASE-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191827#comment-14191827
]
Sean Busbey commented on HBASE-12387:
-
If we want to do that we'll need to expand the committer guidelines to cover
setting things up.
Something like
{quote}
This example shows how to commit a patch that was created using git diff
without --no-prefix. If the patch was created with --no-prefix, add -p0 to the
git apply command. *Before following these steps, you must ensure your working
directory is clean.* Otherwise, the autocommit step (commit -a) will coalesce
your local changes with those of the contributor.
Note that unlike the case of a patch made with git format-patch, the patch
itself doesn't include information on the contributor. Normally, you should be
able to use the name and email address from the user's ASF Jira account to fill
in the author details, below we use the example Prathia Hall
prathia.h...@example.com.
{code}
$ git apply ~/Downloads/HBASE--v2.patch
$ git commit -m HBASE- Really Good Code --author Prathia Hall
prathia.h...@example.com \
--signoff -a # This extra step is needed for patches created with 'git diff'
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
Actually, that's not that much more work. But it sounds like enough of a change
to warrant a DISCUSS thread?
committer guidelines should include patch signoff
-
Key: HBASE-12387
URL: https://issues.apache.org/jira/browse/HBASE-12387
Project: HBase
Issue Type: Task
Components: documentation
Reporter: Sean Busbey
Right now our guide for committers apply patches has them use {{git am}}
without a signoff flag. This works okay, but it misses adding the
signed-off-by blurb in the commit message.
Those messages make it easier to see at a glance with e.g. {{git log}} which
committer applied the patch.
this section:
{quote}
The directive to use git format-patch rather than git diff, and not to use
--no-prefix, is a new one. See the second example for how to apply a patch
created with git diff, and educate the person who created the patch.
{code}
$ git checkout -b HBASE-
$ git am ~/Downloads/HBASE--v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
Should be
{quote}
The directive to use git format-patch rather than git diff, and not to use
--no-prefix, is a new one. See the second example for how to apply a patch
created with git diff, and educate the person who created the patch.
Note that the {{--signoff}} flag to {{git am}} will insert a line in the
commit message that the patch was checked by your author string. This
addition to your inclusion as the commit's committer makes your participation
more prominent to users browsing {{git log}}.
{code}
$ git checkout -b HBASE-
$ git am --signoff ~/Downloads/HBASE--v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12387) committer guidelines should include patch signoff
[
https://issues.apache.org/jira/browse/HBASE-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191956#comment-14191956
]
stack commented on HBASE-12387:
---
bq. So we should always go with making author to contributor and signed off?
I like [~busbey]'s prescription [~anoopsamjohn]. He has the tooling doing the
work for us. Encouraging folks to produce patches that we can just do 'git am
--signoff' makes for less work for committers; any savings are appreciated when
we are running multiple branches as we are doing currently. What you think
[~anoopsamjohn]?
committer guidelines should include patch signoff
-
Key: HBASE-12387
URL: https://issues.apache.org/jira/browse/HBASE-12387
Project: HBase
Issue Type: Task
Components: documentation
Reporter: Sean Busbey
Assignee: Sean Busbey
Right now our guide for committers apply patches has them use {{git am}}
without a signoff flag. This works okay, but it misses adding the
signed-off-by blurb in the commit message.
Those messages make it easier to see at a glance with e.g. {{git log}} which
committer applied the patch.
this section:
{quote}
The directive to use git format-patch rather than git diff, and not to use
--no-prefix, is a new one. See the second example for how to apply a patch
created with git diff, and educate the person who created the patch.
{code}
$ git checkout -b HBASE-
$ git am ~/Downloads/HBASE--v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
Should be
{quote}
The directive to use git format-patch rather than git diff, and not to use
--no-prefix, is a new one. See the second example for how to apply a patch
created with git diff, and educate the person who created the patch.
Note that the {{--signoff}} flag to {{git am}} will insert a line in the
commit message that the patch was checked by your author string. This
addition to your inclusion as the commit's committer makes your participation
more prominent to users browsing {{git log}}.
{code}
$ git checkout -b HBASE-
$ git am --signoff ~/Downloads/HBASE--v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12387) committer guidelines should include patch signoff
[
https://issues.apache.org/jira/browse/HBASE-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14190878#comment-14190878
]
stack commented on HBASE-12387:
---
+1
I thought we had text with signoff previously (I read something by [~busbey] to
this effect and is why I do signoff if patch format allows over last month or
more...)
committer guidelines should include patch signoff
-
Key: HBASE-12387
URL: https://issues.apache.org/jira/browse/HBASE-12387
Project: HBase
Issue Type: Task
Components: documentation
Reporter: Sean Busbey
Right now our guide for committers apply patches has them use {{git am}}
without a signoff flag. This works okay, but it misses adding the
signed-off-by blurb in the commit message.
Those messages make it easier to see at a glance with e.g. {{git log}} which
committer applied the patch.
this section:
{quote}
The directive to use git format-patch rather than git diff, and not to use
--no-prefix, is a new one. See the second example for how to apply a patch
created with git diff, and educate the person who created the patch.
{code}
$ git checkout -b HBASE-
$ git am ~/Downloads/HBASE--v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
Should be
{quote}
The directive to use git format-patch rather than git diff, and not to use
--no-prefix, is a new one. See the second example for how to apply a patch
created with git diff, and educate the person who created the patch.
Note that the {{--signoff}} flag to {{git am}} will insert a line in the
commit message that the patch was checked by your author string. This
addition to your inclusion as the commit's committer makes your participation
more prominent to users browsing {{git log}}.
{code}
$ git checkout -b HBASE-
$ git am --signoff ~/Downloads/HBASE--v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase # Better safe than sorry
$ git push origin master
$ git checkout branch-1
$ git pull --rebase
$ git cherry-pick sha-from-commit
# Resolve conflicts if necessary
$ git pull --rebase # Better safe than sorry
$ git push origin branch-1
$ git branch -D HBASE-
{code}
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
