[jira] [Commented] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
[
https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637822#comment-14637822
]
Hudson commented on HBASE-12392:
FAILURE: Integrated in HBase-TRUNK #6672 (See
[https://builds.apache.org/job/HBase-TRUNK/6672/])
HBASE-12392 Incorrect implementation of (ramkrishna: rev
8a8b7de760a33c8195e287975d5b4a337d71b1fa)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
---
Key: HBASE-12392
URL: https://issues.apache.org/jira/browse/HBASE-12392
Project: HBase
Issue Type: Sub-task
Components: regionserver, Scanners
Affects Versions: hbase-11339
Reporter: Jingcheng Du
Assignee: Jingcheng Du
Priority: Critical
Fix For: hbase-11339
Attachments: HBASE-12392.diff
Now in the implementation of the isRetainDeleteMarkers method, the code look
like,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: isAllFiles();
{code}
It means for a major compaction in a normal store, this method returns true.
Consequently the delete marks could not be deleted in the major compaction,
which leads the unit test TestKeepDeletes fails.
The correct implementation should be,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: !isAllFiles();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
[
https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191533#comment-14191533
]
Hadoop QA commented on HBASE-12392:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12678433/HBASE-12392.diff
against trunk revision .
ATTACHMENT ID: 12678433
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11538//console
This message is automatically generated.
Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
---
Key: HBASE-12392
URL: https://issues.apache.org/jira/browse/HBASE-12392
Project: HBase
Issue Type: Sub-task
Components: regionserver, Scanners
Affects Versions: hbase-11339
Reporter: Jingcheng Du
Assignee: Jingcheng Du
Fix For: hbase-11339
Attachments: HBASE-12392.diff
Now in the implementation of the isRetainDeleteMarkers method, the code look
like,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: isAllFiles();
{code}
It means for a major compaction in a normal store, this method returns true.
Consequently the delete marks could not be deleted in the major compaction,
which leads the unit test TestKeepDeletes fails.
The correct implementation should be,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: !isAllFiles();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
[
https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191553#comment-14191553
]
Anoop Sam John commented on HBASE-12392:
Oh that is bad :(
+1. Thanks for the find Jingcheng
Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
---
Key: HBASE-12392
URL: https://issues.apache.org/jira/browse/HBASE-12392
Project: HBase
Issue Type: Sub-task
Components: regionserver, Scanners
Affects Versions: hbase-11339
Reporter: Jingcheng Du
Assignee: Jingcheng Du
Fix For: hbase-11339
Attachments: HBASE-12392.diff
Now in the implementation of the isRetainDeleteMarkers method, the code look
like,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: isAllFiles();
{code}
It means for a major compaction in a normal store, this method returns true.
Consequently the delete marks could not be deleted in the major compaction,
which leads the unit test TestKeepDeletes fails.
The correct implementation should be,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: !isAllFiles();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
[
https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191627#comment-14191627
]
Jingcheng Du commented on HBASE-12392:
--
Hi Ram [~ram_krish], do you want to look at this patch? Thanks.
Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
---
Key: HBASE-12392
URL: https://issues.apache.org/jira/browse/HBASE-12392
Project: HBase
Issue Type: Sub-task
Components: regionserver, Scanners
Affects Versions: hbase-11339
Reporter: Jingcheng Du
Assignee: Jingcheng Du
Priority: Critical
Fix For: hbase-11339
Attachments: HBASE-12392.diff
Now in the implementation of the isRetainDeleteMarkers method, the code look
like,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: isAllFiles();
{code}
It means for a major compaction in a normal store, this method returns true.
Consequently the delete marks could not be deleted in the major compaction,
which leads the unit test TestKeepDeletes fails.
The correct implementation should be,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: !isAllFiles();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
[
https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191632#comment-14191632
]
ramkrishna.s.vasudevan commented on HBASE-12392:
+1 on patch. Good catch.
Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
---
Key: HBASE-12392
URL: https://issues.apache.org/jira/browse/HBASE-12392
Project: HBase
Issue Type: Sub-task
Components: regionserver, Scanners
Affects Versions: hbase-11339
Reporter: Jingcheng Du
Assignee: Jingcheng Du
Priority: Critical
Fix For: hbase-11339
Attachments: HBASE-12392.diff
Now in the implementation of the isRetainDeleteMarkers method, the code look
like,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: isAllFiles();
{code}
It means for a major compaction in a normal store, this method returns true.
Consequently the delete marks could not be deleted in the major compaction,
which leads the unit test TestKeepDeletes fails.
The correct implementation should be,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: !isAllFiles();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
[
https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191647#comment-14191647
]
ramkrishna.s.vasudevan commented on HBASE-12392:
Should we wait for [~jmhsieh] +1? Or can we commit this. Change is fine anyway.
Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
---
Key: HBASE-12392
URL: https://issues.apache.org/jira/browse/HBASE-12392
Project: HBase
Issue Type: Sub-task
Components: regionserver, Scanners
Affects Versions: hbase-11339
Reporter: Jingcheng Du
Assignee: Jingcheng Du
Priority: Critical
Fix For: hbase-11339
Attachments: HBASE-12392.diff
Now in the implementation of the isRetainDeleteMarkers method, the code look
like,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: isAllFiles();
{code}
It means for a major compaction in a normal store, this method returns true.
Consequently the delete marks could not be deleted in the major compaction,
which leads the unit test TestKeepDeletes fails.
The correct implementation should be,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: !isAllFiles();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
[
https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191749#comment-14191749
]
Jonathan Hsieh commented on HBASE-12392:
+1, lgtm.
Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
---
Key: HBASE-12392
URL: https://issues.apache.org/jira/browse/HBASE-12392
Project: HBase
Issue Type: Sub-task
Components: regionserver, Scanners
Affects Versions: hbase-11339
Reporter: Jingcheng Du
Assignee: Jingcheng Du
Priority: Critical
Fix For: hbase-11339
Attachments: HBASE-12392.diff
Now in the implementation of the isRetainDeleteMarkers method, the code look
like,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: isAllFiles();
{code}
It means for a major compaction in a normal store, this method returns true.
Consequently the delete marks could not be deleted in the major compaction,
which leads the unit test TestKeepDeletes fails.
The correct implementation should be,
{code}
return (this.retainDeleteMarkers != null) ?
this.retainDeleteMarkers.booleanValue()
: !isAllFiles();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
