[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274588#comment-14274588 ] Hudson commented on HBASE-12422: FAILURE: Integrated in HBase-1.0 #653 (See [https://builds.apache.org/job/HBase-1.0/653/]) HBASE-12835 HBASE-12422 changed new HTable(Configuration) to not use managed Connections anymore (enis: rev fb44b267b870ab40faa1edd1860f22081ab387c6) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274580#comment-14274580 ] Hudson commented on HBASE-12422: FAILURE: Integrated in HBase-1.1 #76 (See [https://builds.apache.org/job/HBase-1.1/76/]) HBASE-12835 HBASE-12422 changed new HTable(Configuration) to not use managed Connections anymore (enis: rev 8470936d763a86dca0bdd65345dee799011166fb) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274701#comment-14274701 ] Hudson commented on HBASE-12422: FAILURE: Integrated in HBase-1.1 #77 (See [https://builds.apache.org/job/HBase-1.1/77/]) HBASE-12835 HBASE-12422 changed new HTable(Configuration) to not use managed Connections anymore - ADDENDUM for test failure (enis: rev 6e45269f2c668bdf57163d4d18aa6f6a2694c0f9) * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246291#comment-14246291 ] stack commented on HBASE-12422: --- Sorry the patch is big but its big because I added timeouts to TestHBaseFsck and to TestLoadIncrementalHFilesSplitRecovery so they wouldn't go zombie on us anymore when an issue. Other changes in TestLoadIncrementalHFilesSplitRecovery are refactorings so we reuse a connection rather than use deprecated HTable constructor; ditto in LoadIncrementalHFiles (this latter and similar change in TestHBaseFsck) fixed the failing tests). The change in HBaseFsck just moves us onto newer Interfaces. Then there is Solomon's original change. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246329#comment-14246329 ] Hudson commented on HBASE-12422: SUCCESS: Integrated in HBase-TRUNK #5919 (See [https://builds.apache.org/job/HBase-TRUNK/5919/]) HBASE-12422 Use ConnectionFactory in HTable constructors Fix method signature in test (stack: rev 029768287a62452cf99595b513f08133524fa834) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSecureLoadIncrementalHFilesSplitRecovery.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246348#comment-14246348 ] Hudson commented on HBASE-12422: SUCCESS: Integrated in HBase-1.0 #582 (See [https://builds.apache.org/job/HBase-1.0/582/]) HBASE-12422 Use ConnectionFactory in HTable constructors Fix method signature in test (stack: rev b1c95d50cf2f2de260595e7c076565e492ff9330) * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSecureLoadIncrementalHFilesSplitRecovery.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245514#comment-14245514 ] Hadoop QA commented on HBASE-12422: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687057/12422v3.txt against master branch at commit 65830b096b6f540b7e49ef590dac1ebe2491c126. ATTACHMENT ID: 12687057 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12068//console This message is automatically generated. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245569#comment-14245569 ] Hadoop QA commented on HBASE-12422: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687060/12422v4.txt against master branch at commit 65830b096b6f540b7e49ef590dac1ebe2491c126. ATTACHMENT ID: 12687060 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 11 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12069//console This message is automatically generated. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245867#comment-14245867 ] Hadoop QA commented on HBASE-12422: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687100/12422v5.txt against master branch at commit 65830b096b6f540b7e49ef590dac1ebe2491c126. ATTACHMENT ID: 12687100 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 11 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12075//console This message is automatically generated. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, 12422v3.txt, 12422v4.txt, 12422v5.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243603#comment-14243603 ] Hadoop QA commented on HBASE-12422: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12686717/12422v2.txt against master branch at commit da2b5a962725d775ed6db8d0db417e5d7af8c561. ATTACHMENT ID: 12686717 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery org.apache.hadoop.hbase.util.TestHBaseFsck {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testGroupOrSplitPresplit(TestLoadIncrementalHFilesSplitRecovery.java:382) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12053//console This message is automatically generated. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: 12422v2.txt, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241413#comment-14241413 ] Solomon Duskis commented on HBASE-12422: Sorry. I was wrong. This patch still breaks the build. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241497#comment-14241497 ] Hadoop QA commented on HBASE-12422: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12686295/HBASE-12422.patch against master branch at commit 84b41f8029fd5822832255daeee73ff2283a622a. ATTACHMENT ID: 12686295 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.util.TestHBaseFsck org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12040//console This message is automatically generated. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: stack Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238073#comment-14238073 ] Hadoop QA commented on HBASE-12422: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685761/HBASE-12422.patch against master branch at commit 9e9be97af735a27769f4b348b72f065acaa1380c. ATTACHMENT ID: 12685761 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery org.apache.hadoop.hbase.util.TestHBaseFsck Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11995//console This message is automatically generated. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: Solomon Duskis Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238229#comment-14238229 ] stack commented on HBASE-12422: --- The one test I tried fails locally for me. Probably has to do w/ a presumption of a connection now closed. If you don't have time to figure it, punt this way [~sduskis] -- I have some experience tracking down these sort of issues. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: Solomon Duskis Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238400#comment-14238400 ] Solomon Duskis commented on HBASE-12422: [~stack] I bet you do. I'm trying to chase this down, but I think that this issue gets to the heart of the managed vs. unmanaged connection change, and therefore is stack-worthy. I'll defer to you here. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: Solomon Duskis Priority: Minor Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214389#comment-14214389 ] Nick Dimiduk commented on HBASE-12422: -- Both of these constructors are setting cleanupConnectionOnClose=true, so I think they'll be fine (so long as the table itself is closed). Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: Solomon Duskis Priority: Minor Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207217#comment-14207217 ] Nick Dimiduk commented on HBASE-12422: -- [~sduskis] Is there more to it than this? :) Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Attachments: HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207436#comment-14207436 ] Hadoop QA commented on HBASE-12422: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12680918/HBASE-12422.patch against trunk revision . ATTACHMENT ID: 12680918 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.client.TestAdmin1 org.apache.hadoop.hbase.client.TestHCM {color:red}-1 core zombie tests{color}. There are 14 zombie test(s): at org.apache.hadoop.hbase.client.TestReplicasClient.testUseRegionWithReplica(TestReplicasClient.java:530) at org.apache.hadoop.hbase.security.access.TestScanEarlyTermination.testEarlyScanTermination(TestScanEarlyTermination.java:149) at org.apache.hadoop.hbase.security.access.TestAccessController2.testCreateWithCorrectOwner(TestAccessController2.java:83) at org.apache.hadoop.hbase.util.TestHBaseFsck.testNotInHdfs(TestHBaseFsck.java:1230) at org.apache.hadoop.hbase.security.access.TestCellACLs.testCoveringCheck(TestCellACLs.java:385) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11638//console This message is automatically generated. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207560#comment-14207560 ] Enis Soztutar commented on HBASE-12422: --- Will this patch work as it is? CM.getConnectionInternal() uses cached connections, while CF.createConnection() always create a new connection. Some of the stuff may be relying on the fact that the connection is cached (and auto closed). Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Components: Client Reporter: Solomon Duskis Assignee: Solomon Duskis Priority: Minor Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12422.patch, HBASE-12422.patch Use ConnectionFactory in HTable instead of ConnectionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12422) Use ConnectionFactory in HTable constructors
[ https://issues.apache.org/jira/browse/HBASE-12422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196351#comment-14196351 ] Hadoop QA commented on HBASE-12422: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12679223/HBASE-12422.patch against trunk revision . ATTACHMENT ID: 12679223 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery org.apache.hadoop.hbase.client.TestHCM org.apache.hadoop.hbase.client.TestAdmin {color:red}-1 core zombie tests{color}. There are 13 zombie test(s): at org.apache.hadoop.hbase.security.access.TestAccessControlFilter.testQualifierAccess(TestAccessControlFilter.java:97) at org.apache.hadoop.hbase.security.access.TestScanEarlyTermination.testEarlyScanTermination(TestScanEarlyTermination.java:149) at org.apache.hadoop.hbase.security.access.TestCellACLs.testCoveringCheck(TestCellACLs.java:385) at org.apache.hadoop.hbase.client.TestReplicasClient.testUseRegionWithReplica(TestReplicasClient.java:530) at org.apache.hadoop.hbase.util.TestHBaseFsck.testNotInHdfs(TestHBaseFsck.java:1230) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11579//console This message is automatically generated. Use ConnectionFactory in HTable constructors Key: HBASE-12422 URL: https://issues.apache.org/jira/browse/HBASE-12422 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Attachments: