[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231651#comment-14231651
]
Hadoop QA commented on HBASE-12490:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12684674/HBASE-12490C-branch-1.patch
against master branch at commit 5cc0714840bf8f7797a118e4bac5dabdd20e3f67.
ATTACHMENT ID: 12684674
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 48 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11895//console
This message is automatically generated.
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch, HBASE-12490B.patch,
HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch,
HBASE-12490C.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
parameter, clearBufferOnFail, is true and should remain true according to the
comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231675#comment-14231675 ] Solomon Duskis commented on HBASE-12490: Since this patch was already submitted to master, I submitted HBASE-12611 to address the autoCommit and clearBufferOnFail changes. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231808#comment-14231808 ] stack commented on HBASE-12490: --- Committed the branch-1 patch. The master commit was by mistake. It was committed mistakenly as part of this commit: commit 8b8f2026bda6a329d6d82376dbb884c8f183a967 Author: stack st...@apache.org Date: Tue Nov 25 21:21:35 2014 -0800 HBASE-12558 TestHCM.testClusterStatus Unexpected exception, expectedorg.apache.hadoop.hbase.regionserver.RegionServerStoppedException but wasjunit.framework.AssertionFailedError -- ADDED DEBUG Let me fix by revert and reapply. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231804#comment-14231804 ] Hudson commented on HBASE-12490: FAILURE: Integrated in HBase-1.0 #527 (See [https://builds.apache.org/job/HBase-1.0/527/]) HBASE-12490 Replace uses of setAutoFlush(boolean, boolean) (Solomon Duskis) (stack: rev 2b976c6bd1b4a56a7b351fe8f6f050394efb5dae) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableOutputFormat.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestHTableWrapper.java * hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231851#comment-14231851
]
stack commented on HBASE-12490:
---
Applied to master branch with below:
{code}
commit 7a3396f0e1ebf390038d71e190c2d33ee813ade3
Author: stack st...@apache.org
Date: Tue Dec 2 10:06:21 2014 -0800
HBASE-12490 Replace uses of setAutoFlush(boolean, boolean) (Solomon Duskis)
{code}
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch, HBASE-12490B.patch,
HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch,
HBASE-12490C.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
parameter, clearBufferOnFail, is true and should remain true according to the
comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231857#comment-14231857 ] stack commented on HBASE-12490: --- Let me put back a noop setAutoFlush in the branch-1 before resolving this issue since it has not been deprecated long enough (It is not deprecated in 0.98). Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232046#comment-14232046 ] stack commented on HBASE-12490: --- Applied addendum on branch-1 to fix failing TestAsyncProcess.testHTableFailedPutAndNewPut https://builds.apache.org/job/HBase-1.0/528/testReport/ commit e424d4254efd8372cbf28b8c134fe2fec423639a Author: stack st...@apache.org Date: Tue Dec 2 11:48:46 2014 -0800 HBASE-12490 Replace uses of setAutoFlush(boolean, boolean) (Solomon Duskis) -- ADDENDUM to fix failing TestAsyncProcess#testHTableFailedPutAndNewPut Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232079#comment-14232079 ] Hudson commented on HBASE-12490: SUCCESS: Integrated in HBase-TRUNK #5857 (See [https://builds.apache.org/job/HBase-TRUNK/5857/]) HBASE-12490 Replace uses of setAutoFlush(boolean, boolean) (Solomon Duskis) (stack: rev 7a3396f0e1ebf390038d71e190c2d33ee813ade3) * hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableOutputFormat.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestHTableWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch, HBASE-12490C.patch, addendum.txt The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232126#comment-14232126 ] Enis Soztutar commented on HBASE-12490: --- Addendum looks good. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch, HBASE-12490C.patch, addendum.txt The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232186#comment-14232186 ] Hudson commented on HBASE-12490: SUCCESS: Integrated in HBase-1.0 #529 (See [https://builds.apache.org/job/HBase-1.0/529/]) HBASE-12490 Replace uses of setAutoFlush(boolean, boolean) (Solomon Duskis) -- ADDENDUM to fix failing TestAsyncProcess#testHTableFailedPutAndNewPut (stack: rev e424d4254efd8372cbf28b8c134fe2fec423639a) * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C-branch-1.patch, HBASE-12490C.patch, addendum.txt The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229883#comment-14229883 ] Solomon Duskis commented on HBASE-12490: Can this please be applied against branch-1? Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230204#comment-14230204 ] stack commented on HBASE-12490: --- Please identify where behavior is changed [~sduskis] (I saw your comment on the related issue where you talk of how we are the same... just wondering where behavior changes... thanks) Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230217#comment-14230217 ] Solomon Duskis commented on HBASE-12490: There's only one scenario where behavior might change, and that should hopefully be an obscure case. That obscure case does not affect the code in this commit directly AFAIK. The changes i made from setAutoFlush(false, true) to setAutoFlushTo(false) assume that clearBufferOnFail was previously true, which will call setAutoFlush(false, clearBufferOnFail) - setAutoFlush(false, true) . If someone calls setAutoFlush(false) or setAutoFlush(false, false), and setAutoFlushTo(false) is called, then clearBufferOnFail will remain false. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230263#comment-14230263 ] stack commented on HBASE-12490: --- Thanks [~sduskis] Above will do as nice release note. Will apply as incompatible change. Can you rebase the patch? Its rotted. Thanks. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230365#comment-14230365
]
Nick Dimiduk commented on HBASE-12490:
--
Looking at current code on branch-1, it seems the only place we care about
preserving the write buffer in a failure scenario is in
HTable#backgroundFlushCommits(boolean), and in that method, we don't do
anything with the failed writes.
{noformat}
if (synchronous || ap.hasError()) {
while (!writeAsyncBuffer.isEmpty()) {
ap.submit(tableName, writeAsyncBuffer, true, null, false);
}
ListRow failedRows = clearBufferOnFail ? null : writeAsyncBuffer;
RetriesExhaustedWithDetailsException error =
ap.waitForAllPreviousOpsAndReset(failedRows);
if (error != null) {
throw error;
}
}
{noformat}
The call to ap.waitForAllPreviousOpsAndReset(failedRows) doesn't do anything
with them either, it just accumulates the edits into the failedRows list. That
variable goes out of scope immediately.
I think we can safely drop this concept of clearBufferOnFail from H/Table
interfaces. It's still wired into AsyncProcess, so I guess it can be picked up
in the future if there's need.
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch, HBASE-12490B.patch,
HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
parameter, clearBufferOnFail, is true and should remain true according to the
comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230673#comment-14230673 ] Nick Dimiduk commented on HBASE-12490: -- Should we rename this setting to autoCommit (with identical semantics) so that it is familiar language for the SQL folks? Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230694#comment-14230694 ] stack commented on HBASE-12490: --- I like that. Deprecate current method name. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227815#comment-14227815 ] Nicolas Liochon commented on HBASE-12490: - bq. It seems reasonable to me to remove it, that's a decision beyond my paygrade Well if you do that patch you get some decision power :-) [~ndimiduk], any opinion? Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224752#comment-14224752
]
Hadoop QA commented on HBASE-12490:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683584/HBASE-12490B.patch
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683584
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 45 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11827//console
This message is automatically generated.
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch, HBASE-12490B.patch,
HBASE-12490B.patch, HBASE-12490B.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
parameter, clearBufferOnFail, is true and should remain true according to the
comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224866#comment-14224866
]
Nicolas Liochon commented on HBASE-12490:
-
For stuff like:
{code}
-ht.setAutoFlush(false, false);
+ht.setAutoFlush(false);
{code}
It's not a big deal, but I don't really like the 'setAutoFlush(boolean)',
because it looks like a setter while actually it's not. I do prefer
'setAutoFlush(boolean, boolean)' because there is no confusion with a setter,
so it's easier for the reader. The implicit setting of the clearBufferOnFail on
something named like a setter is really confusing imho. I'm not -1, but I'm
-0, if I'm the only one confused here... :-)
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch, HBASE-12490B.patch,
HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
parameter, clearBufferOnFail, is true and should remain true according to the
comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224873#comment-14224873
]
Hadoop QA commented on HBASE-12490:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683600/HBASE-12490C.patch
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683600
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 45 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11828//console
This message is automatically generated.
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch, HBASE-12490B.patch,
HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
parameter, clearBufferOnFail, is true and should remain true according to the
comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224924#comment-14224924 ] Solomon Duskis commented on HBASE-12490: [~nkeywal]: That's a fair point. FWIW, my main objective is to be able to use a method from Table as opposed to a method from HTable. setAutoFlush() in its current state with three different methods is confusing. The current state of clearBufferOnFail being semi-deprecated is confusing. [~ndimiduk] sent an email t the dev group about making a decision on this, and it looks like I was the only one who responded. How can we get consensus on a clean implementation of setAutoFlush()? Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224939#comment-14224939 ] Nicolas Liochon commented on HBASE-12490: - Yeah, I saw it but I was ok with you answer so I didn't comment :-) Let's try to decide in this jira (Nick should see it). My point of view is: - we should not change the meaning of setAutoFlush(boolean), as it would be confusing during the upgrade (i.e. someone upgrading from .098 to 1.0 would have its code compiling but with a hidden behavior change) - we should not use setAutoFlush(boolean), may be we should remove it in 1.0. This because of the confusion around it's a setter-like that is not a setter. - I don't think that we need to keep clearBufferOnFail (i.e. we could remove it in 1.0), but may be I'm wrong here. If we do that then we can keep setAutoFlush(boolean), it will become a real setter (and then the points above are not an issue anymore. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225001#comment-14225001 ] Solomon Duskis commented on HBASE-12490: The javadoc said that clearBufferOnFail=false has been deprecated since 0.96. It seems reasonable to me to remove it, but that's a decision beyond my paygrade. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225046#comment-14225046 ] Solomon Duskis commented on HBASE-12490: On a different note... Why is the patch process failing? I'm not sure what I did wrong. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225138#comment-14225138 ] stack commented on HBASE-12490: --- [~sduskis] Looks like you need to rebase? Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214852#comment-14214852
]
Hadoop QA commented on HBASE-12490:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681919/HBASE-12490.patch
against trunk revision .
ATTACHMENT ID: 12681919
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 45 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3790 checkstyle errors (more than the trunk's current 3788 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAsyncProcess
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11706//console
This message is automatically generated.
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
parameter, clearBufferOnFail, is true and should remain true according to the
comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215000#comment-14215000 ] stack commented on HBASE-12490: --- Patch lgtm. Waiting on hadoopqa. Replace uses of setAutoFlush(boolean, boolean) -- Key: HBASE-12490 URL: https://issues.apache.org/jira/browse/HBASE-12490 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12490.patch, HBASE-12490B.patch The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible. HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215096#comment-14215096
]
Hadoop QA commented on HBASE-12490:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681947/HBASE-12490B.patch
against trunk revision .
ATTACHMENT ID: 12681947
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 45 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3790 checkstyle errors (more than the trunk's current 3788 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.camel.component.ibatis.IBatisShutdownAllTasksTest.testShutdownAllTasks(IBatisShutdownAllTasksTest.java:94)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11710//console
This message is automatically generated.
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch, HBASE-12490B.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[
https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215169#comment-14215169
]
Hadoop QA commented on HBASE-12490:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681985/HBASE-12490B.patch
against trunk revision .
ATTACHMENT ID: 12681985
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 45 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3790 checkstyle errors (more than the trunk's current 3788 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11716//console
This message is automatically generated.
Replace uses of setAutoFlush(boolean, boolean)
--
Key: HBASE-12490
URL: https://issues.apache.org/jira/browse/HBASE-12490
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch
The various uses of setAutoFlush() seem to need some tlc. There's a note in
HTableInterface: @deprecated in 0.99 since setting clearBufferOnFail is
deprecated. Use setAutoFlushTo(boolean) instead. It would be ideal to
change all internal uses of setAutoFlush(boolean, boolean) to use
setAutoFlushTo, if possible.
HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
setAutoFlush(false, false) has the same results as
HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
same affect as Table.setAutoFlushTo(false), assuming
HTable.setAutoFlush(false) was not called previously (by default, the second
parameter, clearBufferOnFail, is true and should remain true according to the
comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
