[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[
https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223968#comment-14223968
]
Enis Soztutar commented on HBASE-12570:
---
This is from HMaster.sanityCheckTableDescriptor() method introduced in
HBASE-10591
{code}
// check split policy class can be loaded
try {
RegionSplitPolicy.getSplitPolicyClass(htd, conf);
} catch (Exception ex) {
throw new DoNotRetryIOException(ex);
}
{code}
So it should have failed the alter table or create table. Which version of
HBase was the user running? Maybe it was disabled via configuration.
However, we load other classes (not just split policy), and they will have the
same affect as well. For example we have seen a similar problem for
co-processors ([~ndimiduk] was involved in a case where a typo in co-processor
name caused the cluster to go down). Similarly storage engine classes, wal
readers etc.
> Missing/invalid split policy class name brings down your HBase cluster
> --
>
> Key: HBASE-12570
> URL: https://issues.apache.org/jira/browse/HBASE-12570
> Project: HBase
> Issue Type: Bug
>Reporter: James Taylor
>
> See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase
> cluster will be brought down as each region server that successively attempts
> to open the region will not find the class and will bring itself down.
> One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE
> admin call if the split policy class cannot be found.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224005#comment-14224005 ] James Taylor commented on HBASE-12570: -- On 0.98.7 > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224078#comment-14224078 ] Lars Hofhansl commented on HBASE-12570: --- We can start by weeding these out one by one an have alters or creates fail as much as possible before they execute. This would be a good one to have in 0.98 and maybe in 0.94 as well. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224942#comment-14224942 ] Enis Soztutar commented on HBASE-12570: --- I forgot HBASE-10591 was not backported into 0.98. I'll create a subtask for that, and create another subtask for other classes we load. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224945#comment-14224945 ] Lars Hofhansl commented on HBASE-12570: --- I'd be in favor of backporting HBASE-10591 to 0.98. Might lead to surprises, though. [~apurtell], what do you think? > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225240#comment-14225240 ] Enis Soztutar commented on HBASE-12570: --- bq. I'd be in favor of backporting HBASE-10591 to 0.98. Might lead to surprises, though. That is why I did not propose that back when I originally did the patch. There is a way to disable this with a config option. Porting the patch with this disabled does not make a lot of sense though. We can either bite the bullet, or not do it in 0.98. I think [~apurtell] can make the call. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225456#comment-14225456 ] Andrew Purtell commented on HBASE-12570: I agree backporting sanity checks but disabled by default wouldn't be useful. Do we need all of them though? We could start with a full backport patch and remove items that we think might cause issues. Or just address the specific problem described in this issue (missing class in table config shouldn't take down the whole regionserver). Either works for me. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225547#comment-14225547 ] Lars Hofhansl commented on HBASE-12570: --- bq. Or just address the specific problem described in this issue +1 on that. We can take it piecemeal. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225581#comment-14225581 ] Enis Soztutar commented on HBASE-12570: --- The full backport patch is in HBASE-12573. Let me take out some stuff, and re-upload a patch. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
