[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246317#comment-14246317 ] stack commented on HBASE-12668: --- Your plan sounds great [~jurmous] You might post a note on dev list on what you are at (and what you have achieved so far) because more than just the lowlifes who hang out here in the JIRA forge are likely interested in what you are at. Regards publishing the snapshot, try again (smile -- sorry about that). > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245889#comment-14245889 ] Jurriaan Mous commented on HBASE-12668: --- I opened HBASE-12684 for an async RpcClient addition and committed some first code based on the work I already did in my published async client. Btw: the 1.0.0-SNAPSHOT is still of december 9th: http://repository.apache.org/content/groups/snapshots/org/apache/hbase/hbase-client/1.0.0-SNAPSHOT/ > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245616#comment-14245616 ] Jurriaan Mous commented on HBASE-12668: --- I am trying to do this step by step to be sure each step is correct. So I would first propose an async RpcClient which works with all current sync API. Nothing fancy, just a main AsyncRpcClient class, A SaslHandler, a new Call class (Or adapt current one), and a Response Handler and make sure it can be loaded with config to replace main RpcClient. And if it is found to be working great and better performant it could become the default and the current one could be removed. In an async RpcClient a lot of stuff in AsyncProcess would not be needed. (Netty handles that internally while handling the communication) AsyncProcess now seems to be a complex piece of code to simulate async calls by throwing sync calls onto new threads and collects all responses. But it is needed while the old blocking RpcClient exists. Does it sound like a good path to do this step by step? And if AsyncRpcClient works out as an optional RpcClient, that we evaluate the next step of removing the sync RpcClient. When removed it is possible to move over all the AsyncProcess code and introduce a new async RpcClient interface. And then it would become possible to introduce a new optional Async api for Table etc. > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245540#comment-14245540 ] stack commented on HBASE-12668: --- bq. I see you updated the master (2.0.0) but that will do for now since client api is the same. Oh. Yeah. Wrong branch. Look again in 20mins. bq. Later in the coming week I will try out some of the tests in HBase to see if the client works correctly with all current RpcClient tests and will then probably propose a new issue to integrate the AsyncRpcClient as an optional RpcClient in HBase itself. Excellent. Would it be under, replace, or make use of our AsyncProcess in client package? In case you may not have noticed, our current client is a little 'heavyweight'; feel free pruning. Will there be a new Async Client Interface? Thanks. > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245532#comment-14245532 ] Jurriaan Mous commented on HBASE-12668: --- I see you updated the master (2.0.0) but that will do for now since client api is the same. :) I can now in a quick test confirm that I can replace the RPC client with a Netty based one and start and stop a mini-cluster with it and it does all the normal sync communications correctly and it is able to do async communication through custom API calls. Later in the coming week I will try out some of the tests in HBase to see if the client works correctly with all current RpcClient tests and will then probably propose a new issue to integrate the AsyncRpcClient as an optional RpcClient in HBase itself. > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245513#comment-14245513 ] stack commented on HBASE-12668: --- bq. Is it possible to update 1.0.0-SNAPSHOT again? Done. > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245322#comment-14245322 ] Jurriaan Mous commented on HBASE-12668: --- Thanks!! Is it possible to update 1.0.0-SNAPSHOT again? :) > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244531#comment-14244531 ] Hudson commented on HBASE-12668: SUCCESS: Integrated in HBase-1.0 #577 (See [https://builds.apache.org/job/HBase-1.0/577/]) HBASE-12668 Adapt PayloadCarryingRpcController so it can also be used in an async way (stack: rev 54381aab11961ce876b3b56f75172b3f8fddb46d) * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244462#comment-14244462 ] Hudson commented on HBASE-12668: FAILURE: Integrated in HBase-TRUNK #5914 (See [https://builds.apache.org/job/HBase-TRUNK/5914/]) HBASE-12668 Adapt PayloadCarryingRpcController so it can also be used in an async way (stack: rev 3275b964c1c1fbb20ffe646b37317496b265660b) * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243907#comment-14243907 ] Jurriaan Mous commented on HBASE-12668: --- Now that HadoopQA checks out is there anything that holds back this patch? It is the last piece I need for a replacement async RpcClient implementation. :) > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch, > HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[
https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241717#comment-14241717
]
Hadoop QA commented on HBASE-12668:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686326/HBASE-12668-V1.patch
against master branch at commit 84b41f8029fd5822832255daeee73ff2283a622a.
ATTACHMENT ID: 12686326
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12046//console
This message is automatically generated.
> Adapt PayloadCarryingRpcController so it can also be used in async way
> --
>
> Key: HBASE-12668
> URL: https://issues.apache.org/jira/browse/HBASE-12668
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jurriaan Mous
>Assignee: Jurriaan Mous
> Attachments: HBASE-12668-V1.patch, HBASE-12668-V1.patch,
> HBASE-12668.patch
>
>
> With the changes in HBASE-12597 it is possible to create a new RPC client.
> But in all places the BlockingRpcChannel is called with a
> PayloadCarryingRpcController. This controller is not usable in Async context
> because some methods are not supported at the moment. (See
> TimeLimitedRpcController for the methods that throw
> UnsupportedOperationException)
> This issue is about implementing these methods so
> PayloadCarryingRpcController can also be used in an async context and work
> the same in a sync context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[
https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241527#comment-14241527
]
Hadoop QA commented on HBASE-12668:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686298/HBASE-12668-V1.patch
against master branch at commit 84b41f8029fd5822832255daeee73ff2283a622a.
ATTACHMENT ID: 12686298
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.camel.component.jetty.jettyproducer.JettyHttpProducerConcurrentTest.testNoConcurrentProducers(JettyHttpProducerConcurrentTest.java:47)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12041//console
This message is automatically generated.
> Adapt PayloadCarryingRpcController so it can also be used in async way
> --
>
> Key: HBASE-12668
> URL: https://issues.apache.org/jira/browse/HBASE-12668
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jurriaan Mous
>Assignee: Jurriaan Mous
> Attachments: HBASE-12668-V1.patch, HBASE-12668.patch
>
>
> With the changes in HBASE-12597 it is possible to create a new RPC client.
> But in all places the BlockingRpcChannel is called with a
> PayloadCarryingRpcController. This controller is not usable in Async context
> because some methods are not supported at the moment. (See
> TimeLimitedRpcController for the methods that throw
> UnsupportedOperationException)
> This issue is about implementing these methods so
> PayloadCarryingRpcController can also be used in an async context and work
> the same in a sync context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241382#comment-14241382 ] stack commented on HBASE-12668: --- bq. Is there a policy on the order of the imports? Not that I know of. Wouldn't worry about it (but good not to do gratuitous change) > Adapt PayloadCarryingRpcController so it can also be used in async way > -- > > Key: HBASE-12668 > URL: https://issues.apache.org/jira/browse/HBASE-12668 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jurriaan Mous >Assignee: Jurriaan Mous > Attachments: HBASE-12668-V1.patch, HBASE-12668.patch > > > With the changes in HBASE-12597 it is possible to create a new RPC client. > But in all places the BlockingRpcChannel is called with a > PayloadCarryingRpcController. This controller is not usable in Async context > because some methods are not supported at the moment. (See > TimeLimitedRpcController for the methods that throw > UnsupportedOperationException) > This issue is about implementing these methods so > PayloadCarryingRpcController can also be used in an async context and work > the same in a sync context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[
https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241327#comment-14241327
]
Hadoop QA commented on HBASE-12668:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686279/HBASE-12668.patch
against master branch at commit a4318aa8aacf036f665f1d012f3b4d2bae30d9e1.
ATTACHMENT ID: 12686279
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2090 checkstyle errors (more than the master's current 2086 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12038//console
This message is automatically generated.
> Adapt PayloadCarryingRpcController so it can also be used in async way
> --
>
> Key: HBASE-12668
> URL: https://issues.apache.org/jira/browse/HBASE-12668
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jurriaan Mous
>Assignee: Jurriaan Mous
> Attachments: HBASE-12668.patch
>
>
> With the changes in HBASE-12597 it is possible to create a new RPC client.
> But in all places the BlockingRpcChannel is called with a
> PayloadCarryingRpcController. This controller is not usable in Async context
> because some methods are not supported at the moment. (See
> TimeLimitedRpcController for the methods that throw
> UnsupportedOperationException)
> This issue is about implementing these methods so
> PayloadCarryingRpcController can also be used in an async context and work
> the same in a sync context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController so it can also be used in async way
[
https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241302#comment-14241302
]
stack commented on HBASE-12668:
---
Patch seems good.
Next version, fix this:
61 if(exception != null){
62return exception.getMessage();
63 }else{
64return null;
65 }
Make it so has same style as rest of the code (see space after closing parens.
Your checkstyle report will have complaints about them.
> Adapt PayloadCarryingRpcController so it can also be used in async way
> --
>
> Key: HBASE-12668
> URL: https://issues.apache.org/jira/browse/HBASE-12668
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jurriaan Mous
>Assignee: Jurriaan Mous
> Attachments: HBASE-12668.patch
>
>
> With the changes in HBASE-12597 it is possible to create a new RPC client.
> But in all places the BlockingRpcChannel is called with a
> PayloadCarryingRpcController. This controller is not usable in Async context
> because some methods are not supported at the moment. (See
> TimeLimitedRpcController for the methods that throw
> UnsupportedOperationException)
> This issue is about implementing these methods so
> PayloadCarryingRpcController can also be used in an async context and work
> the same in a sync context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
