[jira] [Commented] (HBASE-12675) Use interface methods in shell scripts
[
https://issues.apache.org/jira/browse/HBASE-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246844#comment-14246844
]
Hadoop QA commented on HBASE-12675:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12687243/HBASE-12675.patch
against master branch at commit db873f0886ec43e2e5b3bdcb56399b3bceb4dcaa.
ATTACHMENT ID: 12687243
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12086//console
This message is automatically generated.
Use interface methods in shell scripts
--
Key: HBASE-12675
URL: https://issues.apache.org/jira/browse/HBASE-12675
Project: HBase
Issue Type: Bug
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Fix For: 1.0.0, 2.0.0
Attachments: HBASE-12675.patch
There are places in the shell script code that use methods from HTable or
HConnection or etc. This patch will fix at least some of them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12675) Use interface methods in shell scripts
[ https://issues.apache.org/jira/browse/HBASE-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247331#comment-14247331 ] Hudson commented on HBASE-12675: SUCCESS: Integrated in HBase-1.0 #585 (See [https://builds.apache.org/job/HBase-1.0/585/]) HBASE-12675 Use interface methods in shell scripts (solomon duskis) (stack: rev ee4d9b531561ad2619e068f0e1147fe7ccac13ec) * hbase-shell/src/main/ruby/hbase/security.rb * hbase-shell/src/main/ruby/hbase/admin.rb * hbase-shell/src/main/ruby/hbase/table.rb Use interface methods in shell scripts -- Key: HBASE-12675 URL: https://issues.apache.org/jira/browse/HBASE-12675 Project: HBase Issue Type: Bug Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12675.patch There are places in the shell script code that use methods from HTable or HConnection or etc. This patch will fix at least some of them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12675) Use interface methods in shell scripts
[ https://issues.apache.org/jira/browse/HBASE-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247345#comment-14247345 ] Hudson commented on HBASE-12675: SUCCESS: Integrated in HBase-TRUNK #5926 (See [https://builds.apache.org/job/HBase-TRUNK/5926/]) HBASE-12675 Use interface methods in shell scripts (solomon duskis) (stack: rev 2cab24ab9ad25b02e93ad595bedd4550d8eea5d2) * hbase-shell/src/main/ruby/hbase/security.rb * hbase-shell/src/main/ruby/hbase/table.rb * hbase-shell/src/main/ruby/hbase/admin.rb Use interface methods in shell scripts -- Key: HBASE-12675 URL: https://issues.apache.org/jira/browse/HBASE-12675 Project: HBase Issue Type: Bug Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12675.patch There are places in the shell script code that use methods from HTable or HConnection or etc. This patch will fix at least some of them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12675) Use interface methods in shell scripts
[
https://issues.apache.org/jira/browse/HBASE-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247428#comment-14247428
]
Enis Soztutar commented on HBASE-12675:
---
Blated +1. Was looking at this as well. Solomon did you test {{list}} command.
I am asking because:
{code}
- @admin.listTableNames(regex).map { |t| t.getNameAsString }
+ @admin.listTables(regex).map { |t| t.getNameAsString }
{code}
Admin.listTables() returns HTableDescriptor[]. But HTableDescriptor does not
have getNameAsString() method.
Use interface methods in shell scripts
--
Key: HBASE-12675
URL: https://issues.apache.org/jira/browse/HBASE-12675
Project: HBase
Issue Type: Bug
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Fix For: 1.0.0, 2.0.0
Attachments: HBASE-12675.patch
There are places in the shell script code that use methods from HTable or
HConnection or etc. This patch will fix at least some of them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12675) Use interface methods in shell scripts
[ https://issues.apache.org/jira/browse/HBASE-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247438#comment-14247438 ] Enis Soztutar commented on HBASE-12675: --- nvm. HTD has getNameAsString() already. Use interface methods in shell scripts -- Key: HBASE-12675 URL: https://issues.apache.org/jira/browse/HBASE-12675 Project: HBase Issue Type: Bug Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12675.patch There are places in the shell script code that use methods from HTable or HConnection or etc. This patch will fix at least some of them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12675) Use interface methods in shell scripts
[ https://issues.apache.org/jira/browse/HBASE-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245553#comment-14245553 ] stack commented on HBASE-12675: --- You have a patch up your sleeve [~sduskis]? Use interface methods in shell scripts -- Key: HBASE-12675 URL: https://issues.apache.org/jira/browse/HBASE-12675 Project: HBase Issue Type: Bug Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 1.0.0, 2.0.0 There are places in the shell script code that use methods from HTable or HConnection or etc. This patch will fix at least some of them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
