[jira] [Commented] (HBASE-12710) TestAssignmentManager may fail due to concurrent tests

2014-12-18 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251902#comment-14251902
 ] 

Ted Yu commented on HBASE-12710:


Dima:
The patch didn't solve the problem.
More investigation is needed.

> TestAssignmentManager may fail due to concurrent tests
> --
>
> Key: HBASE-12710
> URL: https://issues.apache.org/jira/browse/HBASE-12710
> Project: HBase
>  Issue Type: Test
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 12710-1.0.txt, 
> org.apache.hadoop.hbase.master.TestAssignmentManager-output.txt
>
>
> I saw TestAssignmentManager#testMasterRestartWhenTableInEnabling fail when 
> running test suite on branch-1:
> {code}
> testMasterRestartWhenTableInEnabling(org.apache.hadoop.hbase.master.TestAssignmentManager)
>   Time elapsed: 0.714 sec  <<< FAILURE!
> java.lang.AssertionError: Table should be enabled.
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.hadoop.hbase.master.TestAssignmentManager.testMasterRestartWhenTableInEnabling(TestAssignmentManager.java:1023)
> {code}
> In test output, I saw:
> {code}
> 2014-12-18 00:45:18,230 FATAL [kiyo:38816.activeMasterManager] 
> master.HMaster(1802): Unhandled exception. Starting shutdown.
> java.lang.IllegalArgumentException: Illegal character <10> at 0. Namespaces 
> can only contain 'alphanumeric characters': i.e. [a-zA-Z_0-9]:
> ^Ehbase^R^Dmeta
> at 
> org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:215)
> at 
> org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:204)
> at org.apache.hadoop.hbase.TableName.(TableName.java:307)
> at 
> org.apache.hadoop.hbase.TableName.createTableNameIfNecessary(TableName.java:344)
> at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:465)
> at 
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.toTableName(ProtobufUtil.java:2686)
> at 
> org.apache.hadoop.hbase.HTableDescriptor.convert(HTableDescriptor.java:1525)
> at 
> org.apache.hadoop.hbase.HTableDescriptor.parseFrom(HTableDescriptor.java:1487)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.readTableDescriptor(FSTableDescriptors.java:526)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptorForTableDirectory(FSTableDescriptors.java:730)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptor(FSTableDescriptors.java:706)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptor(FSTableDescriptors.java:693)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.checkRootDir(MasterFileSystem.java:466)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.createInitialFileSystemLayout(MasterFileSystem.java:145)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.(MasterFileSystem.java:125)
> at 
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:592)
> {code}
> But running TestAssignmentManager standalone, I don't see the above exception.
> Since TestAssignmentManager is a medium test, the above exception was likely 
> caused by concurrent tests.
> TestAssignmentManager should be categorized as large test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12710) TestAssignmentManager may fail due to concurrent tests

2014-12-18 Thread Dima Spivak (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251373#comment-14251373
 ] 

Dima Spivak commented on HBASE-12710:
-

Correct me if I'm wrong, [~tedyu], but aren't MediumTests and LargeTests 
categories run together as part of -PrunAllTests? [According to the 
pom|https://github.com/apache/hbase/blob/master/pom.xml#L2073], these 
categories both have a default fork count of 5, so I'm not sure this change 
would actually correct the problem. I think we should instead look at why 
[SmallTests are run with no 
forking|https://github.com/apache/hbase/blob/master/pom.xml#L2068], while 
Medium and Large do and, as you observed, experience spurious failures because 
of this concurrency.

> TestAssignmentManager may fail due to concurrent tests
> --
>
> Key: HBASE-12710
> URL: https://issues.apache.org/jira/browse/HBASE-12710
> Project: HBase
>  Issue Type: Test
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 12710-1.0.txt, 
> org.apache.hadoop.hbase.master.TestAssignmentManager-output.txt
>
>
> I saw TestAssignmentManager#testMasterRestartWhenTableInEnabling fail when 
> running test suite on branch-1:
> {code}
> testMasterRestartWhenTableInEnabling(org.apache.hadoop.hbase.master.TestAssignmentManager)
>   Time elapsed: 0.714 sec  <<< FAILURE!
> java.lang.AssertionError: Table should be enabled.
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.hadoop.hbase.master.TestAssignmentManager.testMasterRestartWhenTableInEnabling(TestAssignmentManager.java:1023)
> {code}
> In test output, I saw:
> {code}
> 2014-12-18 00:45:18,230 FATAL [kiyo:38816.activeMasterManager] 
> master.HMaster(1802): Unhandled exception. Starting shutdown.
> java.lang.IllegalArgumentException: Illegal character <10> at 0. Namespaces 
> can only contain 'alphanumeric characters': i.e. [a-zA-Z_0-9]:
> ^Ehbase^R^Dmeta
> at 
> org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:215)
> at 
> org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:204)
> at org.apache.hadoop.hbase.TableName.(TableName.java:307)
> at 
> org.apache.hadoop.hbase.TableName.createTableNameIfNecessary(TableName.java:344)
> at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:465)
> at 
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.toTableName(ProtobufUtil.java:2686)
> at 
> org.apache.hadoop.hbase.HTableDescriptor.convert(HTableDescriptor.java:1525)
> at 
> org.apache.hadoop.hbase.HTableDescriptor.parseFrom(HTableDescriptor.java:1487)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.readTableDescriptor(FSTableDescriptors.java:526)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptorForTableDirectory(FSTableDescriptors.java:730)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptor(FSTableDescriptors.java:706)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptor(FSTableDescriptors.java:693)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.checkRootDir(MasterFileSystem.java:466)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.createInitialFileSystemLayout(MasterFileSystem.java:145)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.(MasterFileSystem.java:125)
> at 
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:592)
> {code}
> But running TestAssignmentManager standalone, I don't see the above exception.
> Since TestAssignmentManager is a medium test, the above exception was likely 
> caused by concurrent tests.
> TestAssignmentManager should be categorized as large test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12710) TestAssignmentManager may fail due to concurrent tests

2014-12-17 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250948#comment-14250948
 ] 

Hadoop QA commented on HBASE-12710:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687895/12710-1.0.txt
  against master branch at commit 47738ff927385157b312ef4dfe61dbcaca05ea68.
  ATTACHMENT ID: 12687895

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12125//console

This message is automatically generated.

> TestAssignmentManager may fail due to concurrent tests
> --
>
> Key: HBASE-12710
> URL: https://issues.apache.org/jira/browse/HBASE-12710
> Project: HBase
>  Issue Type: Test
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 12710-1.0.txt, 
> org.apache.hadoop.hbase.master.TestAssignmentManager-output.txt
>
>
> I saw TestAssignmentManager#testMasterRestartWhenTableInEnabling fail when 
> running test suite on branch-1:
> {code}
> testMasterRestartWhenTableInEnabling(org.apache.hadoop.hbase.master.TestAssignmentManager)
>   Time elapsed: 0.714 sec  <<< FAILURE!
> java.lang.AssertionError: Table should be enabled.
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.hadoop.hbase.master.TestAssignmentManager.testMasterRestartWhenTableInEnabling(TestAssignmentManager.java:1023)
> {code}
> In test output, I saw:
> {code}
> 2014-12-18 00:45:18,230 FATAL [kiyo:38816.activeMasterManager] 
> master.HMaster(1802): Unhandled exception. Starting shutdown.
> java.lang.IllegalArgumentException: Illegal character <10> at 0. Namespaces 
> can only contain 'alphanumeric characters': i.e. [a-zA-Z_0-9]:
> ^Ehbase^R^Dmeta
> at 
> org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:215)
> at 
> org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:204)
> at org.apache.hadoop.hbase.TableName.(TableName.java:307)
> at 
> org.apache.hadoop.hbase.TableName.createTableNameIfNecessary(TableName.java:344)
> at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:465)
> at 
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.toTableName(ProtobufUtil.java:2686)
> at 
> org.apache.hadoop.hbase.HTableDescriptor.convert(HTableDescriptor.java:1525)
> at 
> org.apache.hadoop.hbase.HTableDescriptor.parseFrom(HTableDescriptor.java:1487)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.readTableDescriptor(FSTableDescriptors.java:526)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptorForTableDirectory(FSTableDescriptors.java:730)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptor(FSTableDescriptors.java:706)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptor(FSTableDescriptors.java:693)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.checkRootDir(MasterFileSystem.java:466)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.createInitialFileSystemLayout(MasterFileSystem.java:145)
> at 
> org.apache.hadoop.hbase.master.MasterFileSystem.(MasterFileSystem.java:125)
> at 
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:592)
> {code}
> But running TestAssignmentManager standalone, I don't see the above exception.
> Since TestAssignmentManager is a medium test, the above exception was likely 
> caused by concurrent tests.
> TestAssignmentManager should be categorized as large test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)