[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307710#comment-14307710 ] Hudson commented on HBASE-12914: FAILURE: Integrated in HBase-0.98 #836 (See [https://builds.apache.org/job/HBase-0.98/836/]) HBASE-12914 - Mark public features that require HFilev3 Unstable in 0.98, (ramkrishna: rev 509b48d07c00bf17bd757aaf78c5c478651aabe2) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TsvImporterMapper.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/EncryptionTest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlConstants.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/KeyProvider.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java * hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TagUsage.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/DefaultCipherProvider.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryptor.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java * hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCreator.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityClient.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Decryptor.java * hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Cipher.java * hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/CipherProvider.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/KeyStoreKeyProvider.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java * hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/CellVisibility.java * hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecWithTags.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Context.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/VisibilityExpressionResolver.java > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307693#comment-14307693 ] Hudson commented on HBASE-12914: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #793 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/793/]) HBASE-12914 - Mark public features that require HFilev3 Unstable in 0.98, (ramkrishna: rev 509b48d07c00bf17bd757aaf78c5c478651aabe2) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/EncryptionTest.java * hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/VisibilityExpressionResolver.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Cipher.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/CellVisibility.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/CipherProvider.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityClient.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/DefaultCipherProvider.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TagUsage.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Decryptor.java * hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java * hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Context.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java * hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecWithTags.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlConstants.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryptor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCreator.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/KeyStoreKeyProvider.java * hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java * hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TsvImporterMapper.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/KeyProvider.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307651#comment-14307651 ] ramkrishna.s.vasudevan commented on HBASE-12914: Pushed to 0.98. Thanks for the inputs and comments [~busbey], [~apurtell], [~ndimiduk], [~anoop.hbase]. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307529#comment-14307529 ] Andrew Purtell commented on HBASE-12914: +1 > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304825#comment-14304825 ] ramkrishna.s.vasudevan commented on HBASE-12914: [~apurtell] Ok to commit this to 0.98? > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[
https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304824#comment-14304824
]
ramkrishna.s.vasudevan commented on HBASE-12914:
Java doc warnings seems unrelated but there are lot of warnings in the previous
code
{code}
[WARNING] Javadoc Warnings
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java:488:
warning - @return tag has no arguments.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java:86:
warning - @link#getUserAuths(byte[], is an unknown tag.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java:153:
warning - @link#havingSystemAuth(User) is an unknown tag.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java:86:
warning - @link#getUserAuths(byte[], is an unknown tag.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java:153:
warning - @link#havingSystemAuth(User) is an unknown tag.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:2267:
warning - Tag @see: can't find
channelWrite(java.nio.channels.WritableByteChannel, java.nio.ByteBuffer) in
org.apache.hadoop.hbase.ipc.RpcServer
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormat.java:98:
warning - Tag @link: reference not found: ExportSnapshot
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java:144:
warning - @param argument "instance" is not a parameter name.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java:437:
warning - @return tag has no arguments.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java:1897:
warning - @return tag has no arguments.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentListener.java:44:
warning - @param argument "serverName" is not a parameter name.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java:235:
warning - Tag @see: reference not found: getLoadedCachedBlocksByFile
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:122:
warning - @param argument "stopper" is not a parameter name.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:370:
warning - @param argument "stopper" is not a parameter name.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java:86:
warning - @link#getUserAuths(byte[], is an unknown tag.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java:153:
warning - @link#havingSystemAuth(User) is an unknown tag.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java:86:
warning - @link#getUserAuths(byte[], is an unknown tag.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java:153:
warning - @link#havingSystemAuth(User) is an unknown tag.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java:609:
warning - Tag @see: can't find setAsyncLogFlush(boolean) in
org.apache.hadoop.hbase.HTableDescriptor
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:1694:
warning - @param argument "regionser
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[
https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304815#comment-14304815
]
Hadoop QA commented on HBASE-12914:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12695889/HBASE-12914-0.98.patch
against 0.98 branch at commit 37ef793fabc633557c994ab0ff8e6024d799d48a.
ATTACHMENT ID: 12695889
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
23 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 42 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/patchReleaseAuditWarnings.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12686//console
This message is automatically generated.
> Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade
> section
> ---
>
> Key: HBASE-12914
> URL: https://issues.apache.org/jira/browse/HBASE-12914
> Project: HBase
> Issue Type: Bug
> Components: API, documentation
>Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9
>Reporter: Sean Busbey
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 0.98.11
>
> Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch,
> HBASE-12914.patch
>
>
> There are several features in 0.98 that require enabling HFilev3 support.
> Some of those features include new extendable components that are marked
> IA.Public.
> Current practice has been to treat these features as experimental. This has
> included pushing non-compatible changes to branch-1 as the API got worked out
> through use in 0.98.
> * Update all of the IA.Public classes involved to make sure they are
> IS.Unstable in 0.98.
> * Update the
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304695#comment-14304695 ] Sean Busbey commented on HBASE-12914: - I don't think we need a special InterfaceAudience setting. AFAICT, most of these APIs are settled enough in 1.0+ for how they're labeled. The goal here was just to make sure early adopters on the 0.98 line had a heads-up appropriate for how we've been handling changes. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304646#comment-14304646 ] ramkrishna.s.vasudevan commented on HBASE-12914: [~ndimiduk] Thanks for looking into the RB. I think as per the discussions over the other JIRA as 0.98 was considering TAgs as experimental better to notify the APIs and related features as Unstable. I think marking Unstable is fine with me. What others think here? > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301664#comment-14301664 ] Nick Dimiduk commented on HBASE-12914: -- Just skimmed though the RB. Does it make sense to annotate them specifically as "HFileV3," in the same way that we annotate limited-pivate APIs as for "Phoenix" or "Coprocs"? > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301031#comment-14301031 ] ramkrishna.s.vasudevan commented on HBASE-12914: https://reviews.apache.org/r/30491/ - RB link. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-0.98.patch, HBASE-12914-branch-1.patch, > HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[
https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300030#comment-14300030
]
Sean Busbey commented on HBASE-12914:
-
{quote}
Cell and CellUtil methods related to Tags to be declared UnStable? Currently we
don't allow user to control these tags ie. there are not APIs which allow users
to add a tag in the mutation directly.
Also from the RPC side the tags are filtered out before sending it out to the
clients. So will that make sense to change them to Unstable?
{quote}
I only included them because the classes are marked Public. It's really hard to
know how end users will abuse whatever we have marked as available; even if we
don't have an obvious direct way for them to be used in normal HBase operations
it's hard to know that we won't break someone.
{quote}
Should we be marking the protobuf changes as well?
Encryption.proto
HFile.proto trailer field encryption_key
{quote}
The more I think about this, the more I would like us to not mark any protobuf
stuff unstable (in case anyone was entertaining it).
> Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade
> section
> ---
>
> Key: HBASE-12914
> URL: https://issues.apache.org/jira/browse/HBASE-12914
> Project: HBase
> Issue Type: Bug
> Components: API, documentation
>Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9
>Reporter: Sean Busbey
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 0.98.11
>
> Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch
>
>
> There are several features in 0.98 that require enabling HFilev3 support.
> Some of those features include new extendable components that are marked
> IA.Public.
> Current practice has been to treat these features as experimental. This has
> included pushing non-compatible changes to branch-1 as the API got worked out
> through use in 0.98.
> * Update all of the IA.Public classes involved to make sure they are
> IS.Unstable in 0.98.
> * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks
> aware of these changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299749#comment-14299749 ] ramkrishna.s.vasudevan commented on HBASE-12914: [~busbey] Thanks for providing the entire list. I thought if the VisibilityExpResolver is marked Unstable then the CellCreator and ImportTSV related things also become Unstable because they are used in the ImportTSV tool. Cell and CellUtil methods related to Tags to be declared UnStable? Currently we don't allow user to control these tags ie. there are not APIs which allow users to add a tag in the mutation directly. Also from the RPC side the tags are filtered out before sending it out to the clients. So will that make sense to change them to Unstable? > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299745#comment-14299745 ] ramkrishna.s.vasudevan commented on HBASE-12914: No problem in making the changes against 0.98 as per the desired intent of this JIRA. As the features dependent on 0.98 like the cell ACLs, visibility tags we do not know about real users using them the thought of having them as experimental on branch-1 happened. [~anoop.hbase] - Am I right for your reasoning on having Unstable in branch-1 also? Hence the reason why I too prepared a patch against branch-1. Anyway as part of this JIRA would update the patch against 0.98 and move the discussion on branch-1 to a new JIRA. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299252#comment-14299252 ] Andrew Purtell commented on HBASE-12914: Tagging whole interfaces and subsets both seem fine, as long as we are just modifying 0.98 at this point. If there's a strong desire to keep in 1.0 the experimental label for all of HFile v3 or subsets of features based on it, let's have that discussion on a new issue, so we can hash it out there. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299042#comment-14299042 ] Sean Busbey commented on HBASE-12914: - I think I was the one who originally included a fix version on the 1.x line. I only did that because I wasn't sure if we were comfortable holding to the stronger stability promises after the 0.98 -> 1.0 transition. If we are, that's excellent by me. Are updates to the ref guide in master and the API annotations only in 0.98 fine by everyone? [~apurtell], would you prefer this just be updates to java Interfaces? I originally scoped the title at "features" to be broader than just interfaces because I wasn't sure if we had broken compatibility elsewhere. I figured broad warnings that end up not having breakage are better than narrow ones that miss something. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298897#comment-14298897 ] Andrew Purtell commented on HBASE-12914: Let me formally -1 the branch 1 patch. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298896#comment-14298896 ] Andrew Purtell commented on HBASE-12914: The *only* reason any of the mentioned interfaces are "unstable", relative to any other change we have made such as region replicas, API refactorings, load pushback, etc. etc. is specifically when HFile V3 was introduced out of an abundance of caution we explicitly said it would be experimental for the duration of the 0.98 release. The discussion above has gotten way out of hand in my opinion. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298892#comment-14298892 ] Andrew Purtell commented on HBASE-12914: No, this issue is about marking classes in 0.98 -- it's right there in the subject -- that are unstable because we said HFileV3 and all features depending on it are experimental for the lifetime of the release line. We should not be marking them unstable in 1.0, since HFileV3 is no longer declared experimental. It's a separate issue if you want to look at the features individually. I think a branch-1 patch with unstable tags is incorrect in the scope of this issue and with respect to the status of HFile v3 in 1.0 (if it's not stable, why is it the default??) > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298830#comment-14298830 ] Sean Busbey commented on HBASE-12914: - Few more: * org.apache.hadoop.hbase.security.visibility.* (i.e. Authorizations, CellVisibility, VisibilityClient, etc) * org.apache.hadoop.hbase.mapreduce.CellCreator VISIBILITY_EXP_RESOLVER_CLASS * org.apache.hadoop.hbase.mapreduce.CellCreator the methods that takes a vis expressions and getVisibilityExpressionResolver * org.apache.hadoop.hbase.mapreduce.ImportTsv CELL_VISIBILITY_COLUMN_SPEC, CELL_TTL_COLUMN_SPEC, DEFAULT_CELL_VISIBILITY_COLUMN_INDEX, DEFAULT_CELL_TTL_COLUMN_INDEX * org.apache.hadoop.hbase.mapreduce.ImportTsv all of the public methods related to per-cell ttl or visibility * org.apache.hadoop.hbase.mapreduce.TsvImporterMapper members cellVisibilityExpr and ttl on branch-1 (but not an issue on 0.98) * We should annotate the per-cell methods that are unstable in sub-classes of Mutation as well, to remove ambiguity. * For the same reason, Scan needs the same things annotated as Query I'm not clear on if we're considering APIs related to Cell Tags themselves unstable. If so * HColumnDescriptor methods about how tags should be handled * Cell methods related to tags * CellUtil methods related to tags * org.apache.hadoop.hbase.mapreduce.CellCreator any of the methods that use Tag > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298797#comment-14298797 ] Sean Busbey commented on HBASE-12914: - I presume anything in the shell is covered under our "Operational Compatibility" section? That would mean we don't need to mark any of it, since it has the same limitations as Public Unstable. This is getting big enough that a reviewboard would help (atleast for me). * please do documentation updates on master branch; we use that to generate documentation for all versions. Things that also need to be marked Unstable: * HColumnDescriptor ENCRYPTION and ENCRYPTION_KEY * HConstants CRYPTO_* * org.apache.hadoop.hbase.io.crypto.* * org.apache.hadoop.hbase.util.EncryptionTest Should we be marking the protobuf changes as well? * Encryption.proto * HFile.proto trailer field encryption_key > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > Attachments: HBASE-12914-branch-1.patch, HBASE-12914.patch > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[
https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298364#comment-14298364
]
Hadoop QA commented on HBASE-12914:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12695465/HBASE-12914-branch-1.patch
against branch-1 branch at commit b08802a3e8e522f84519415b83455870b49bf8da.
ATTACHMENT ID: 12695465
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
12 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Since the HFileV3 dependent features are considered
experimental in 0.98 there could be API changes in the user facing interfaces
and APIs like
+ The VisibilityLabelService
interface which is used to control the way visibility labels are stored in
cells may have some API changes.
+ The client APIs related to features like Cell level ACL,
Visibility tags, TTL, HFile Encryption are all marked
+ Unstable to indicate that either the APIs/feature may undergo
changes in the future major versions of HBase.
+APIs in Mutation.java related to cell level ACL, cell level
visibility labels, per cell TTL
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12646//console
This message is automatically generated.
> Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade
> section
> ---
>
> Key: HBASE-12914
> URL: https://issues.apache.org/jira/browse/HBASE-12914
> Project: HBase
> Issue Type: Bug
> Components: API, documentation
>Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9
>Reporter: Sean Busbey
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For:
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298248#comment-14298248 ] Sean Busbey commented on HBASE-12914: - The way I read the conversation on api stability around these things, we need to mark all of them. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298242#comment-14298242 ] ramkrishna.s.vasudevan commented on HBASE-12914: bq.I don't think that's quite enough. For example, per-cell TTL means that Mutation.setTTL and Mutation.getTTL should be marked Unstable. Ok got it. I was thinking only interface level we mark the IS.Unstable. Can we use the same for APIs also? > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298214#comment-14298214 ] Sean Busbey commented on HBASE-12914: - similarly, the hfile encryption stuff means HColumnDescriptor's methods for get/setEncryption* and the encryption related constants should be marked. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298206#comment-14298206 ] Sean Busbey commented on HBASE-12914: - I have not started at all. It would be great if you could take this up. Please note that we can push the change from Evolving -> Unstable in branch-1, but we can't push it to branch-1.0 unless the current RC fails. bq. The other features like ACL does not explicitly expose any API that is bound to change based on V3. Similar is the case with TTL. So if we mark the interfaces related to Visibililty as Unstable and add a note in the ref section will it be fine? I don't think that's quite enough. For example, per-cell TTL means that Mutation.setTTL and Mutation.getTTL should be marked Unstable. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298197#comment-14298197 ] Anoop Sam John commented on HBASE-12914: May be keep the visibility related public interfaces as Unstable in 1.x also..? The feature as such is not declared production ready even in branch-1. So better keep as is in 0.98 way in branch-1 also. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298193#comment-14298193 ] ramkrishna.s.vasudevan commented on HBASE-12914: bq.should the interfaces stay IS.Unstable in branch-1 and/or master? I think this can remain as is in master and branch-1. Because the feature once released in 1.0 is considered to be stable because V3 is default. bq.how about the classes involved exclusively in those features? You mean only the exposed interfaces? In 0.98 we could mark VisibilityLabelService, VisibilityExpEvaluator, VisibilityExpressionResolver as unstable because they are the public facing interfaces. (Any other interface is missed)? The other features like ACL does not explicitly expose any API that is bound to change based on V3. Similar is the case with TTL. So if we mark the interfaces related to Visibililty as Unstable and add a note in the ref section will it be fine? I can take this up [~busbey] if you have not started working on this. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293391#comment-14293391 ] ramkrishna.s.vasudevan commented on HBASE-12914: Thanks [~apurtell]. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.1, 0.98.11 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292194#comment-14292194 ] Andrew Purtell commented on HBASE-12914: Adding to Ram's list: - HFile encryption > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 0.98.10, 1.0.1 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291497#comment-14291497 ] Enis Soztutar commented on HBASE-12914: --- Moving this to 1.0.1 for now. We can document these APIs in the book for now. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 0.98.10, 1.0.1 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291461#comment-14291461 ] ramkrishna.s.vasudevan commented on HBASE-12914: -> Cell level ACLs -> Visibility Tags -> Region sequencing based on tags -> TTL based on Tags. are some of the features dependent on V3. > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.0, 0.98.10 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12914) Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade section
[ https://issues.apache.org/jira/browse/HBASE-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291359#comment-14291359 ] Sean Busbey commented on HBASE-12914: - Some questions * should the interfaces stay IS.Unstable in branch-1 and/or master? or remain however they currently are since HFilev3 is now default? * does some one have a list of all the features that rely on hfilev3? how about the classes involved exclusively in those features? > Mark public features that require HFilev3 Unstable in 0.98, warn in upgrade > section > --- > > Key: HBASE-12914 > URL: https://issues.apache.org/jira/browse/HBASE-12914 > Project: HBase > Issue Type: Bug > Components: API, documentation >Affects Versions: 0.98.6, 0.98.7, 0.98.8, 0.98.9 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.0.0, 0.98.10 > > > There are several features in 0.98 that require enabling HFilev3 support. > Some of those features include new extendable components that are marked > IA.Public. > Current practice has been to treat these features as experimental. This has > included pushing non-compatible changes to branch-1 as the API got worked out > through use in 0.98. > * Update all of the IA.Public classes involved to make sure they are > IS.Unstable in 0.98. > * Update the ref guide section on upgrading from 0.98 -> 1.0 to make folks > aware of these changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
