[jira] [Commented] (HBASE-12923) ResultScanner is not closed in ModifyTableHandler#removeReplicaColumnsIfNeeded()
[
https://issues.apache.org/jira/browse/HBASE-12923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292996#comment-14292996
]
Anoop Sam John commented on HBASE-12923:
patch LGTM
> ResultScanner is not closed in
> ModifyTableHandler#removeReplicaColumnsIfNeeded()
>
>
> Key: HBASE-12923
> URL: https://issues.apache.org/jira/browse/HBASE-12923
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12923-v1.txt
>
>
> In ModifyTableHandler#removeReplicaColumnsIfNeeded():
> {code}
> ResultScanner resScanner = metaTable.getScanner(scan);
> for (Result result : resScanner) {
> {code}
> The ResultScanner is not closed upon exit from the method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12923) ResultScanner is not closed in ModifyTableHandler#removeReplicaColumnsIfNeeded()
[
https://issues.apache.org/jira/browse/HBASE-12923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292463#comment-14292463
]
Ted Yu commented on HBASE-12923:
TestLoadIncrementalHFiles passes locally with the patch.
> ResultScanner is not closed in
> ModifyTableHandler#removeReplicaColumnsIfNeeded()
>
>
> Key: HBASE-12923
> URL: https://issues.apache.org/jira/browse/HBASE-12923
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12923-v1.txt
>
>
> In ModifyTableHandler#removeReplicaColumnsIfNeeded():
> {code}
> ResultScanner resScanner = metaTable.getScanner(scan);
> for (Result result : resScanner) {
> {code}
> The ResultScanner is not closed upon exit from the method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12923) ResultScanner is not closed in ModifyTableHandler#removeReplicaColumnsIfNeeded()
[
https://issues.apache.org/jira/browse/HBASE-12923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292335#comment-14292335
]
Hadoop QA commented on HBASE-12923:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12694589/12923-v1.txt
against master branch at commit 1c1a306b2e4bdd5a4ff877634c5064097637e2f2.
ATTACHMENT ID: 12694589
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12588//console
This message is automatically generated.
> ResultScanner is not closed in
> ModifyTableHandler#removeReplicaColumnsIfNeeded()
>
>
> Key: HBASE-12923
> URL: https://issues.apache.org/jira/browse/HBASE-12923
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12923-v1.txt
>
>
> In ModifyTableHandler#removeReplicaColumnsIfNeeded():
> {code}
> ResultScanner resScanner = metaTable.getScanner(scan);
> for (Result result : resScanner) {
> {code}
> The ResultScanner is not closed upon exit from the method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
