[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542426#comment-14542426 ] Solomon Duskis commented on HBASE-13201: Greatly appreciated [~ndimiduk]. Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 1.1.0, 1.0.2 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201-2-branch-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542625#comment-14542625 ] Hudson commented on HBASE-13201: FAILURE: Integrated in HBase-1.0 #915 (See [https://builds.apache.org/job/HBase-1.0/915/]) HBASE-13201 Remove HTablePool from thrift-server (Solomon Duskis) (ndimiduk: rev 7dfd4399053d06bad7d0d5dd3e538fdc5c4c5029) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 1.1.0, 1.0.2 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201-2-branch-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541119#comment-14541119 ] Solomon Duskis commented on HBASE-13201: [~ndimiduk] It doesn't look like this made it into branch-1.0. Any chance you can apply HBASE-13201-2-branch-1.patch to it? It looks like it still applies cleanly. HBASE-13664 has a dependency on this patch. Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201-2-branch-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384159#comment-14384159 ] Nick Dimiduk commented on HBASE-13201: -- +1 thanks [~sduskis]. Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201-2-branch-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384236#comment-14384236 ] Hudson commented on HBASE-13201: FAILURE: Integrated in HBase-1.1 #331 (See [https://builds.apache.org/job/HBase-1.1/331/]) HBASE-13201 Remove HTablePool from thrift-server (Solomon Duskis) (ndimiduk: rev 242f62ffcde517d4013d38cbf37b3ad6012c1f19) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201-2-branch-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380729#comment-14380729 ] Solomon Duskis commented on HBASE-13201: [~ndimiduk] how does the new branch-1 patch look? Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201-2-branch-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378214#comment-14378214 ] Solomon Duskis commented on HBASE-13201: I submitted a bad patch. I'll resubmit. Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[
https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378123#comment-14378123
]
Hadoop QA commented on HBASE-13201:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12706935/HBASE-13201-2-branch-1.patch
against branch-1 branch at commit 80d230e1fbeac24d3dfdac8165e24f35ec26f988.
ATTACHMENT ID: 12706935
{color:red}-1 @author{color}. The patch appears to contain 2 @author tags
which the Hadoop community has agreed to not allow in code contributions.
{color:green}+1 tests included{color}. The patch appears to include 2245
new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13388//console
This message is automatically generated.
Remove HTablePool from thrift-server
Key: HBASE-13201
URL: https://issues.apache.org/jira/browse/HBASE-13201
Project: HBase
Issue Type: Sub-task
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Fix For: 2.0.0
Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch,
HBASE-13201-2-branch-1.patch, HBASE-13201.patch
HTablePool is an old concept that was superseded by Connection.
thrift-server doesn't need HTablePool anymore and can use the ConnectionCache
directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[
https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378490#comment-14378490
]
Hadoop QA commented on HBASE-13201:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12706955/HBASE-13201-2-branch-1.patch
against branch-1 branch at commit fcc09dcd38b8543a9dd40212206cb4231620dac9.
ATTACHMENT ID: 12706955
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13391//console
This message is automatically generated.
Remove HTablePool from thrift-server
Key: HBASE-13201
URL: https://issues.apache.org/jira/browse/HBASE-13201
Project: HBase
Issue Type: Sub-task
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Fix For: 2.0.0
Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch,
HBASE-13201-2-branch-1.patch, HBASE-13201.patch
HTablePool is an old concept that was superseded by Connection.
thrift-server doesn't need HTablePool anymore and can use the ConnectionCache
directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377131#comment-14377131 ] Nick Dimiduk commented on HBASE-13201: -- HTablePool has only been deprecated since 0.98, so I think we cannot remove it from branch-1 yet. [~apurtell], [~enis] I have that right? We can replace it's use by thrift-server with standard Connection objects though. Does that findbugs warning come from your changes, or is it a leak from another patch? Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377212#comment-14377212 ] Solomon Duskis commented on HBASE-13201: Replacing usage sounds reasonable to me. I don't recall what the findbugs issue was. I think there might have been a couple related to my change. I do remember fixing all of findbugs issue for the classes I touched in the -1.patch. Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371657#comment-14371657 ] Solomon Duskis commented on HBASE-13201: [~ndimiduk] What say you about getting this into branch-1? Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363689#comment-14363689 ] Solomon Duskis commented on HBASE-13201: What's the good word in getting this into branch-1? The TestNamespaceAuditor problems in https://builds.apache.org/job/HBase-TRUNK/6247/ don't seem to be related to my change. Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358938#comment-14358938 ] Nick Dimiduk commented on HBASE-13201: -- Looks fine by me. +1 [~larsgeorge] and [~octo47] are the most recent folks I can think of who've had their fingers in thrift/thrift2. Any objections fellas? Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[
https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357110#comment-14357110
]
Hadoop QA commented on HBASE-13201:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12703896/HBASE-13201.patch
against master branch at commit e66dca6cd1fd91bfa65a7cd4c68acb7a7f6a6c4e.
ATTACHMENT ID: 12703896
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1927 checkstyle errors (more than the master's current 1924 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13187//console
This message is automatically generated.
Remove HTablePool from thrift-server
Key: HBASE-13201
URL: https://issues.apache.org/jira/browse/HBASE-13201
Project: HBase
Issue Type: Sub-task
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Fix For: 2.0.0, 1.0.1
Attachments: HBASE-13201.patch
HTablePool is an old concept that was superseded by Connection.
thrift-server doesn't need HTablePool anymore and can use the ConnectionCache
directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357842#comment-14357842 ] Solomon Duskis commented on HBASE-13201: HTablePool is in hbase-client in the 1.0 branch. I'll create a separate patch for it. Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 1.0.1 Attachments: HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[
https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357980#comment-14357980
]
Hadoop QA commented on HBASE-13201:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704054/HBASE-13201-1.patch
against master branch at commit 9c83fa7b52188d6bdfebcba75272c5c11e8b8566.
ATTACHMENT ID: 12704054
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13205//console
This message is automatically generated.
Remove HTablePool from thrift-server
Key: HBASE-13201
URL: https://issues.apache.org/jira/browse/HBASE-13201
Project: HBase
Issue Type: Sub-task
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Fix For: 2.0.0, 1.0.1
Attachments: HBASE-13201-1.patch, HBASE-13201.patch
HTablePool is an old concept that was superseded by Connection.
thrift-server doesn't need HTablePool anymore and can use the ConnectionCache
directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357992#comment-14357992 ] Ted Yu commented on HBASE-13201: Yes, please. Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[
https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358085#comment-14358085
]
Hadoop QA commented on HBASE-13201:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704075/HBASE-13201-1-branch-1.patch
against branch-1 branch at commit ff8840acc3d3f258c933c91b275922d6528b6893.
ATTACHMENT ID: 12704075
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13208//console
This message is automatically generated.
Remove HTablePool from thrift-server
Key: HBASE-13201
URL: https://issues.apache.org/jira/browse/HBASE-13201
Project: HBase
Issue Type: Sub-task
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Fix For: 2.0.0
Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch,
HBASE-13201.patch
HTablePool is an old concept that was superseded by Connection.
thrift-server doesn't need HTablePool anymore and can use the ConnectionCache
directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358105#comment-14358105 ] Hudson commented on HBASE-13201: FAILURE: Integrated in HBase-TRUNK #6247 (See [https://builds.apache.org/job/HBase-TRUNK/6247/]) HBASE-13201 Remove HTablePool from thrift-server (Solomon Duskis) (tedyu: rev ff8840acc3d3f258c933c91b275922d6528b6893) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/HTablePool.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestHTablePool.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1-branch-1.patch, HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13201) Remove HTablePool from thrift-server
[ https://issues.apache.org/jira/browse/HBASE-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357989#comment-14357989 ] Solomon Duskis commented on HBASE-13201: Should I do a separate submit for branch-1 which also has a similar problem? Remove HTablePool from thrift-server Key: HBASE-13201 URL: https://issues.apache.org/jira/browse/HBASE-13201 Project: HBase Issue Type: Sub-task Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0 Attachments: HBASE-13201-1.patch, HBASE-13201.patch HTablePool is an old concept that was superseded by Connection. thrift-server doesn't need HTablePool anymore and can use the ConnectionCache directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
