[jira] [Commented] (HBASE-13286) Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
[
https://issues.apache.org/jira/browse/HBASE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372030#comment-14372030
]
Hudson commented on HBASE-13286:
FAILURE: Integrated in HBase-TRUNK #6283 (See
[https://builds.apache.org/job/HBase-TRUNK/6283/])
HBASE-13286 Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
(nkeywal: rev 6d4460341e0d44bfb574180369748e17fbe5f5a1)
*
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java
Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
-
Key: HBASE-13286
URL: https://issues.apache.org/jira/browse/HBASE-13286
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 1.0.0, 0.98.12
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Priority: Minor
Fix For: 1.1.0
Attachments: 13286.patch
There is a check in the client to be sure that we don't use a timeout of zero
(i.e. infinite). This includes setting the minimal time out for a rpc timeout
to 2 seconds. However, it makes sense for some calls (typically gets going to
the cache) to have much lower timeouts. So it's better to do the check vs.
zero but with a minimal timeout of 1.
I fixed a typo a wrong comment in this patch as well. I don't understand
this code:
{code}
// t could be a RemoteException so go around again.
translateException(t); // We don't use the result?
{code}
but may be it's good.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13286) Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
[
https://issues.apache.org/jira/browse/HBASE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369715#comment-14369715
]
stack commented on HBASE-13286:
---
+1
Why remove MIN_RPC_TIMEOUT though? Why not just set it to 1 instead of 2000?
Good catch.
Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
-
Key: HBASE-13286
URL: https://issues.apache.org/jira/browse/HBASE-13286
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 1.0.0, 0.98.12
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Priority: Minor
Fix For: 1.1.0
Attachments: 13286.patch
There is a check in the client to be sure that we don't use a timeout of zero
(i.e. infinite). This includes setting the minimal time out for a rpc timeout
to 2 seconds. However, it makes sense for some calls (typically gets going to
the cache) to have much lower timeouts. So it's better to do the check vs.
zero but with a minimal timeout of 1.
I fixed a typo a wrong comment in this patch as well. I don't understand
this code:
{code}
// t could be a RemoteException so go around again.
translateException(t); // We don't use the result?
{code}
but may be it's good.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13286) Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
[
https://issues.apache.org/jira/browse/HBASE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369735#comment-14369735
]
Nicolas Liochon commented on HBASE-13286:
-
bq. Good catch.
Not really, it's me who put it a while ago (to fix the infinite timeout), and
I've been questioning myself about this for a while. :-)
bq. Why remove MIN_RPC_TIMEOUT though? Why not just set it to 1 instead of 2000?
I thought it would make the code simpler to read. As you like, I can change it.
For the stack during the tests:
org.apache.oozie.test.MiniHCatServer$1.run(MiniHCatServer.java:137)
It's because H10 is configured to run two builds in parallel, and this is
looking for trouble. We ran with a oozie build.
From what I see the findbug is already not from me.
I will commit tomorrow my time if there is no objection.
Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
-
Key: HBASE-13286
URL: https://issues.apache.org/jira/browse/HBASE-13286
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 1.0.0, 0.98.12
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Priority: Minor
Fix For: 1.1.0
Attachments: 13286.patch
There is a check in the client to be sure that we don't use a timeout of zero
(i.e. infinite). This includes setting the minimal time out for a rpc timeout
to 2 seconds. However, it makes sense for some calls (typically gets going to
the cache) to have much lower timeouts. So it's better to do the check vs.
zero but with a minimal timeout of 1.
I fixed a typo a wrong comment in this patch as well. I don't understand
this code:
{code}
// t could be a RemoteException so go around again.
translateException(t); // We don't use the result?
{code}
but may be it's good.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13286) Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
[
https://issues.apache.org/jira/browse/HBASE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369381#comment-14369381
]
Ted Yu commented on HBASE-13286:
lgtm
Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
-
Key: HBASE-13286
URL: https://issues.apache.org/jira/browse/HBASE-13286
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 1.0.0, 0.98.12
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Priority: Minor
Fix For: 1.1.0
Attachments: 13286.patch
There is a check in the client to be sure that we don't use a timeout of zero
(i.e. infinite). This includes setting the minimal time out for a rpc timeout
to 2 seconds. However, it makes sense for some calls (typically gets going to
the cache) to have much lower timeouts. So it's better to do the check vs.
zero but with a minimal timeout of 0.
I fixed a typo a wrong comment in this patch as well. I don't understand
this code:
{code}
// t could be a RemoteException so go around again.
translateException(t); // We don't use the result?
{code}
but may be it's good.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13286) Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
[
https://issues.apache.org/jira/browse/HBASE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369451#comment-14369451
]
Nicolas Liochon commented on HBASE-13286:
-
Thanks Ted, let see what hadoop-qa says, I hope I won't discover an ocean of
race conditions here :-).
Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
-
Key: HBASE-13286
URL: https://issues.apache.org/jira/browse/HBASE-13286
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 1.0.0, 0.98.12
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Priority: Minor
Fix For: 1.1.0
Attachments: 13286.patch
There is a check in the client to be sure that we don't use a timeout of zero
(i.e. infinite). This includes setting the minimal time out for a rpc timeout
to 2 seconds. However, it makes sense for some calls (typically gets going to
the cache) to have much lower timeouts. So it's better to do the check vs.
zero but with a minimal timeout of 1.
I fixed a typo a wrong comment in this patch as well. I don't understand
this code:
{code}
// t could be a RemoteException so go around again.
translateException(t); // We don't use the result?
{code}
but may be it's good.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13286) Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
[
https://issues.apache.org/jira/browse/HBASE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369659#comment-14369659
]
Hadoop QA commented on HBASE-13286:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12705602/13286.patch
against master branch at commit 27cf749af884edae55454c885c7fb066f0a33c79.
ATTACHMENT ID: 12705602
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at org.apache.oozie.test.MiniHCatServer$1.run(MiniHCatServer.java:137)
at
org.apache.oozie.test.XTestCase$MiniClusterShutdownMonitor.run(XTestCase.java:1071)
at org.apache.oozie.test.XTestCase.waitFor(XTestCase.java:692)
at
org.apache.oozie.action.hadoop.TestDistCpActionExecutor.testDistCpFile(TestDistCpActionExecutor.java:66)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13316//console
This message is automatically generated.
Minimum timeout for a rpc call could be 1 ms instead of 2 seconds
-
Key: HBASE-13286
URL: https://issues.apache.org/jira/browse/HBASE-13286
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 1.0.0, 0.98.12
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Priority: Minor
Fix For: 1.1.0
Attachments: 13286.patch
There is a check in the client to be sure that we don't use a timeout of zero
(i.e. infinite). This includes setting the minimal time out for a rpc
