[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637830#comment-14637830 ] Hudson commented on HBASE-13737: FAILURE: Integrated in HBase-TRUNK #6672 (See [https://builds.apache.org/job/HBase-TRUNK/6672/]) HBASE-13737 [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. (Ashutosh Jindal) (anoopsamjohn: rev 2e2742183fac824dcf19c556fdc8ae1da326ba7c) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileLinkCleaner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMobSnapshotCloneIndependence.java [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 Attachments: HBASE-13737-V2.diff, HBASE-13737-hbase-11339.patch clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587713#comment-14587713 ] Anoop Sam John commented on HBASE-13737: +1 [~te...@apache.org] Any chance for a review and +1? [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 Attachments: HBASE-13737-V2.diff, HBASE-13737-hbase-11339.patch clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587741#comment-14587741 ] ramkrishna.s.vasudevan commented on HBASE-13737: +1 [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 Attachments: HBASE-13737-V2.diff, HBASE-13737-hbase-11339.patch clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14585607#comment-14585607 ] Jingcheng Du commented on HBASE-13737: -- Hi [~yuzhih...@gmail.com], [~anoopsamjohn], [~ram_krish]. Do you want to take a look at the new patch? Thanks. [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 Attachments: HBASE-13737-V2.diff, HBASE-13737-hbase-11339.patch clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14583186#comment-14583186 ] Jingcheng Du commented on HBASE-13737: -- Alright, I'll supplement the unit test. [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 Attachments: HBASE-13737-hbase-11339.patch clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[
https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581330#comment-14581330
]
Jingcheng Du commented on HBASE-13737:
--
Thanks [~ashutosh_jindal] for the patch.
{noformat}
HFileLink.getHFileFromBackReference(MobUtils.getMobHome(getConf()), filePath);
{noformat}
For the MobUtils.getMobHome(getConf()), how about to move it to the constructor
instead of getting it per invoking?
Besides, would you mind adding unit tests for this case? Thanks a lot.
[HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that
actual snapshot and main table is deleted.
Key: HBASE-13737
URL: https://issues.apache.org/jira/browse/HBASE-13737
Project: HBase
Issue Type: Bug
Components: mob
Affects Versions: hbase-11339
Reporter: Y. SREENIVASULU REDDY
Assignee: Ashutosh Jindal
Priority: Critical
Fix For: hbase-11339
Attachments: HBASE-13737-hbase-11339.patch
clone snapshot on mob feature leads to data loss for mob data.
steps to reproduce:
===
1. created MOB table with two column families like mobcf (mob is enabled)
and norcf
2. insert mob data and normal data at a time into the table.
3. scan the MOB table.
4. take snapshot by specifying the table name.
5. clone the snapshot by specifying the new table name.
6. check the new table is created or not and try scan for the new table which
have both mob data and normal data should give back to the client.
7. delete the snapshot which done in step 4.
8. delete the main table which done in step 1.
9. Now scan the new table again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553961#comment-14553961 ] Anoop Sam John commented on HBASE-13737: What about the non mob cf data? [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554222#comment-14554222 ] Anoop Sam John commented on HBASE-13737: Ya I was thinking some thing of this sort might be the cause and that is why asked abt the normal CF data. Agree this is a critical bug in MOB snapshot feature. Hope you guys will give patch. :-) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554217#comment-14554217 ] Ashutosh Jindal commented on HBASE-13737: - Non mob data is intact. As per initial analysis, the problem is in HFileLinkCleaner.isFileDeletable . Once we clone a snapshot, the data is moved to /hbase/archive/ .HFileCleaner checks for back reference for all the files in /hbase/archive/ dir but it checks for back references in rootDir i.e. /hbase. In case of MOB data, cleaner will not find it in rootDir and will delete the link. Here we need to check in for references in /hbase/mobdir also. [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13737) [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted.
[ https://issues.apache.org/jira/browse/HBASE-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554366#comment-14554366 ] Ted Yu commented on HBASE-13737: Is it possible to add a test in TestMobCloneSnapshotFromClient.java so that regression is prevented in the future ? Thanks [HBase MOB] MOBTable cloned from a snapshot leads to data loss, when that actual snapshot and main table is deleted. Key: HBASE-13737 URL: https://issues.apache.org/jira/browse/HBASE-13737 Project: HBase Issue Type: Bug Components: mob Affects Versions: hbase-11339 Reporter: Y. SREENIVASULU REDDY Assignee: Ashutosh Jindal Priority: Critical Fix For: hbase-11339 Attachments: HBASE-13737-hbase-11339.patch clone snapshot on mob feature leads to data loss for mob data. steps to reproduce: === 1. created MOB table with two column families like mobcf (mob is enabled) and norcf 2. insert mob data and normal data at a time into the table. 3. scan the MOB table. 4. take snapshot by specifying the table name. 5. clone the snapshot by specifying the new table name. 6. check the new table is created or not and try scan for the new table which have both mob data and normal data should give back to the client. 7. delete the snapshot which done in step 4. 8. delete the main table which done in step 1. 9. Now scan the new table again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
