[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570434#comment-14570434 ] Hudson commented on HBASE-13826: SUCCESS: Integrated in HBase-1.2 #131 (See [https://builds.apache.org/job/HBase-1.2/131/]) HBASE-13826 Unable to create table when group acls are appropriately set. (ssrungarapu: rev e8914f26d2fcb3958d839f6c69d7c4a308cd5512) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570467#comment-14570467 ] Hudson commented on HBASE-13826: FAILURE: Integrated in HBase-1.1 #521 (See [https://builds.apache.org/job/HBase-1.1/521/]) HBASE-13826 Unable to create table when group acls are appropriately set. (ssrungarapu: rev ff5f02efeb297d3e1bf5dc5c38e80c61a39e81fc) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570596#comment-14570596 ] Hudson commented on HBASE-13826: FAILURE: Integrated in HBase-0.98 #1019 (See [https://builds.apache.org/job/HBase-0.98/1019/]) HBASE-13826 Unable to create table when group acls are appropriately set. (ssrungarapu: rev ea7d2c3c0406324de649c9f44978e5643de758b7) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java HBASE-13826 Unable to create table when group acls are appropriately set; ADDENDUM - Get rid of connection api in unit test (ssrungarapu: rev 98e63c3cd27ad001c3ae82dcd9d32c580e26ff95) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570353#comment-14570353 ] Hudson commented on HBASE-13826: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #971 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/971/]) HBASE-13826 Unable to create table when group acls are appropriately set. (ssrungarapu: rev ea7d2c3c0406324de649c9f44978e5643de758b7) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570349#comment-14570349 ] Srikanth Srungarapu commented on HBASE-13826: - Too eager to get this fix in :). Thanks for bringing this to notice. Pushed the addendum. Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570532#comment-14570532 ] Hudson commented on HBASE-13826: FAILURE: Integrated in HBase-TRUNK #6543 (See [https://builds.apache.org/job/HBase-TRUNK/6543/]) HBASE-13826 Unable to create table when group acls are appropriately set. (ssrungarapu: rev fad545652fc330d11061a1608e7812dade7f0845) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570456#comment-14570456 ] Hudson commented on HBASE-13826: FAILURE: Integrated in HBase-1.0 #945 (See [https://builds.apache.org/job/HBase-1.0/945/]) HBASE-13826 Unable to create table when group acls are appropriately set. (ssrungarapu: rev 0214c125ec3f7245ac367bff60ff727703868bd9) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569942#comment-14569942 ] Ted Yu commented on HBASE-13826: lgtm Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569945#comment-14569945 ] Matteo Bertozzi commented on HBASE-13826: - +1 Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570159#comment-14570159 ] Anoop Sam John commented on HBASE-13826: Patch looks good. Any other places we missing checking against the user's group privileges? Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[
https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570134#comment-14570134
]
Hadoop QA commented on HBASE-13826:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12737034/HBASE-13826.patch
against master branch at commit b7c0ac7cd7bebf78e5b6ce14179223fbb653e4c7.
ATTACHMENT ID: 12737034
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14261//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14261//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14261//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14261//console
This message is automatically generated.
Unable to create table when group acls are appropriately set.
-
Key: HBASE-13826
URL: https://issues.apache.org/jira/browse/HBASE-13826
Project: HBase
Issue Type: Bug
Components: security
Affects Versions: 2.0.0, 1.0.2, 1.2.0, 1.1.1
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Fix For: 2.0.0, 1.0.2, 1.2.0, 1.1.1
Attachments: HBASE-13826.patch
Steps for reproducing the issue.
- Create user 'test' and group 'hbase-admin'.
- Grant global create permissions to 'hbase-admin'.
- Add user 'test' to 'hbase-admin' group.
- Create table operation for 'test' user will throw ADE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[
https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570297#comment-14570297
]
Srikanth Srungarapu commented on HBASE-13826:
-
The other 4 public {{authorize}} calls are verifying user's group privileges
either directly or indirectly with one exception of the below {{authorize}}
used for cell tag checks, which is expected.
{code}
/**
* Authorize a user for a given KV. This is called from AccessControlFilter.
*/
public boolean authorize(User user, TableName table, Cell cell,
Permission.Action action) {
try {
ListPermission perms =
AccessControlLists.getCellPermissionsForUser(user, cell);
if (LOG.isTraceEnabled()) {
LOG.trace(Perms for user + user.getShortName() + in cell + cell
+ : +
(perms != null ? perms : ));
}
if (perms != null) {
for (Permission p: perms) {
if (p.implies(action)) {
return true;
}
}
}
} catch (IOException e) {
// We failed to parse the KV tag
LOG.error(Failed parse of ACL tag in cell + cell);
// Fall through to check with the table and CF perms we were able
// to collect regardless
}
return false;
}
{code}
Unable to create table when group acls are appropriately set.
-
Key: HBASE-13826
URL: https://issues.apache.org/jira/browse/HBASE-13826
Project: HBase
Issue Type: Bug
Components: security
Affects Versions: 2.0.0, 1.0.2, 1.2.0, 1.1.1
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
Attachments: HBASE-13826.patch
Steps for reproducing the issue.
- Create user 'test' and group 'hbase-admin'.
- Grant global create permissions to 'hbase-admin'.
- Add user 'test' to 'hbase-admin' group.
- Create table operation for 'test' user will throw ADE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570298#comment-14570298 ] Srikanth Srungarapu commented on HBASE-13826: - My bad. Overlooked it. Thanks for reminding me. Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[
https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570309#comment-14570309
]
Srikanth Srungarapu commented on HBASE-13826:
-
Thanks for the reviews. Committed to 0.98+ branches.
Made a small minor change of replacing {{'@' + TESTGROUP_1}} with
{{convertToGroup(TESTGROUP_1)}}.
Unable to create table when group acls are appropriately set.
-
Key: HBASE-13826
URL: https://issues.apache.org/jira/browse/HBASE-13826
Project: HBase
Issue Type: Bug
Components: security
Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
Attachments: HBASE-13826.patch
Steps for reproducing the issue.
- Create user 'test' and group 'hbase-admin'.
- Grant global create permissions to 'hbase-admin'.
- Add user 'test' to 'hbase-admin' group.
- Create table operation for 'test' user will throw ADE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13826) Unable to create table when group acls are appropriately set.
[ https://issues.apache.org/jira/browse/HBASE-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570313#comment-14570313 ] Ashish Singhi commented on HBASE-13826: --- Srikanth, did u apply the same patch to 0.98 as well ? I hope no, for 0.98 we need some test code modification. Unable to create table when group acls are appropriately set. - Key: HBASE-13826 URL: https://issues.apache.org/jira/browse/HBASE-13826 Project: HBase Issue Type: Bug Components: security Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: HBASE-13826.patch Steps for reproducing the issue. - Create user 'test' and group 'hbase-admin'. - Grant global create permissions to 'hbase-admin'. - Add user 'test' to 'hbase-admin' group. - Create table operation for 'test' user will throw ADE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
