[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-07-31 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650160#comment-14650160
 ] 

Hadoop QA commented on HBASE-13864:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12748279/HBASE-13864-4.patch
  against master branch at commit 377bf1937f8af733e40813e5d8bb9c962a8736e0.
  ATTACHMENT ID: 12748279

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14948//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14948//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14948//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14948//console

This message is automatically generated.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864-2.patch, 
> HBASE-13864-3.patch, HBASE-13864-4.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for TTL

2015-08-01 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650303#comment-14650303
 ] 

Hudson commented on HBASE-13864:


FAILURE: Integrated in HBase-TRUNK #6693 (See 
[https://builds.apache.org/job/HBase-TRUNK/6693/])
HBASE-13864 HColumnDescriptor should parse the output from master and from 
describe for TTL (Ashu Pachauri) (tedyu: rev 
4b6598e394bae67b54d6f741dd262afe03b2c133)
* hbase-client/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* hbase-shell/src/main/ruby/hbase/admin.rb


> HColumnDescriptor should parse the output from master and from describe for 
> TTL
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Fix For: 2.0.0
>
> Attachments: 13864-branch-1.txt, HBASE-13864-1.patch, 
> HBASE-13864-2.patch, HBASE-13864-3.patch, HBASE-13864-4.patch, 
> HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-11 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582657#comment-14582657
 ] 

Hadoop QA commented on HBASE-13864:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12739122/HBASE-13864.patch
  against master branch at commit 47bd7de6d87f35b2c07ca83be209f73ae2b41c27.
  ATTACHMENT ID: 12739122

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
1916 checkstyle errors (more than the master's current 1912 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14381//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14381//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14381//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14381//console

This message is automatically generated.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-12 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584173#comment-14584173
 ] 

Ted Yu commented on HBASE-13864:


{code}
145 String regex = 
"((\\d+)\\s*DAYS?)?\\s*((\\d+)\\s*HOURS?)?\\s*((\\d+)\\s*MINUTES?)?" +
146 "\\s*((\\d+)\\s*SECONDS?)?";
147 Pattern pattern = Pattern.compile(regex, Pattern.CASE_INSENSITIVE);
{code}
The above variables can be lifted outside the method and made static, right ?

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-12 Thread Ashu Pachauri (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584252#comment-14584252
 ] 

Ashu Pachauri commented on HBASE-13864:
---

Yes, they can be. I will put another patch.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-12 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584403#comment-14584403
 ] 

Hadoop QA commented on HBASE-13864:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12739372/HBASE-13864-1.patch
  against master branch at commit 47a9ff5d1f4f90fe9ddc05a478cca0d4f82fd30a.
  ATTACHMENT ID: 12739372

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
1916 checkstyle errors (more than the master's current 1912 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14390//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14390//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14390//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14390//console

This message is automatically generated.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-12 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584408#comment-14584408
 ] 

Ted Yu commented on HBASE-13864:


The new checkstyle warnings probably were from:
{code}
151 if(matcher.matches()) {
{code}
There should be a space between if and '('

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-12 Thread Ashu Pachauri (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584415#comment-14584415
 ] 

Ashu Pachauri commented on HBASE-13864:
---

No, it's because of the old code. New checkstyle warnings are because of this 
inner assignment:
{code}
days = hours = minutes = seconds = null;
{code}

and the empty catch block. The new patch will fix these problems.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-12 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584464#comment-14584464
 ] 

Hadoop QA commented on HBASE-13864:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12739393/HBASE-13864-2.patch
  against master branch at commit 293506c7cdef3e866c75a7b92558a423eb804d11.
  ATTACHMENT ID: 12739393

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14394//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14394//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14394//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14394//console

This message is automatically generated.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864-2.patch, 
> HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-17 Thread Elliott Clark (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590846#comment-14590846
 ] 

Elliott Clark commented on HBASE-13864:
---

Can you add a test that shows it parsing an example ttl? Something like: TTL => 
'1296000 SECONDS (15 DAYS)'

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864-2.patch, 
> HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-24 Thread Elliott Clark (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599814#comment-14599814
 ] 

Elliott Clark commented on HBASE-13864:
---

Looks good to me. Let me kick the hadoop qa and we can get this in.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864-2.patch, 
> HBASE-13864-3.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600037#comment-14600037
 ] 

Hadoop QA commented on HBASE-13864:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12740267/HBASE-13864-3.patch
  against master branch at commit 578adca6ee961f558cd2b2246156f9822cf4f7a2.
  ATTACHMENT ID: 12740267

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

 {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14551//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14551//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14551//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14551//console

This message is automatically generated.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864-2.patch, 
> HBASE-13864-3.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600086#comment-14600086
 ] 

Hadoop QA commented on HBASE-13864:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12740267/HBASE-13864-3.patch
  against master branch at commit 578adca6ee961f558cd2b2246156f9822cf4f7a2.
  ATTACHMENT ID: 12740267

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
  org.apache.hadoop.hbase.TestRegionRebalancing
  org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):   
at 
org.apache.phoenix.mapreduce.IndexToolIT.testSecondaryIndex(IndexToolIT.java:131)
at 
org.apache.phoenix.mapreduce.IndexToolIT.testMutableLocalIndex(IndexToolIT.java:89)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14550//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14550//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14550//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14550//console

This message is automatically generated.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864-2.patch, 
> HBASE-13864-3.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-06-25 Thread Ashu Pachauri (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601739#comment-14601739
 ] 

Ashu Pachauri commented on HBASE-13864:
---

The test failures don't seem related to the change.

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864-2.patch, 
> HBASE-13864-3.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13864) HColumnDescriptor should parse the output from master and from describe for ttl

2015-07-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617308#comment-14617308
 ] 

Ted Yu commented on HBASE-13864:


lgtm
nit:
Please leave one space between 'if' and '('
This is one of the places:
{code}
174 if(expectedTtl != null && Long.parseLong(expectedTtl) != 
ttl) {
{code}

> HColumnDescriptor should parse the output from master and from describe for 
> ttl
> ---
>
> Key: HBASE-13864
> URL: https://issues.apache.org/jira/browse/HBASE-13864
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Elliott Clark
>Assignee: Ashu Pachauri
> Attachments: HBASE-13864-1.patch, HBASE-13864-2.patch, 
> HBASE-13864-3.patch, HBASE-13864.patch
>
>
> The TTL printing on HColumnDescriptor adds a human readable time. When using 
> that string for the create command it throws an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)