[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[ https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475750#comment-15475750 ] Sean Busbey commented on HBASE-13879: - if you're still interested in this [~gliptak], we're trying to avoid any additions to the Public/Stable HConstants. You could move everything to CompactionConfiguration and leave deprecated versions in HConstants. > Add hbase.hstore.compactionThreshold to HConstants > -- > > Key: HBASE-13879 > URL: https://issues.apache.org/jira/browse/HBASE-13879 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Assignee: Gabor Liptak >Priority: Minor > Attachments: HBASE-13879.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[
https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475749#comment-15475749
]
Hadoop QA commented on HBASE-13879:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s {color}
| {color:red} HBASE-13879 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12739145/HBASE-13879.1.patch |
| JIRA Issue | HBASE-13879 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3480/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Add hbase.hstore.compactionThreshold to HConstants
> --
>
> Key: HBASE-13879
> URL: https://issues.apache.org/jira/browse/HBASE-13879
> Project: HBase
> Issue Type: Improvement
>Reporter: Gabor Liptak
>Assignee: Gabor Liptak
>Priority: Minor
> Attachments: HBASE-13879.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[ https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615765#comment-14615765 ] Gabor Liptak commented on HBASE-13879: -- The reason why I proposed this change is that there is a number of references by hardcoded Strings to these compaction keys and hardcoded values (instead of a static finals). The values were incomplete in CompactionConfiguration.java, that is why is moved them over to HConstants.java. Would you be interested in a patch moving all related keys over into CompactionConfiguration.java? Thanks > Add hbase.hstore.compactionThreshold to HConstants > -- > > Key: HBASE-13879 > URL: https://issues.apache.org/jira/browse/HBASE-13879 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Priority: Minor > Attachments: HBASE-13879.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[ https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615444#comment-14615444 ] Anoop Sam John commented on HBASE-13879: CompactionConfiguration.java seems the best place for this config constant no? Why we need change? I would say better dont go with this jira > Add hbase.hstore.compactionThreshold to HConstants > -- > > Key: HBASE-13879 > URL: https://issues.apache.org/jira/browse/HBASE-13879 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Priority: Minor > Attachments: HBASE-13879.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[ https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614024#comment-14614024 ] Gabor Liptak commented on HBASE-13879: -- [~anoop.hbase] Would some other changes needed before this can be considered for commit? Thanks > Add hbase.hstore.compactionThreshold to HConstants > -- > > Key: HBASE-13879 > URL: https://issues.apache.org/jira/browse/HBASE-13879 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Priority: Minor > Attachments: HBASE-13879.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[ https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589169#comment-14589169 ] Gabor Liptak commented on HBASE-13879: -- [~anoop.hbase] Please review. Thanks > Add hbase.hstore.compactionThreshold to HConstants > -- > > Key: HBASE-13879 > URL: https://issues.apache.org/jira/browse/HBASE-13879 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Priority: Minor > Attachments: HBASE-13879.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[
https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582860#comment-14582860
]
Hadoop QA commented on HBASE-13879:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12739145/HBASE-13879.1.patch
against master branch at commit 9d3422ed16004da1b0f9a874a98bd140b46b7a6f.
ATTACHMENT ID: 12739145
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 127
new or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14382//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14382//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14382//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14382//console
This message is automatically generated.
> Add hbase.hstore.compactionThreshold to HConstants
> --
>
> Key: HBASE-13879
> URL: https://issues.apache.org/jira/browse/HBASE-13879
> Project: HBase
> Issue Type: Improvement
>Reporter: Gabor Liptak
>Priority: Minor
> Attachments: HBASE-13879.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[ https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581441#comment-14581441 ] Anoop Sam John commented on HBASE-13879: We add these constants to HConstants if the are referred at multiple places in code. It will be better to use the new conf in tests also BTW. > Add hbase.hstore.compactionThreshold to HConstants > -- > > Key: HBASE-13879 > URL: https://issues.apache.org/jira/browse/HBASE-13879 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[ https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581143#comment-14581143 ] Gabor Liptak commented on HBASE-13879: -- hbase-default.xml doesn't "tag "hbase.hstore.compactionThreshold as deprecated (although hbase.hstore.compaction.min specifies it being the new key) There are a number of tests referencing hbase.hstore.compactionThreshold. Are those to be replaced with hbase.hstore.compaction.min? Also there is no "define" in HConstants for hbase.hstore.compaction.min or the default value 3. Should that be added and referenced across the codebase? > Add hbase.hstore.compactionThreshold to HConstants > -- > > Key: HBASE-13879 > URL: https://issues.apache.org/jira/browse/HBASE-13879 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13879) Add hbase.hstore.compactionThreshold to HConstants
[ https://issues.apache.org/jira/browse/HBASE-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580078#comment-14580078 ] Anoop Sam John commented on HBASE-13879: This is a deprecated config and the new one was/is 'hbase.hstore.compaction.min'. Why you say add this particular config to HConstants? > Add hbase.hstore.compactionThreshold to HConstants > -- > > Key: HBASE-13879 > URL: https://issues.apache.org/jira/browse/HBASE-13879 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
