[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704093#comment-14704093
]
Hudson commented on HBASE-13917:
FAILURE: Integrated in HBase-1.0 #1021 (See
[https://builds.apache.org/job/HBase-1.0/1021/])
HBASE-13941 Backport HBASE-13917 (Remove string comparison to identify request
priority) (apurtell: rev 585cd22c90e3f56ab1441305cd4aee2827adb177)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704104#comment-14704104
]
Hudson commented on HBASE-13917:
FAILURE: Integrated in HBase-1.1 #624 (See
[https://builds.apache.org/job/HBase-1.1/624/])
HBASE-13941 Backport HBASE-13917 (Remove string comparison to identify request
priority) (apurtell: rev 6062dc618c4d5ad69bb91fb236942484833096ee)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611430#comment-14611430
]
Hudson commented on HBASE-13917:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #998 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/998/])
HBASE-13994 Backport HBASE-13917 (Remove string comparison to identify request
priority) to 0.98 (apurtell: rev f04a68f73fc7a7b08091dbac199ace2ed3c7e0a6)
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611295#comment-14611295
]
Hudson commented on HBASE-13917:
FAILURE: Integrated in HBase-0.98 #1045 (See
[https://builds.apache.org/job/HBase-0.98/1045/])
HBASE-13994 Backport HBASE-13917 (Remove string comparison to identify request
priority) to 0.98 (apurtell: rev f04a68f73fc7a7b08091dbac199ace2ed3c7e0a6)
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593923#comment-14593923
]
Andrew Purtell commented on HBASE-13917:
bq. let's wait a couple of weeks before backporting it on all the other
branches. I may have other changes around this stuff.
Ok, I opened HBASE-13941 for that
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592472#comment-14592472
]
Hudson commented on HBASE-13917:
FAILURE: Integrated in HBase-TRUNK #6583 (See
[https://builds.apache.org/job/HBase-TRUNK/6583/])
HBASE-13917 Remove string comparison to identify request priority
(matteo.bertozzi: rev fedfe878f40ad965c7eee5ea9e0960b88ea54cfa)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592712#comment-14592712
]
Hudson commented on HBASE-13917:
FAILURE: Integrated in HBase-1.3 #7 (See
[https://builds.apache.org/job/HBase-1.3/7/])
HBASE-13917 Remove string comparison to identify request priority
(matteo.bertozzi: rev d628f95307a97ac82264e72a9dae2f3d4013da52)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592713#comment-14592713
]
Hudson commented on HBASE-13917:
FAILURE: Integrated in HBase-1.2 #20 (See
[https://builds.apache.org/job/HBase-1.2/20/])
HBASE-13917 Remove string comparison to identify request priority
(matteo.bertozzi: rev ef022453f29c525e144d15202992cbf36363b589)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588567#comment-14588567
]
Andrew Purtell commented on HBASE-13917:
This looks like an improvement we can make everywhere.
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588419#comment-14588419
]
stack commented on HBASE-13917:
---
LGTM
Does it work?
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588462#comment-14588462
]
Anoop Sam John commented on HBASE-13917:
+1.
{code}
private boolean isWriteRequest(final RequestHeader header, final Message
param) {
// TODO: Is there a better way to do this?
String methodName = header.getMethodName();
if (methodName.equalsIgnoreCase(multi) param instanceof MultiRequest) {
MultiRequest multi = (MultiRequest)param;
for (RegionAction regionAction : multi.getRegionActionList()) {
for (Action action: regionAction.getActionList()) {
if (action.hasMutation()) {
return true;
}
}
}
}
{code}
We will need a better way for handling it like marking the request comes from
client as write and/or read. But not for this Jira any way.
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13917) Remove string comparison to identify request priority
[
https://issues.apache.org/jira/browse/HBASE-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588709#comment-14588709
]
Hadoop QA commented on HBASE-13917:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12739917/HBASE-13917-v0.patch
against master branch at commit a10a82a8ff2babefbfafe7c323d88eb85f2be52c.
ATTACHMENT ID: 12739917
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestRegionRebalancing
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14437//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14437//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14437//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14437//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14437//console
This message is automatically generated.
Remove string comparison to identify request priority
-
Key: HBASE-13917
URL: https://issues.apache.org/jira/browse/HBASE-13917
Project: HBase
Issue Type: Improvement
Components: regionserver
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.2.0
Attachments: HBASE-13917-v0.patch
We have a couple of if (methodName.equalsIgnoreCase(scan)) { ScanRequest
req = (ScanRequest)parm; } we can replace that string comparison with an
instanceof
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
