[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[ https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693078#comment-14693078 ] Hudson commented on HBASE-14188: FAILURE: Integrated in HBase-TRUNK #6717 (See [https://builds.apache.org/job/HBase-TRUNK/6717/]) HBASE-14188- Read path optimizations after HBASE-11425 profiling- (ramkrishna: rev aa3538f80278f5c0ba1bc8ca903066fa02ac79ec) * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/FilterAllFilter.java Read path optimizations after HBASE-11425 profiling --- Key: HBASE-14188 URL: https://issues.apache.org/jira/browse/HBASE-14188 Project: HBase Issue Type: Sub-task Components: Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14188.patch, HBASE-14188_1.patch, HBASE-14188_2.patch, HBASE-14188_addendum.patch, setSeqId.png This subtask deals with some improvments that can be done in the read path (scans) after the changes for HBASE-11425 went in. - Avoid CellUtil.setSequenceId in hot path. - Use BBUtils in the MultibyteBuff. - Use ByteBuff.skip() API in HFileReader rather than MultiByteBuff.position(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[ https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692889#comment-14692889 ] ramkrishna.s.vasudevan commented on HBASE-14188: Pushed the addendum. Read path optimizations after HBASE-11425 profiling --- Key: HBASE-14188 URL: https://issues.apache.org/jira/browse/HBASE-14188 Project: HBase Issue Type: Sub-task Components: Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14188.patch, HBASE-14188_1.patch, HBASE-14188_2.patch, HBASE-14188_addendum.patch, setSeqId.png This subtask deals with some improvments that can be done in the read path (scans) after the changes for HBASE-11425 went in. - Avoid CellUtil.setSequenceId in hot path. - Use BBUtils in the MultibyteBuff. - Use ByteBuff.skip() API in HFileReader rather than MultiByteBuff.position(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[
https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692883#comment-14692883
]
Anoop Sam John commented on HBASE-14188:
FilterAllFilter
{code}
@Override
46public boolean filterRowKey(Cell cell) throws IOException {
47 return true;
48}
{code}
This has to return false as in old case. We override this method as the old
deprecated one might cause a row array copy in case of Offheap backed cells.
Mind commit an addendum?
Read path optimizations after HBASE-11425 profiling
---
Key: HBASE-14188
URL: https://issues.apache.org/jira/browse/HBASE-14188
Project: HBase
Issue Type: Sub-task
Components: Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14188.patch, HBASE-14188_1.patch,
HBASE-14188_2.patch, setSeqId.png
This subtask deals with some improvments that can be done in the read path
(scans) after the changes for HBASE-11425 went in.
- Avoid CellUtil.setSequenceId in hot path.
- Use BBUtils in the MultibyteBuff.
- Use ByteBuff.skip() API in HFileReader rather than
MultiByteBuff.position().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[
https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659809#comment-14659809
]
Hadoop QA commented on HBASE-14188:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749004/HBASE-14188_1.patch
against master branch at commit 5d2708f628d4718f6267e9da6c8cbafeda66f4fb.
ATTACHMENT ID: 12749004
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14989//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14989//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14989//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14989//console
This message is automatically generated.
Read path optimizations after HBASE-11425 profiling
---
Key: HBASE-14188
URL: https://issues.apache.org/jira/browse/HBASE-14188
Project: HBase
Issue Type: Sub-task
Components: Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Attachments: HBASE-14188.patch, HBASE-14188_1.patch, setSeqId.png
This subtask deals with some improvments that can be done in the read path
(scans) after the changes for HBASE-11425 went in.
- Avoid CellUtil.setSequenceId in hot path.
- Use BBUtils in the MultibyteBuff.
- Use ByteBuff.skip() API in HFileReader rather than
MultiByteBuff.position().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[
https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659588#comment-14659588
]
ramkrishna.s.vasudevan commented on HBASE-14188:
The test failure is due to
{code}
java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:713)
at
org.apache.hadoop.hbase.MultithreadedTestUtil$TestContext.startThreads(MultithreadedTestUtil.java:61)
at
org.apache.hadoop.hbase.io.hfile.CacheTestUtils.hammerSingleKey(CacheTestUtils.java:200)
at
org.apache.hadoop.hbase.io.hfile.bucket.TestBucketCache.testCacheMultiThreadedSingleKey(TestBucketCache.java:177)
{code}
Seem unrelated. It is passing locally.
bq.getNextCellStartPosition - Now it is not returning the next cell's start
pos. It is returning cur cell serialization size in the HFile.. Pls change the
method name accordingly. Can fix on commit.
Changed this to getCurCellSize().
Read path optimizations after HBASE-11425 profiling
---
Key: HBASE-14188
URL: https://issues.apache.org/jira/browse/HBASE-14188
Project: HBase
Issue Type: Sub-task
Components: Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Attachments: HBASE-14188.patch, setSeqId.png
This subtask deals with some improvments that can be done in the read path
(scans) after the changes for HBASE-11425 went in.
- Avoid CellUtil.setSequenceId in hot path.
- Use BBUtils in the MultibyteBuff.
- Use ByteBuff.skip() API in HFileReader rather than
MultiByteBuff.position().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[
https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659579#comment-14659579
]
Hadoop QA commented on HBASE-14188:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12748997/HBASE-14188.patch
against master branch at commit 5d2708f628d4718f6267e9da6c8cbafeda66f4fb.
ATTACHMENT ID: 12748997
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.bucket.TestBucketCache
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14988//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14988//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14988//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14988//console
This message is automatically generated.
Read path optimizations after HBASE-11425 profiling
---
Key: HBASE-14188
URL: https://issues.apache.org/jira/browse/HBASE-14188
Project: HBase
Issue Type: Sub-task
Components: Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Attachments: HBASE-14188.patch, setSeqId.png
This subtask deals with some improvments that can be done in the read path
(scans) after the changes for HBASE-11425 went in.
- Avoid CellUtil.setSequenceId in hot path.
- Use BBUtils in the MultibyteBuff.
- Use ByteBuff.skip() API in HFileReader rather than
MultiByteBuff.position().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[ https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659921#comment-14659921 ] Lars Hofhansl commented on HBASE-14188: --- Postmortem +1 :) Read path optimizations after HBASE-11425 profiling --- Key: HBASE-14188 URL: https://issues.apache.org/jira/browse/HBASE-14188 Project: HBase Issue Type: Sub-task Components: Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14188.patch, HBASE-14188_1.patch, HBASE-14188_2.patch, setSeqId.png This subtask deals with some improvments that can be done in the read path (scans) after the changes for HBASE-11425 went in. - Avoid CellUtil.setSequenceId in hot path. - Use BBUtils in the MultibyteBuff. - Use ByteBuff.skip() API in HFileReader rather than MultiByteBuff.position(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[ https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660143#comment-14660143 ] Hudson commented on HBASE-14188: FAILURE: Integrated in HBase-TRUNK #6701 (See [https://builds.apache.org/job/HBase-TRUNK/6701/]) HBASE-14188 - Read path optimizations after HBASE-11425 profiling (Ram) (ramkrishna: rev 7a9e10dc11877420c53245c403897d746bebc077) * hbase-common/src/main/java/org/apache/hadoop/hbase/OffheapKeyValue.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java * hbase-common/src/test/java/org/apache/hadoop/hbase/TestOffheapKeyValue.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/FilterAllFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/SizeCachedNoTagsKeyValue.java * hbase-server/src/main/java/org/apache/hadoop/hbase/SizeCachedKeyValue.java * hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java Read path optimizations after HBASE-11425 profiling --- Key: HBASE-14188 URL: https://issues.apache.org/jira/browse/HBASE-14188 Project: HBase Issue Type: Sub-task Components: Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Attachments: HBASE-14188.patch, HBASE-14188_1.patch, HBASE-14188_2.patch, setSeqId.png This subtask deals with some improvments that can be done in the read path (scans) after the changes for HBASE-11425 went in. - Avoid CellUtil.setSequenceId in hot path. - Use BBUtils in the MultibyteBuff. - Use ByteBuff.skip() API in HFileReader rather than MultiByteBuff.position(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14188) Read path optimizations after HBASE-11425 profiling
[ https://issues.apache.org/jira/browse/HBASE-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659535#comment-14659535 ] Anoop Sam John commented on HBASE-14188: Patch LGTM getNextCellStartPosition - Now it is not returning the next cell's start pos. It is returning cur cell serialization size in the HFile.. Pls change the method name accordingly. Can fix on commit. Read path optimizations after HBASE-11425 profiling --- Key: HBASE-14188 URL: https://issues.apache.org/jira/browse/HBASE-14188 Project: HBase Issue Type: Sub-task Components: Scanners Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Attachments: HBASE-14188.patch, setSeqId.png This subtask deals with some improvments that can be done in the read path (scans) after the changes for HBASE-11425 went in. - Avoid CellUtil.setSequenceId in hot path. - Use BBUtils in the MultibyteBuff. - Use ByteBuff.skip() API in HFileReader rather than MultiByteBuff.position(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
