[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694820#comment-14694820
]
Hadoop QA commented on HBASE-14214:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12750068/HBASE-14214.patch
against master branch at commit a399ac9c4f76dccebb3476c418aac68667dee545.
ATTACHMENT ID: 12750068
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15081//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15081//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15081//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15081//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15081//console
This message is automatically generated.
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Priority: Minor
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694919#comment-14694919
]
Anoop Sam John commented on HBASE-14214:
No tests failed. TestShell passed locally. Will commit shortly.
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Priority: Minor
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695223#comment-14695223
]
Hudson commented on HBASE-14214:
FAILURE: Integrated in HBase-TRUNK #6725 (See
[https://builds.apache.org/job/HBase-TRUNK/6725/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(anoopsamjohn: rev 9c69bf766fcad024bef5760f242cae2bc609b374)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695225#comment-14695225
]
Hudson commented on HBASE-14214:
FAILURE: Integrated in HBase-1.3 #107 (See
[https://builds.apache.org/job/HBase-1.3/107/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(anoopsamjohn: rev 22f466696a1ee6222bced3003f0838e7e2f7640d)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696057#comment-14696057
]
Hudson commented on HBASE-14214:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1034 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1034/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(apurtell: rev 8b9ed1c2358926d4b9abe6d627137eb497e7825b)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696018#comment-14696018
]
Hudson commented on HBASE-14214:
SUCCESS: Integrated in HBase-0.98 #1081 (See
[https://builds.apache.org/job/HBase-0.98/1081/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(apurtell: rev 8b9ed1c2358926d4b9abe6d627137eb497e7825b)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696063#comment-14696063
]
Hudson commented on HBASE-14214:
SUCCESS: Integrated in HBase-1.2-IT #90 (See
[https://builds.apache.org/job/HBase-1.2-IT/90/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(apurtell: rev c0a3a8a193ab45c2b6cc8f56d8207e78735f5a17)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695797#comment-14695797
]
Hudson commented on HBASE-14214:
FAILURE: Integrated in HBase-1.0 #1015 (See
[https://builds.apache.org/job/HBase-1.0/1015/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(apurtell: rev be5a8c51df33805572463ae43825af702037eed5)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.3.0, 1.1.3
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695946#comment-14695946
]
Hudson commented on HBASE-14214:
FAILURE: Integrated in HBase-1.1 #614 (See
[https://builds.apache.org/job/HBase-1.1/614/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(apurtell: rev 67e67b4552ae2d406bc3ad755caad75f592b199b)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695936#comment-14695936
]
Hudson commented on HBASE-14214:
FAILURE: Integrated in HBase-1.2 #108 (See
[https://builds.apache.org/job/HBase-1.2/108/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(apurtell: rev c0a3a8a193ab45c2b6cc8f56d8207e78735f5a17)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695428#comment-14695428
]
Hudson commented on HBASE-14214:
SUCCESS: Integrated in HBase-1.3-IT #89 (See
[https://builds.apache.org/job/HBase-1.3-IT/89/])
HBASE-14214 list_labels shouldn't raise ArgumentError if no labels are defined.
(anoopsamjohn: rev 22f466696a1ee6222bced3003f0838e7e2f7640d)
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Anoop Sam John
Priority: Minor
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693809#comment-14693809
]
Andrew Purtell commented on HBASE-14214:
+1, yes it will Anoop :-)
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Priority: Minor
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14214.patch
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14214) list_labels shouldn't raise ArgumentError if no labels are defined
[
https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693365#comment-14693365
]
Anoop Sam John commented on HBASE-14214:
We can avoid this
{code}
if response.getLabelList.empty?
raise(ArgumentError, No auth label defined)
end
{code}
similar way for get_auths also.
list_labels shouldn't raise ArgumentError if no labels are defined
---
Key: HBASE-14214
URL: https://issues.apache.org/jira/browse/HBASE-14214
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Priority: Minor
Fix For: 2.0.0, 1.3.0
list_labels shouldn't raise ArgumentError if no labels are defined. The empty
list is a valid return case, and anyway ArgumentError should be used when
arguments to the command are erroneous. Here the command is well formed:
{noformat}
hbase(main):001:0 list_labels
ERROR: No auth label defined
Here is some help for this command:
List the visibility labels defined in the system.
Optional regular expression parameter could be used to filter the labels
being returned.
Syntax : list_labels
For example:
hbase list_labels 'secret.*'
hbase list_labels
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
