[jira] [Commented] (HBASE-14628) Save object creation for scanning with block encodings
[ https://issues.apache.org/jira/browse/HBASE-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962692#comment-14962692 ] Lars Hofhansl commented on HBASE-14628: --- Thanks will commit later tonight. > Save object creation for scanning with block encodings > -- > > Key: HBASE-14628 > URL: https://issues.apache.org/jira/browse/HBASE-14628 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Attachments: 14628-0.98.txt > > > I noticed that (at least in 0.98 - master is entirely different) we create > ByteBuffer just to create a byte[], which is then used to create a KeyValue. > We can save the creation of the ByteBuffer and hence save allocating an extra > object for each KV we find by creating the byte[] directly. > In a Phoenix count\(*) query that saved from 10% of runtime. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14628) Save object creation for scanning with block encodings
[ https://issues.apache.org/jira/browse/HBASE-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962645#comment-14962645 ] Andrew Purtell commented on HBASE-14628: +1 I'll take a 5% improvement in 0.98 > Save object creation for scanning with block encodings > -- > > Key: HBASE-14628 > URL: https://issues.apache.org/jira/browse/HBASE-14628 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Attachments: 14628-0.98.txt > > > I noticed that (at least in 0.98 - master is entirely different) we create > ByteBuffer just to create a byte[], which is then used to create a KeyValue. > We can save the creation of the ByteBuffer and hence save allocating an extra > object for each KV we find by creating the byte[] directly. > In a Phoenix count\(*) query that saved from 10% of runtime. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14628) Save object creation for scanning with block encodings
[ https://issues.apache.org/jira/browse/HBASE-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962818#comment-14962818 ] ramkrishna.s.vasudevan commented on HBASE-14628: +1 on the change. > Save object creation for scanning with block encodings > -- > > Key: HBASE-14628 > URL: https://issues.apache.org/jira/browse/HBASE-14628 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Attachments: 14628-0.98.txt > > > I noticed that (at least in 0.98 - master is entirely different) we create > ByteBuffer just to create a byte[], which is then used to create a KeyValue. > We can save the creation of the ByteBuffer and hence save allocating an extra > object for each KV we find by creating the byte[] directly. > In a Phoenix count\(*) query that saved from 10% of runtime. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14628) Save object creation for scanning with block encodings
[ https://issues.apache.org/jira/browse/HBASE-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962817#comment-14962817 ] Anoop Sam John commented on HBASE-14628: +1 > Save object creation for scanning with block encodings > -- > > Key: HBASE-14628 > URL: https://issues.apache.org/jira/browse/HBASE-14628 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Attachments: 14628-0.98.txt > > > I noticed that (at least in 0.98 - master is entirely different) we create > ByteBuffer just to create a byte[], which is then used to create a KeyValue. > We can save the creation of the ByteBuffer and hence save allocating an extra > object for each KV we find by creating the byte[] directly. > In a Phoenix count\(*) query that saved from 10% of runtime. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14628) Save object creation for scanning with block encodings
[ https://issues.apache.org/jira/browse/HBASE-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962162#comment-14962162 ] Lars Hofhansl commented on HBASE-14628: --- Yep, only useful in 0.98. Worth committing? 1.0 and later do a shallow copy of the seeker state... I could try to backport that, but 0.98 might not be ready for this in other aspects. > Save object creation for scanning with block encodings > -- > > Key: HBASE-14628 > URL: https://issues.apache.org/jira/browse/HBASE-14628 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Attachments: 14628-0.98.txt > > > I noticed that (at least in 0.98 - master is entirely different) we create > ByteBuffer just to create a byte[], which is then used to create a KeyValue. > We can save the creation of the ByteBuffer and hence save allocating an extra > object for each KV we find by creating the byte[] directly. > In a Phoenix count\(*) query that saved from 10% of runtime. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14628) Save object creation for scanning with block encodings
[ https://issues.apache.org/jira/browse/HBASE-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961763#comment-14961763 ] ramkrishna.s.vasudevan commented on HBASE-14628: I think that BB creation can be avoided here in case of 0.98 because anyway all are going to be byte[] and so from the KVBuffer we can direclty copy to the new byte[] that we create for forming the individual KVs. > Save object creation for scanning with block encodings > -- > > Key: HBASE-14628 > URL: https://issues.apache.org/jira/browse/HBASE-14628 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Attachments: 14628-0.98.txt > > > I noticed that (at least in 0.98 - master is entirely different) we create > ByteBuffer just to create a byte[], which is then used to create a KeyValue. > We can save the creation of the ByteBuffer and hence save allocating an extra > object for each KV we find by creating the byte[] directly. > In a Phoenix count\(*) query that saved from 10% of runtime. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
