[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Nick Dimiduk (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045731#comment-15045731
 ] 

Nick Dimiduk commented on HBASE-14655:
--

[~apurtell] That's fine as well, so long as there's a place to track this issue 
blocking the release.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Blocker
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044245#comment-15044245
 ] 

Andrew Purtell commented on HBASE-14655:


Rather than reopen this how about a new JIRA to look at what more can be done 
in 1.1 and 1.0 to avoid interface changes? 

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Blocker
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977594#comment-14977594
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-1.3 #315 (See 
[https://builds.apache.org/job/HBase-1.3/315/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
f6a30d2331f45e0fb8e13398bd56d0b9f71ed6ea)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977543#comment-14977543
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1123 (See 
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1123/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
fc0aa1e7b2612f3045138e11bdef506638842bfb)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977472#comment-14977472
 ] 

Hudson commented on HBASE-14655:


SUCCESS: Integrated in HBase-1.3-IT #276 (See 
[https://builds.apache.org/job/HBase-1.3-IT/276/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
f6a30d2331f45e0fb8e13398bd56d0b9f71ed6ea)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977449#comment-14977449
 ] 

Hudson commented on HBASE-14655:


SUCCESS: Integrated in HBase-1.2-IT #246 (See 
[https://builds.apache.org/job/HBase-1.2-IT/246/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
10239fca617107a1a01301bb77bba9b98fb684a8)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977437#comment-14977437
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-0.98 #1169 (See 
[https://builds.apache.org/job/HBase-0.98/1169/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
fc0aa1e7b2612f3045138e11bdef506638842bfb)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977330#comment-14977330
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-1.2 #313 (See 
[https://builds.apache.org/job/HBase-1.2/313/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
10239fca617107a1a01301bb77bba9b98fb684a8)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977243#comment-14977243
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-1.1 #726 (See 
[https://builds.apache.org/job/HBase-1.1/726/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
b0ef01435169c3d3650d60e9ef1c7064fa1bff18)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977180#comment-14977180
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-1.0 #1102 (See 
[https://builds.apache.org/job/HBase-1.0/1102/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
10d86f21227fadc94b331640edaad7d67d7f8b97)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977081#comment-14977081
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-TRUNK #6968 (See 
[https://builds.apache.org/job/HBase-TRUNK/6968/])
HBASE-14655 Addendum passes User to store#compact() (tedyu: rev 
e04e7402cd5df5fc7001101ad50fc2dbf8de5c1e)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976888#comment-14976888
 ] 

Ted Yu commented on HBASE-14655:


Thanks Jerry.
Integrated addendum to all branches.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Jerry He (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976789#comment-14976789
 ] 

Jerry He commented on HBASE-14655:
--

Hmm, that is exactly in the code path.
Addendum looks good.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-addendum.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Jerry He (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972400#comment-14972400
 ] 

Jerry He commented on HBASE-14655:
--

Okay. [~apurtell]. I will think about it. Thanks for chiming in.
Thanks [~yuzhih...@gmail.com] for your persistence on the JIRAs.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972357#comment-14972357
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-1.3 #298 (See 
[https://builds.apache.org/job/HBase-1.3/298/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
bc990a332885b1fd07dc6d1b22624380378609a0)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972293#comment-14972293
 ] 

Hudson commented on HBASE-14655:


SUCCESS: Integrated in HBase-1.3-IT #266 (See 
[https://builds.apache.org/job/HBase-1.3-IT/266/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
bc990a332885b1fd07dc6d1b22624380378609a0)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972275#comment-14972275
 ] 

Hudson commented on HBASE-14655:


SUCCESS: Integrated in HBase-1.2-IT #238 (See 
[https://builds.apache.org/job/HBase-1.2-IT/238/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
aa95519a9c01267bc5bb147220010c508133459e)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972267#comment-14972267
 ] 

Hudson commented on HBASE-14655:


SUCCESS: Integrated in HBase-1.2 #297 (See 
[https://builds.apache.org/job/HBase-1.2/297/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
aa95519a9c01267bc5bb147220010c508133459e)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972264#comment-14972264
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-TRUNK #6948 (See 
[https://builds.apache.org/job/HBase-TRUNK/6948/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
8b7796b0b661ca960463c9e16034ee8f64494dbd)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972257#comment-14972257
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-0.98 #1166 (See 
[https://builds.apache.org/job/HBase-0.98/1166/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
73e7722b808a79c93882cbe1a2d14dfa3cef8b58)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972231#comment-14972231
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-1.1 #721 (See 
[https://builds.apache.org/job/HBase-1.1/721/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
b19daf4c56d32302c6b9671286fc64a47e5bbb42)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972216#comment-14972216
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-1.0 #1097 (See 
[https://builds.apache.org/job/HBase-1.0/1097/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
c39d066fcdc10044925bb722b5e4f422264aa903)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972087#comment-14972087
 ] 

Hudson commented on HBASE-14655:


FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1119 (See 
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1119/])
HBASE-14655 Narrow the scope of doAs() calls to region observer (tedyu: rev 
73e7722b808a79c93882cbe1a2d14dfa3cef8b58)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreEngine.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971876#comment-14971876
 ] 

Andrew Purtell commented on HBASE-14655:


bq. The purpose of the original JIRA is to be able to ACL check and audit the 
'request' user before perform the user compaction request. The AccessController 
only implemented preCommit(), with no checking or auditing for the other preXXX 
(e.g preCompactSelection, preCompactScannerOpen) or postXXX.

postXXX is not where authoritative decisions would be made, so we don't need to 
worry about which user is running the code at that step. 

We will have coprocessors on preXXX hooks expecting to make authoritative 
decisions will all information available to them including the request user. 
This used to be easier to reason about back in the 0.94 days. Today the 
assumptions the AccessController makes that upcalls are all executing in the 
context of the request user are not always valid.

Going forward we can use doAs to set up the user context for upcalls for 
coprocessors that care (AccessController), or we can modify those coprocessors 
to get the request user using a relevant API, adding such API if missing. 
Either approach works. I do agree we should make a comprehensive effort. Both 
this and HBASE-14631 are fine on their own. I'm going to make an umbrella and 
reparent this and HBASE-14631 to it as subtasks. We can add more tasks as 
needed. Since you brought this up [~jerryhe] would you like to do the honors? 

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971874#comment-14971874
 ] 

Ted Yu commented on HBASE-14655:


[~apurtell]:
Do you have specific comment on patch v9 ?

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971861#comment-14971861
 ] 

Andrew Purtell commented on HBASE-14655:


bq. Auditing, on the other hand, can be done by downstream project(s) such as 
Apache Ranger.

No, auditing is totally within the scope of the HBase project, not something we 
should delegate to an unrelated Apache project.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971778#comment-14971778
 ] 

stack commented on HBASE-14655:
---

[~apurtell] See above [~jerryhe]'s query on a more macro approach... 

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971768#comment-14971768
 ] 

Ted Yu commented on HBASE-14655:


If there is no more comment, I will start integrating over the weekend.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970293#comment-14970293
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12768145/14655-0.98-v9.txt
  against 0.98 branch at commit c21e8ed1d860f3b380b260890d04cd2c492ab0a3.
  ATTACHMENT ID: 12768145

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 15 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
28 warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16183//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16183//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16183//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16183//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16183//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970240#comment-14970240
 ] 

Ted Yu commented on HBASE-14655:


[~stack] [~apurtell]:
Any more comment based on patch v9 ?

Thanks

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: 14655-0.98-v9.txt, 14655-0.98-v9.txt, 
> 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 
> 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969947#comment-14969947
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12768085/14655-0.98-v9.txt
  against 0.98 branch at commit 619a240ebd6305eb2fdca8efe104a9ee92065ff6.
  ATTACHMENT ID: 12768085

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 15 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
27 warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16176//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16176//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16176//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16176//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16176//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 
> 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969862#comment-14969862
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12768098/14655-branch-1.0-v10.txt
  against branch-1.0 branch at commit 619a240ebd6305eb2fdca8efe104a9ee92065ff6.
  ATTACHMENT ID: 12768098

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 18 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16177//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16177//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16177//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16177//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 
> 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969837#comment-14969837
 ] 

Ted Yu commented on HBASE-14655:


In terms of ACL check, existing hooks used by AccessController should suffice - 
as shown by various security tests.

Auditing, on the other hand, can be done by downstream project(s) such as 
Apache Ranger.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 
> 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Jerry He (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969802#comment-14969802
 ] 

Jerry He commented on HBASE-14655:
--

A general comment here.
The purpose of the original JIRA is to be able to ACL check and audit the 
'request' user before perform the user compaction request.
The AccessController only implemented preCommit(), with no checking or auditing 
for the other preXXX (e.g preCompactSelection, preCompactScannerOpen) or 
postXXX.
I have wondered if it is necessary to enclose all these call in doAs().
Also since it would cover calls to all coprocessor implementations of these 
methods, including user custom coprocessors,  should limited behavior change be 
more desired?
[~apurtell] may have a better idea than mine on this.

Other than this, the v9 patch looks good.


> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 
> 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969699#comment-14969699
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12768069/14655-branch-1.0-v9.txt
  against branch-1.0 branch at commit 619a240ebd6305eb2fdca8efe104a9ee92065ff6.
  ATTACHMENT ID: 12768069

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 18 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
3766 checkstyle errors (more than the master's current 3765 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+byte[] left, byte[] right, byte[] majorRangeFromRow, byte[] 
majorRangeToRow) throws IOException {
+dropDeletesMatcher(dropDeletes, start), 
dropDeletesMatcher(dropDeletes, end), any(User.class));

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16174//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16174//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16174//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16174//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 
> 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Sergey Shelukhin (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969685#comment-14969685
 ] 

Sergey Shelukhin commented on HBASE-14655:
--

+1

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt, 14655-branch-1.0-v6.txt, 
> 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969599#comment-14969599
 ] 

Ted Yu commented on HBASE-14655:


Sergey:
Answered your question on review board.

For extracting into separate method, I tried when I worked on HBASE-14605. Due 
to exception handling code, separate method didn't make the code more readable.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Sergey Shelukhin (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969593#comment-14969593
 ] 

Sergey Shelukhin commented on HBASE-14655:
--

left one comment on RB. One more question - is it possible to move all the if 
(user == null) { blah() } else { cruft cruft cruft blah() cruft cruft } code 
into separate methods like runBlahCpHook(), so that the code is cleaner.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969580#comment-14969580
 ] 

Ted Yu commented on HBASE-14655:


[~jerryhe] [~saint@gmail.com]:
Mind taking another look at patch v9 ?

Thanks

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969578#comment-14969578
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12768058/14655-branch-1.0-v8.txt
  against branch-1.0 branch at commit 2e2cbd0201a34b7a24eb0e4c1621f7d11c2f9c04.
  ATTACHMENT ID: 12768058

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 18 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
3766 checkstyle errors (more than the master's current 3765 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+byte[] left, byte[] right, byte[] majorRangeFromRow, byte[] 
majorRangeToRow) throws IOException {
+dropDeletesMatcher(dropDeletes, start), 
dropDeletesMatcher(dropDeletes, end), any(User.class));

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16173//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16173//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16173//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16173//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 
> 14655-branch-1-v9.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969461#comment-14969461
 ] 

Ted Yu commented on HBASE-14655:


https://reviews.apache.org/r/39557/

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Sergey Shelukhin (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969444#comment-14969444
 ] 

Sergey Shelukhin commented on HBASE-14655:
--

Can you post an RB?

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 
> 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 
> 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt, 
> 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969369#comment-14969369
 ] 

Ted Yu commented on HBASE-14655:


Gone through 
hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestShell-output.txt
Didn't find compaction happening.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1.0-v6.txt, 
> 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 
> 14655-v8.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969266#comment-14969266
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12768022/14655-branch-1-v8.txt
  against branch-1 branch at commit 098022ef70a5c18180214bbf89d40413a04809d4.
  ATTACHMENT ID: 12768022

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 18 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16172//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16172//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16172//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16172//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1.0-v6.txt, 
> 14655-branch-1.0-v7.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt, 14655-v8.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968974#comment-14968974
 ] 

Ted Yu commented on HBASE-14655:


There will be patch v8.

I ran TestShell with patch v7 locally:
{code}
Running org.apache.hadoop.hbase.client.TestShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 219.119 sec - 
in org.apache.hadoop.hbase.client.TestShell

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{code}

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968803#comment-14968803
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12767968/14655-v8.txt
  against master branch at commit 6a90e7b43ba7a0eb54b446ffa1067cf5858ee8c6.
  ATTACHMENT ID: 12767968

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 18 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16166//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16166//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16166//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16166//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968769#comment-14968769
 ] 

stack commented on HBASE-14655:
---

hmmm... will wait on v8 run

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968768#comment-14968768
 ] 

stack commented on HBASE-14655:
---

Failed here

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test 
(secondPartTestsExecution) on project hbase-shell: There was a timeout or other 
error in the fork -> [Help 1]

Could this patch effect a shell command? Let me rerun.  Unlikely... 

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968695#comment-14968695
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12767954/14655-branch-1-v7.txt
  against branch-1 branch at commit 39521068e8733b2df0f27832c3da214fe3b19d20.
  ATTACHMENT ID: 12767954

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16162//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16162//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16162//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16162//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968635#comment-14968635
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12767958/14655-branch-1.0-v7.txt
  against branch-1.0 branch at commit 39521068e8733b2df0f27832c3da214fe3b19d20.
  ATTACHMENT ID: 12767958

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16163//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16163//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16163//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16163//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt, 14655-v8.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968533#comment-14968533
 ] 

stack commented on HBASE-14655:
---

bq. Since stripe compaction is of limited use, I suggest tackling it in 
separate JIRA.

Don't we have enough issues on doAs already? Why not address them all in the 
one patch. Then we could look for duplicated code or if there was commonage for 
the fix between the fix in three (and now four) localities?

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968529#comment-14968529
 ] 

stack commented on HBASE-14655:
---

Our patch builds have effectively stabilized. Suggest retry the patch. Seems 
like a checkstyle issue still.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 
> 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 
> 14655-v6.txt, 14655-v7.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968518#comment-14968518
 ] 

Ted Yu commented on HBASE-14655:


Checked 
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//testReport/org.apache.hadoop.hbase.regionserver/TestHRegionOnCluster/testDataCorrectnessReplayingRecoveredEdits/

There was no compaction involved in the above test.

I ran TestHRegionOnCluster locally with patch and it passed.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968509#comment-14968509
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12767940/14655-branch-1.0-v6.txt
  against branch-1.0 branch at commit b3afdb8de1a9fa88c553159b2d2d2aa96902a345.
  ATTACHMENT ID: 12767940

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
3767 checkstyle errors (more than the master's current 3765 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Jerry He (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968494#comment-14968494
 ] 

Jerry He commented on HBASE-14655:
--

bq. Since stripe compaction is of limited use, I suggest tackling it in 
separate JIRA.

Okay.
+1
The test failure does not seem to be related.  Let us know if it is.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968469#comment-14968469
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12767933/14655-branch-1-v6.txt
  against branch-1 branch at commit b3afdb8de1a9fa88c553159b2d2d2aa96902a345.
  ATTACHMENT ID: 12767933

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
3761 checkstyle errors (more than the master's current 3759 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16159//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16159//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16159//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16159//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968448#comment-14968448
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12767917/14655-v6.txt
  against master branch at commit b3afdb8de1a9fa88c553159b2d2d2aa96902a345.
  ATTACHMENT ID: 12767917

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
1749 checkstyle errors (more than the master's current 1747 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16157//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16157//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16157//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16157//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, 
> 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 
> 14655-v4.txt, 14655-v5.txt, 14655-v6.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968224#comment-14968224
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12767864/14655-branch-1-v5.txt
  against branch-1 branch at commit b3afdb8de1a9fa88c553159b2d2d2aa96902a345.
  ATTACHMENT ID: 12767864

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16150//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16150//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16150//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16150//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Jerry He (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968167#comment-14968167
 ] 

Jerry He commented on HBASE-14655:
--

Looks good overall.  The approach is similar to  HBASE-14605 (split) and 
HBASE-14631 (merge).
But compaction has its own complexity.
A couple of questions.
1. Looks like only the default compactor will behave as doAs().  Stripe 
compaction will not?
2. The interface change in Store, which is marked as 
LimitedPrivate(HBaseInterfaceAudience.COPROC).  Should anything be deprecated 
or marked?  The other method changes seem to be all private.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-v1.txt, 14655-v2.txt, 
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967708#comment-14967708
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12767798/14655-v5.txt
  against master branch at commit 6e3b7af0efced7351163a5011a44bfc18851fce0.
  ATTACHMENT ID: 12767798

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16144//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16144//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16144//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16144//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 
> 14655-v5.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966863#comment-14966863
 ] 

Ted Yu commented on HBASE-14655:


{code}
Fetching https://builds.apache.org/job/PreCommit-HBASE-Build/16133/console
Printing hanging tests
Hanging test : org.apache.hadoop.hbase.TestIOFencing
Printing Failing tests
{code}
I don't think hanging TestIOFencing is related to the change in my patch.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966227#comment-14966227
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12767707/14655-v4.txt
  against master branch at commit 5a5b854c2a66200e24b46682c5cf19d67142c06f.
  ATTACHMENT ID: 12767707

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16133//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16133//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16133//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16133//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16133//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966058#comment-14966058
 ] 

Hadoop QA commented on HBASE-14655:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12767676/14655-v2.txt
  against master branch at commit a532ed73d808f543909c5563999405c82fa9b1d5.
  ATTACHMENT ID: 12767676

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16125//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16125//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16125//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16125//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for 
> compaction
> 
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-v1.txt, 14655-v2.txt, 14655-v3.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling 
> doAs() for compaction related region observer notifications should be 
> narrowed.
> User object is passed from CompactSplitThread down to the methods where 
> region observer notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)