[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998918#comment-14998918 ] Hudson commented on HBASE-14693: FAILURE: Integrated in HBase-0.98-matrix #258 (See [https://builds.apache.org/job/HBase-0.98-matrix/258/]) HBASE-14693 Add client-side metrics for received pushback signals (apurtell: rev 70964f48a7fbc03bade66d6f075fd78e6dcd8627) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693-0.98.patch, HBASE-14693.patch, > HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch, > HBASE-14693_v4.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998943#comment-14998943 ] Hudson commented on HBASE-14693: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1131 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1131/]) HBASE-14693 Add client-side metrics for received pushback signals (apurtell: rev 70964f48a7fbc03bade66d6f075fd78e6dcd8627) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693-0.98.patch, HBASE-14693.patch, > HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch, > HBASE-14693_v4.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[
https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997923#comment-14997923
]
Hadoop QA commented on HBASE-14693:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12771466/HBASE-14693-0.98.patch
against 0.98 branch at commit 44367f55e8bbd252ae824d1ddb626b5ce91fe75d.
ATTACHMENT ID: 12771466
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
28 warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3898 checkstyle errors (more than the master's current 3890 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16470//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16470//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16470//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16470//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16470//console
This message is automatically generated.
> Add client-side metrics for received pushback signals
> -
>
> Key: HBASE-14693
> URL: https://issues.apache.org/jira/browse/HBASE-14693
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Heng Chen
> Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16
>
> Attachments: HBASE-14693-0.98.patch, HBASE-14693.patch,
> HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch,
> HBASE-14693_v4.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for
> sending advisory backpressure signals to clients when the server is heavily
> loaded, and HBASE-12702 and subtasks backported this to all active branches.
> Add client-side metrics for received pushback signal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997920#comment-14997920 ] Hudson commented on HBASE-14693: FAILURE: Integrated in HBase-1.3-IT #303 (See [https://builds.apache.org/job/HBase-1.3-IT/303/]) HBASE-14693 Add client-side metrics for received pushback signals (apurtell: rev 7330e11aa44f42c7648e9ba4c9cb9e30cc9c5a9d) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693-0.98.patch, HBASE-14693.patch, > HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch, > HBASE-14693_v4.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997933#comment-14997933 ] Hudson commented on HBASE-14693: SUCCESS: Integrated in HBase-1.2-IT #273 (See [https://builds.apache.org/job/HBase-1.2-IT/273/]) HBASE-14693 Add client-side metrics for received pushback signals (apurtell: rev e3f8a943d72faf6ebbdde80907f99657dfb55f67) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693-0.98.patch, HBASE-14693.patch, > HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch, > HBASE-14693_v4.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997992#comment-14997992 ] Hudson commented on HBASE-14693: SUCCESS: Integrated in HBase-1.2 #357 (See [https://builds.apache.org/job/HBase-1.2/357/]) HBASE-14693 Add client-side metrics for received pushback signals (apurtell: rev e3f8a943d72faf6ebbdde80907f99657dfb55f67) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693-0.98.patch, HBASE-14693.patch, > HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch, > HBASE-14693_v4.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998007#comment-14998007 ] Hudson commented on HBASE-14693: FAILURE: Integrated in HBase-Trunk_matrix #453 (See [https://builds.apache.org/job/HBase-Trunk_matrix/453/]) HBASE-14693 Add client-side metrics for received pushback signals (apurtell: rev 086bacd12d1c32a6c1c6736091334185be144a04) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693-0.98.patch, HBASE-14693.patch, > HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch, > HBASE-14693_v4.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998033#comment-14998033 ] Hudson commented on HBASE-14693: SUCCESS: Integrated in HBase-1.3 #358 (See [https://builds.apache.org/job/HBase-1.3/358/]) HBASE-14693 Add client-side metrics for received pushback signals (apurtell: rev 7330e11aa44f42c7648e9ba4c9cb9e30cc9c5a9d) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693-0.98.patch, HBASE-14693.patch, > HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch, > HBASE-14693_v4.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[
https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991548#comment-14991548
]
Hadoop QA commented on HBASE-14693:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12770761/HBASE-14693_v4.patch
against master branch at commit 050ebe850b32057860fb94b46f955352db139db1.
ATTACHMENT ID: 12770761
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16405//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16405//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16405//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16405//console
This message is automatically generated.
> Add client-side metrics for received pushback signals
> -
>
> Key: HBASE-14693
> URL: https://issues.apache.org/jira/browse/HBASE-14693
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Heng Chen
> Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16
>
> Attachments: HBASE-14693.patch, HBASE-14693_v1.patch,
> HBASE-14693_v2.patch, HBASE-14693_v3.patch, HBASE-14693_v4.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for
> sending advisory backpressure signals to clients when the server is heavily
> loaded, and HBASE-12702 and subtasks backported this to all active branches.
> Add client-side metrics for received pushback signal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[
https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988768#comment-14988768
]
Andrew Purtell commented on HBASE-14693:
Mostly lgtm.
Fix this typo. Should be incrNormalRunners.
{code}
@@ -242,6 +333,21 @@ public class MetricsConnection {
metaCacheMisses.inc();
}
+ /** Increment the number of normal runner counts. */
+ public void incrNormaRunners() {
+this.runnerStats.incrNormalRunners();
+ }
{code}
I can fix this on commit if there's nothing else.
> Add client-side metrics for received pushback signals
> -
>
> Key: HBASE-14693
> URL: https://issues.apache.org/jira/browse/HBASE-14693
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Heng Chen
> Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16
>
> Attachments: HBASE-14693.patch, HBASE-14693_v1.patch,
> HBASE-14693_v2.patch, HBASE-14693_v3.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for
> sending advisory backpressure signals to clients when the server is heavily
> loaded, and HBASE-12702 and subtasks backported this to all active branches.
> Add client-side metrics for received pushback signal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979510#comment-14979510 ] Heng Chen commented on HBASE-14693: --- Suggestions? [~apurtell] > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693.patch, HBASE-14693_v1.patch, > HBASE-14693_v2.patch, HBASE-14693_v3.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[
https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976321#comment-14976321
]
Hadoop QA commented on HBASE-14693:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12768925/HBASE-14693_v3.patch
against master branch at commit 4269c7fe69baabbd813dcdf6ed0b3a57ea4b41de.
ATTACHMENT ID: 12768925
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+assertEquals(rsStats.heapOccupancyHist.mean(),
(double)regionStats.getHeapOccupancyPercent(), 0.1 );
+assertEquals(rsStats.memstoreLoadHist.mean(),
(double)regionStats.getMemstoreLoadPercent(), 0.1);
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16245//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16245//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16245//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16245//console
This message is automatically generated.
> Add client-side metrics for received pushback signals
> -
>
> Key: HBASE-14693
> URL: https://issues.apache.org/jira/browse/HBASE-14693
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Heng Chen
> Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16
>
> Attachments: HBASE-14693.patch, HBASE-14693_v1.patch,
> HBASE-14693_v2.patch, HBASE-14693_v3.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for
> sending advisory backpressure signals to clients when the server is heavily
> loaded, and HBASE-12702 and subtasks backported this to all active branches.
> Add client-side metrics for received pushback signal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[
https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973939#comment-14973939
]
Hadoop QA commented on HBASE-14693:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12768664/HBASE-14693_v1.patch
against master branch at commit 8a2cef3315516501627c7a30bdcf989b12a32303.
ATTACHMENT ID: 12768664
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1736 checkstyle errors (more than the master's current 1732 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+// we must do client metrics first, because after
ResultStatsUtil.updateStats result will be changed
+
AsyncProcess.this.connection.getConnectionMetrics().updateServerStats(server,
regionName, result);
+MetricsConnection.RegionStats rsStats =
conn.getConnectionMetrics().serverStats.get(server).get(Bytes.toStringBinary(regionName));
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16226//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16226//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16226//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16226//console
This message is automatically generated.
> Add client-side metrics for received pushback signals
> -
>
> Key: HBASE-14693
> URL: https://issues.apache.org/jira/browse/HBASE-14693
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
> Attachments: HBASE-14693.patch, HBASE-14693_v1.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for
> sending advisory backpressure signals to clients when the server is heavily
> loaded, and HBASE-12702 and subtasks backported this to all active branches.
> Add client-side metrics for received pushback signal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975086#comment-14975086 ] Andrew Purtell commented on HBASE-14693: Thanks for picking this up [~chenheng]! Histograms of the server side feedback values and the other information they provide (like number of samples) is a great start. To complete the picture we should have metrics on the use of DelayingRunner: count of use of normal runners, count of use of delaying runners, histogram of delaying runner delay intervals. > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell > Attachments: HBASE-14693.patch, HBASE-14693_v1.patch, > HBASE-14693_v2.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975103#comment-14975103 ] Andrew Purtell commented on HBASE-14693: Assigned to you [~chenheng]. Thanks again. > Add client-side metrics for received pushback signals > - > > Key: HBASE-14693 > URL: https://issues.apache.org/jira/browse/HBASE-14693 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16 > > Attachments: HBASE-14693.patch, HBASE-14693_v1.patch, > HBASE-14693_v2.patch > > > HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for > sending advisory backpressure signals to clients when the server is heavily > loaded, and HBASE-12702 and subtasks backported this to all active branches. > Add client-side metrics for received pushback signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[
https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974811#comment-14974811
]
Hadoop QA commented on HBASE-14693:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12768735/HBASE-14693_v2.patch
against master branch at commit 899857609c7c2c2b0fd3fa72d3bd585cb2703e0a.
ATTACHMENT ID: 12768735
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16230//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16230//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16230//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16230//console
This message is automatically generated.
> Add client-side metrics for received pushback signals
> -
>
> Key: HBASE-14693
> URL: https://issues.apache.org/jira/browse/HBASE-14693
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
> Attachments: HBASE-14693.patch, HBASE-14693_v1.patch,
> HBASE-14693_v2.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for
> sending advisory backpressure signals to clients when the server is heavily
> loaded, and HBASE-12702 and subtasks backported this to all active branches.
> Add client-side metrics for received pushback signal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals
[
https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973726#comment-14973726
]
Hadoop QA commented on HBASE-14693:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12768606/HBASE-14693.patch
against master branch at commit 8a2cef3315516501627c7a30bdcf989b12a32303.
ATTACHMENT ID: 12768606
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail with Hadoop version 2.4.0.
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:[174,28]
cannot find symbol
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on
project hbase-client: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:[174,28]
cannot find symbol
[ERROR] symbol: method
putIfAbsent(org.apache.hadoop.hbase.ServerName,java.util.concurrent.ConcurrentHashMap)
[ERROR] location: variable serverStats of type
java.util.Map>
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hbase-client
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16225//console
This message is automatically generated.
> Add client-side metrics for received pushback signals
> -
>
> Key: HBASE-14693
> URL: https://issues.apache.org/jira/browse/HBASE-14693
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
> Attachments: HBASE-14693.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for
> sending advisory backpressure signals to clients when the server is heavily
> loaded, and HBASE-12702 and subtasks backported this to all active branches.
> Add client-side metrics for received pushback signal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
