[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990558#comment-14990558
]
Ted Yu commented on HBASE-14706:
>From QA run:
{code}
Running org.apache.hadoop.hbase.master.balancer.TestRegionLocationFinder
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.319 sec - in
org.apache.hadoop.hbase.master.balancer.TestRegionLocationFinder
{code}
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706-trunk_v2.patch,
> HBASE-14706-trunk_v3.patch, HBASE-14706-trunk_v4.patch, HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989109#comment-14989109
]
Hadoop QA commented on HBASE-14706:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12770509/HBASE-14706-trunk_v4.patch
against master branch at commit ceddec9141b658c790d2fb995c970982ab082028.
ATTACHMENT ID: 12770509
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16382//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16382//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16382//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16382//console
This message is automatically generated.
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706-trunk_v2.patch,
> HBASE-14706-trunk_v3.patch, HBASE-14706-trunk_v4.patch, HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988789#comment-14988789
]
Ted Yu commented on HBASE-14706:
{code}
+ * Copyright 2010 The Apache Software Foundation
{code}
Year is not needed. Check other source file for standard license header.
{code}
+// wait flush region
+Thread.sleep(5000);
{code}
Can you find other approach instead of sleeping ?
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706-trunk_v2.patch,
> HBASE-14706-trunk_v3.patch, HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988816#comment-14988816
]
Guanghao Zhang commented on HBASE-14706:
Thanks. Update with v4. It doesn't need to wait region flush.
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706-trunk_v2.patch,
> HBASE-14706-trunk_v3.patch, HBASE-14706-trunk_v4.patch, HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984802#comment-14984802
]
Hadoop QA commented on HBASE-14706:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12770028/HBASE-14706-trunk_v3.patch
against master branch at commit e8d6bf7d461fd9428ec55009ce1c24d8f3f65485.
ATTACHMENT ID: 12770028
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16340//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16340//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16340//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16340//console
This message is automatically generated.
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706-trunk_v2.patch,
> HBASE-14706-trunk_v3.patch, HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982512#comment-14982512
]
Guanghao Zhang commented on HBASE-14706:
Test results in my local machine.
---
T E S T S
---
Running org.apache.hadoop.hbase.master.balancer.TestRegionLocationFinder
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.342 sec - in
org.apache.hadoop.hbase.master.balancer.TestRegionLocationFinder
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706-trunk_v2.patch,
> HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981681#comment-14981681
]
Guanghao Zhang commented on HBASE-14706:
Attach a new patch with ut for RegionLocationFinder.
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981764#comment-14981764
]
Hadoop QA commented on HBASE-14706:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12769677/HBASE-14706-trunk_v1.patch
against master branch at commit bdf11be6af046e99cff9985968903d983d7ff10f.
ATTACHMENT ID: 12769677
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail with Hadoop version 2.4.0.
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRegionLocationFinder.java:[46,2]
cannot find symbol
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile
(default-testCompile) on project hbase-server: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRegionLocationFinder.java:[46,2]
cannot find symbol
[ERROR] symbol: class Category
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hbase-server
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16296//console
This message is automatically generated.
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14706) RegionLocationFinder should return multiple servername by top host
[
https://issues.apache.org/jira/browse/HBASE-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981961#comment-14981961
]
Hadoop QA commented on HBASE-14706:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12769688/HBASE-14706-trunk_v2.patch
against master branch at commit bdf11be6af046e99cff9985968903d983d7ff10f.
ATTACHMENT ID: 12769688
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.balancer.TestRegionLocationFinder
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16297//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16297//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16297//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16297//console
This message is automatically generated.
> RegionLocationFinder should return multiple servername by top host
> --
>
> Key: HBASE-14706
> URL: https://issues.apache.org/jira/browse/HBASE-14706
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-14706-trunk_v1.patch, HBASE-14706-trunk_v2.patch,
> HBASE-14706.patch
>
>
> Multiple RS can run on the same host. But in current RegionLocationFinder,
> mapHostNameToServerName map one host to only one server. This will make
> LocalityCostFunction get wrong locality about region.
> {code}
> // create a mapping from hostname to ServerName for fast lookup
> HashMap hostToServerName = new HashMap ServerName>();
> for (ServerName sn : regionServers) {
> hostToServerName.put(sn.getHostname(), sn);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
