[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011412#comment-16011412 ] Sean Busbey commented on HBASE-15370: - FWIW, I wouldn't say that thread has run its course yet. I agree that it looks like things are bending towards no backport. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch, > HBASE-15370-branch-1.v2.patch, merge-conflict.list, mob-cmmits.txt, > mob-commits-v2.txt > > > MOB feature was integrated to master branch half a year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011402#comment-16011402 ] Ted Yu commented on HBASE-15370: This is recent thread on backporting where consensus is not to backport: http://search-hadoop.com/m/HBase/YGbb2NdxC1okisI1?subj=Re+HBASE+and+MOB > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch, > HBASE-15370-branch-1.v2.patch, merge-conflict.list, mob-cmmits.txt, > mob-commits-v2.txt > > > MOB feature was integrated to master branch half a year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180116#comment-15180116
]
Jonathan Hsieh commented on HBASE-15370:
Though this closed I wanted to address the questions here. Here's a rough
picture of what I was thinking the tree would look like after a successful
merge.
{code}
t# = trunk commit
b# = branch-1 commit
x# = hbase-11339 commit
y# = hbase-15370 commit.
..
b7Life in branch-1 goes on as normal
b6Merge into branch-1
|\
| +y5 Merge attempt after vote passes into hbase-15370
|/ |
b5 | Random branch-1 commit
b4 | Random branch-1 commit
|\ |
| +y4 Merge attempt of branch-1 into hbase-15370 (vote called)
|/ y3 (last backport of mob feature from trunk)
| y2 ..
| y1 (backport of mob feature from trunk)
. b3 |
. b2 |
| b1 |
|/|
| |
t2| hbase-11339 merged to trunk (trunk is no longer interesting after
this)
| \ /
| x1 (last commit of hbase-11339 before merge to trunk)
| x0
| /
t1(last merge with trunk and hbase-11339)
..
{code}
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
> Fix For: 1.4.0
>
> Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch,
> HBASE-15370-branch-1.v2.patch, merge-conflict.list, mob-cmmits.txt,
> mob-commits-v2.txt
>
>
> MOB feature was integrated to master branch half a year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178594#comment-15178594 ] Ted Yu commented on HBASE-15370: Another approach is to apply the identified commits related to MOB in reverse chronological order on hbase-15370 branch. This way, every commit is reviewable. The amount of work is not trivial. Working on integrating the first commit (HBASE-11643), there were compilation errors after resolving rejected hunks. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch, > HBASE-15370-branch-1.v2.patch, merge-conflict.list, mob-cmmits.txt, > mob-commits-v2.txt > > > MOB feature was integrated to master branch half a year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178438#comment-15178438 ] Ted Yu commented on HBASE-15370: Thanks [~jmhsieh] for the quick response. bq. periodically merge branch-1 into hbase-15370 Shouldn't this be done after the hbase-15370 branch is created ? Reasoning is that post hbase-11339 merge patches are not in branch-1. This would make merging hbase-15370 branch into branch-1 a lot easier. If so, wouldn't we encounter the same number of merge conflicts merging branch-1 to hbase-15370 branch ? > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch, > HBASE-15370-branch-1.v2.patch, merge-conflict.list, mob-cmmits.txt, > mob-commits-v2.txt > > > MOB feature was integrated to master branch half a year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178425#comment-15178425 ] Jonathan Hsieh commented on HBASE-15370: Hey [~tedyu], sorry if it wasn't clear -- I was suggesting: 1) create hbase-15370 branch from current hbase-11339 branch. 2) backport post hbase-11339 merge patches from trunk to hbase-15370 (with quick reviews) 3) periodically merge branch-1 into hbase-15370. This let's us clearly see the deltas that were fixed with these merges and doesn't "pollute" branch-1. 4) when things are stable, call branch merge vote. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch, > HBASE-15370-branch-1.v2.patch, merge-conflict.list, mob-cmmits.txt, > mob-commits-v2.txt > > > MOB feature was integrated to master branch half a year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178286#comment-15178286 ] Ted Yu commented on HBASE-15370: I sent an email to dev@hbase @ 9:02 AM Looks like there might be problem on email server. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch, > HBASE-15370-branch-1.v2.patch, mob-cmmits.txt, mob-commits-v2.txt > > > MOB feature was integrated to master branch half a year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177481#comment-15177481
]
Hadoop QA commented on HBASE-15370:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 53 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
3s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 58s
{color} | {color:green} branch-1 passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 13s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
0s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
11s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 7m 45s
{color} | {color:red} branch/. no findbugs output file
(./target/findbugsXml.xml) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 14s
{color} | {color:red} branch/hbase-it no findbugs output file
(hbase-it/target/findbugsXml.xml) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 33s
{color} | {color:green} branch-1 passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 21s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 16s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 17m 47s
{color} | {color:red} root-jdk1.8.0_74 with JDK v1.8.0_74 generated 6 new
issues (was 17, now 17). {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 17m 47s
{color} | {color:red} hbase-server-jdk1.8.0_74 with JDK v1.8.0_74 generated 6
new issues (was 6, now 6). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 29s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 21m 16s
{color} | {color:red} root-jdk1.7.0_95 with JDK v1.7.0_95 generated 6 new
issues (was 17, now 17). {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 21m 16s
{color} | {color:red} hbase-server-jdk1.7.0_95 with JDK v1.7.0_95 generated 6
new issues (was 6, now 6). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 29s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 51s
{color} | {color:red} Patch generated 40 new checkstyle issues in root (total
was 251, now 284). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s
{color} | {color:red} Patch generated 1 new checkstyle issues in hbase-client
(total was 7, now 8). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 7s
{color} | {color:red} Patch generated 2 new checkstyle issues in
hbase-hadoop2-compat (total was 1, now 3). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 16s
{color} | {color:red} Patch generated 37 new checkstyle issues in hbase-server
(total was 240, now 270). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
9s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 10s
{color} | {color:red} The applied patch generated 39 new rubocop issues (total
was 678, now 708). {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m 5s
{color} | {color:red} The applied patch generated 70 new ruby-lint issues
(tota
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177028#comment-15177028 ] Sean Busbey commented on HBASE-15370: - This looks like a fine email for starting the thread. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch, > HBASE-15370-branch-1.v2.patch, mob-cmmits.txt > > > MOB feature was integrated to master branch half a year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176495#comment-15176495
]
Hadoop QA commented on HBASE-15370:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 53 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
13s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 37s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 26s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
38s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
49s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 9m 3s
{color} | {color:red} branch/. no findbugs output file
(./target/findbugsXml.xml) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 13s
{color} | {color:red} branch/hbase-it no findbugs output file
(hbase-it/target/findbugsXml.xml) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 50s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 5s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 25s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 17m 11s
{color} | {color:red} root-jdk1.8.0_72 with JDK v1.8.0_72 generated 6 new
issues (was 17, now 17). {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 17m 11s
{color} | {color:red} hbase-server-jdk1.8.0_72 with JDK v1.8.0_72 generated 6
new issues (was 6, now 6). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 59s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 20m 11s
{color} | {color:red} root-jdk1.7.0_95 with JDK v1.7.0_95 generated 6 new
issues (was 17, now 17). {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 20m 11s
{color} | {color:red} hbase-server-jdk1.7.0_95 with JDK v1.7.0_95 generated 6
new issues (was 6, now 6). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 59s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 52s
{color} | {color:red} Patch generated 60 new checkstyle issues in root (total
was 251, now 305). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s
{color} | {color:red} Patch generated 1 new checkstyle issues in hbase-client
(total was 7, now 8). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 7s
{color} | {color:red} Patch generated 2 new checkstyle issues in
hbase-hadoop2-compat (total was 1, now 3). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 16s
{color} | {color:red} Patch generated 57 new checkstyle issues in hbase-server
(total was 240, now 291). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
1s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 12s
{color} | {color:red} The applied patch generated 39 new rubocop issues (total
was 678, now 708). {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m 5s
{color} | {color:red} The applied patch generated 70 new ruby-lint issues
(tota
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176245#comment-15176245
]
Ted Yu commented on HBASE-15370:
>From
>https://builds.apache.org/job/PreCommit-HBASE-Build/785/artifact/patchprocess/diff-patch-ruby-lint.txt
> :
{code}
/testptch/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:E:69:26: undefined
method org
/testptch/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:E:70:11: undefined
constant ::(send nil :org)::(send
/testptch/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:E:70:11: undefined
constant ::(send nil :org)::(send
/testptch/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:E:70:11: undefined
method org
/testptch/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:E:73:26: undefined
method org
{code}
Here is relevant code in admin.rb around line 69:
{code}
@admin.compact(org.apache.hadoop.hbase.TableName.valueOf(table_or_region_name),
org.apache.hadoop.hbase.client.Admin::CompactType::MOB)
{code}
'org' is not method name.
Not sure how ruby lint deduces the warning.
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.0
>
> Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch
>
>
> MOB feature was integrated to master branch 1 year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176172#comment-15176172 ] Ted Yu commented on HBASE-15370: How about the following as a starting point for thread on dev@hbase ? [DISCUSS] Criteria for including MOB feature backport in branch-1 This is to solicit discussion on the criteria for including MOB feature backport in branch-1. I can think of the following: 1. whether there is customer interest There is. See Jonathan's response here: http://search-hadoop.com/m/YGbbDSqxD1PYXK62 2. whether unit test stability can be maintained in branch-1 Inclusion of the backport should keep unit tests (both existing and new) in branch-1 green. Preliminary test runs showed that MOB / snapshot related tests consistently pass. https://issues.apache.org/jira/browse/HBASE-15370?focusedCommentId=15176094&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15176094 Comments are welcome > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176143#comment-15176143 ] Ted Yu commented on HBASE-15370: I looked for [DISCUSS] thread in my Inbox and using search-hadoop.com - haven't found one. [~busbey]: Mind refreshing my memory so that I can use it as a template ? Thanks > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176121#comment-15176121 ] Sean Busbey commented on HBASE-15370: - I would also like a properly labeled [DISCUSS] thread for what gates the backport getting applied to branch-1, similar to how we agreed to set a threshold on the hbase-spark work. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176094#comment-15176094
]
Hadoop QA commented on HBASE-15370:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 53 new or modified test
files. {color} |
| {color:red}-1{color} | {color:red} mvndep {color} | {color:red} 0m 53s
{color} | {color:red} branch's . dependency:list failed {color} |
| {color:red}-1{color} | {color:red} mvndep {color} | {color:red} 1m 19s
{color} | {color:red} branch's hbase-client dependency:list failed {color} |
| {color:red}-1{color} | {color:red} mvndep {color} | {color:red} 1m 33s
{color} | {color:red} branch's hbase-common dependency:list failed {color} |
| {color:red}-1{color} | {color:red} mvndep {color} | {color:red} 1m 42s
{color} | {color:red} branch's hbase-hadoop2-compat dependency:list failed
{color} |
| {color:red}-1{color} | {color:red} mvndep {color} | {color:red} 1m 46s
{color} | {color:red} branch's hbase-hadoop-compat dependency:list failed
{color} |
| {color:red}-1{color} | {color:red} mvndep {color} | {color:red} 1m 59s
{color} | {color:red} branch's hbase-it dependency:list failed {color} |
| {color:red}-1{color} | {color:red} mvndep {color} | {color:red} 2m 42s
{color} | {color:red} branch's hbase-server dependency:list failed {color} |
| {color:red}-1{color} | {color:red} mvndep {color} | {color:red} 2m 51s
{color} | {color:red} branch's hbase-shell dependency:list failed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 51s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
24s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 38s
{color} | {color:green} branch-1 passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 50s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 7m
8s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
57s {color} | {color:green} branch-1 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped branch modules with no Java source: . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 12s
{color} | {color:red} branch/hbase-it no findbugs output file
(hbase-it/target/findbugsXml.xml) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 55s
{color} | {color:green} branch-1 passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 54s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 2s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 41s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 41s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 50s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 10m 2s {color}
| {color:red} hbase-server-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 4
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 10m 2s {color}
| {color:red} root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 15
unchanged - 2 fixed = 17 total (was 17) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {colo
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176055#comment-15176055
]
Ted Yu commented on HBASE-15370:
Among the checkstyle warnings:
{code}
./hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/MobCompactor.java:42:24:
Variable 'fs' must be private and have accessor methods.
./hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/MobCompactor.java:43:27:
Variable 'conf' must be private and have accessor methods.
{code}
I plan to hold off addressing such warnings partly because this would create
some discrepancy between the backport and existing code in master branch.
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.0
>
> Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch
>
>
> MOB feature was integrated to master branch 1 year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176009#comment-15176009
]
Ted Yu commented on HBASE-15370:
Ran the failed tests locally:
{code}
Running org.apache.hadoop.hbase.regionserver.TestHRegion
Tests run: 102, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 389.037 sec -
in org.apache.hadoop.hbase.regionserver.TestHRegion
Running org.apache.hadoop.hbase.regionserver.TestFailedAppendAndSync
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.545 sec - in
org.apache.hadoop.hbase.regionserver.TestFailedAppendAndSync
Running
org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 121.348 sec -
in
org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
Running org.apache.hadoop.hbase.thrift.TestThriftHttpServer
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.527 sec - in
org.apache.hadoop.hbase.thrift.TestThriftHttpServer
{code}
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.0
>
> Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch
>
>
> MOB feature was integrated to master branch 1 year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175996#comment-15175996
]
Ted Yu commented on HBASE-15370:
None of the failed tests above were related to MOB or snapshot.
Some of them failed in recent Jenkins builds:
{code}
Fetching
https://builds.apache.org/job/HBase-1.3/583/jdk=latest1.8,label=yahoo-not-h2/console
Printing hanging tests
Hanging test : org.apache.hadoop.hbase.regionserver.TestHRegion
Printing Failing tests
{code}
TestFlushWithThroughputController failed here:
https://builds.apache.org/job/HBase-1.3/582/testReport/
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.0
>
> Attachments: 15370-test.out, HBASE-15370-branch-1.v1.patch
>
>
> MOB feature was integrated to master branch 1 year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175395#comment-15175395
]
Hadoop QA commented on HBASE-15370:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 53 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 18s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 25s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
45s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
54s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 11m 5s
{color} | {color:red} branch/. no findbugs output file
(./target/findbugsXml.xml) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 19s
{color} | {color:red} branch/hbase-it no findbugs output file
(hbase-it/target/findbugsXml.xml) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 50s
{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 12s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 3s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 48s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 26m 34s
{color} | {color:red} root-jdk1.8.0_72 with JDK v1.8.0_72 generated 6 new
issues (was 17, now 17). {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 26m 34s
{color} | {color:red} hbase-server-jdk1.8.0_72 with JDK v1.8.0_72 generated 6
new issues (was 6, now 6). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 1s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 31m 36s
{color} | {color:red} root-jdk1.7.0_95 with JDK v1.7.0_95 generated 6 new
issues (was 17, now 17). {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 31m 36s
{color} | {color:red} hbase-server-jdk1.7.0_95 with JDK v1.7.0_95 generated 6
new issues (was 6, now 6). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 1s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 21s
{color} | {color:red} Patch generated 60 new checkstyle issues in root (total
was 251, now 305). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 16s
{color} | {color:red} Patch generated 1 new checkstyle issues in hbase-client
(total was 7, now 8). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s
{color} | {color:red} Patch generated 2 new checkstyle issues in
hbase-hadoop2-compat (total was 1, now 3). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 24s
{color} | {color:red} Patch generated 57 new checkstyle issues in hbase-server
(total was 240, now 291). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
15s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 14s
{color} | {color:red} The applied patch generated 39 new rubocop issues (total
was 678, now 708).
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175278#comment-15175278 ] Ted Yu commented on HBASE-15370: Looking at tail of: https://builds.apache.org/job/PreCommit-HBASE-Build/785/console I wonder if the test got stuck. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174826#comment-15174826
]
Ted Yu commented on HBASE-15370:
The mega patch was generated based on backport of:
http://issues.apache.org/jira/secure/attachment/12745292/11339-master-v10.patch
Then patches for the following JIRAs were applied:
{code}
commit 7368344585ff8414a3f396398c1937602d47d129
Author: Jonathan M Hsieh
Date: Mon Nov 2 05:03:38 2015 -0800
HBASE-14731 Add -DuseMob option to ITBLL
commit 54b86b33940b57140d665a02156cfcf14ba792a2
HBASE-14500 Remove load of deprecated MOB ruby scripts after HBASE-14227
commit 02699fe967dde00cde3fc96af782401440dfe2ac
Author: chenheng
Date: Fri Sep 25 12:45:50 2015 +0800
HBASE-14227 Fold special cased MOB APIs into existing APIs
commit 5e26ae043dde217aeda29d9b67e290728adade89
Author: Matteo Bertozzi
Date: Wed Sep 23 10:43:31 2015 -0700
HBASE-14466 Remove duplicated code from MOB snapshot tests
{code}
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.0
>
> Attachments: HBASE-15370-branch-1.v1.patch
>
>
> MOB feature was integrated to master branch 1 year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174789#comment-15174789
]
stack commented on HBASE-15370:
---
I don't see my mail in here either:
https://mail-archives.apache.org/mod_mbox/hbase-dev/201603.mbox/browser Maybe
it is taking the long road:
{code}
MIME-Version: 1.0
Sender: saint@gmail.com
Received: by 10.182.233.193 with HTTP; Tue, 1 Mar 2016 09:32:00 -0800 (PST)
In-Reply-To:
References:
<97556505-2173-4849-8ccb-48488f167...@gmail.com>
Date: Tue, 1 Mar 2016 09:32:00 -0800
Delivered-To: saint@gmail.com
X-Google-Sender-Auth: MLC0CSlJonDUWnJxhyKi5wvrjtQ
Message-ID:
Subject: Re: MOB in branch-1? (Re: [RESULT][VOTE] Merge branch hbase-11339
HBase MOB to trunk)
From: Stack
To: HBase Dev List
Cc: Hbase-User
Content-Type: multipart/alternative; boundary=089e01537e449a3329052d00248b
...
{code}
Yeah, I think someone who knows MOB better is needed to land 750kb of patch in
branch-1. I mean, you don't even list the JIRAs the 750kb includes nor how you
derived it nor a commit log on what is coming back. Its a totally inscrutable
blob.
Also looks like needs to be a DISCUSS thread too first.
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.0
>
> Attachments: HBASE-15370-branch-1.v1.patch
>
>
> MOB feature was integrated to master branch 1 year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174773#comment-15174773 ] Ted Yu commented on HBASE-15370: Uploading onto reviewboard was slow. Is it Okay to omit protobuf generated files ? If so, I can try with the smaller patch. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174769#comment-15174769 ] Andrew Purtell commented on HBASE-15370: FWIW, I think it's fine to have a backport patch here for discussion and review. Doesn't mean we commit it. I only commit to making a pass over whatever goes up on reviews.a.o. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174762#comment-15174762 ] Ted Yu commented on HBASE-15370: I searched my Inbox but didn't find the above comment. Assuming the above comment was made at 9:32 AM today, search-hadoop should have indexed it. bq. Backport should be done by someone who knows MOB. I have been reviewing MOB related code, porting it to branch-1, running MOB related tests, etc. Of course there're people who are more familiar with MOB code. And I am fully open to their reviewing the backport patch. bq. there should be no new flakies in branch-1 I agree. That's was why I ran whole test suite (which passed) before attaching patch here. The backport patch should run through multiple QA runs before being considered stable. bq. I see notes that TestMobExportSnapshot has failed a few times (that is probably because the test it derives from is flakey) The test it derives from seems to be flaky. Let me loop TestMobExportSnapshot and TestMobRestoreFlushSnapshotFromClient on Linux to see if they fail with the backport. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174743#comment-15174743
]
stack commented on HBASE-15370:
---
This one:
{code}
from: Stack
to: HBase Dev List
cc: Hbase-User
date: Tue, Mar 1, 2016 at 9:32 AM
subject:Re: MOB in branch-1? (Re: [RESULT][VOTE] Merge branch
hbase-11339 HBase MOB to trunk)
mailed-by: gmail.com
On Mon, Feb 29, 2016 at 8:20 PM, Ted Yu wrote:
If there is no objection, I will create a backport JIRA tomorrow and attach
patch.
I have objection to you doing it. MOB has spread all about master branch.
Backport should be done by someone who knows MOB.
Higher up in this thread, Sean asks: "Can we get a [DISCUSS] flagged thread to
see what, if anything, folks
would like to see gate inclusion in branch-1?" Shouldn't we do this before we
'create a backport...'.
For me, there should be no new flakies in branch-1. Branch-1 builds are a
hard-won stable(-ish). Looking at master build, MOB seems quiet lately but
going by HBASE-15012, our flakies umbrella issue, I see notes that
TestMobExportSnapshot has failed a few times (that is probably because the test
it derives from is flakey) and TestMobRestoreFlushSnapshotFromClient gets a
mention.
St.Ack
{code}
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.0
>
> Attachments: HBASE-15370-branch-1.v1.patch
>
>
> MOB feature was integrated to master branch 1 year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174739#comment-15174739 ] Ted Yu commented on HBASE-15370: Is this the note you were talking about ? bq. This did not happen. The use case is to surface in another forum soon though. My reading of the above is that the user case would surface somewhere - since the forum was not mentioned, I don't have clue where. Please let me know what needs to be done to address the note. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174738#comment-15174738
]
Andrew Purtell commented on HBASE-15370:
Perhaps the comment was cut off? I only see
{blockquote}
On Mon, Feb 29, 2016 at 6:56 PM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote:
though
St.Ack
{quote}
> Backport Moderate Object Storage (MOB) to branch-1
> --
>
> Key: HBASE-15370
> URL: https://issues.apache.org/jira/browse/HBASE-15370
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.0
>
> Attachments: HBASE-15370-branch-1.v1.patch
>
>
> MOB feature was integrated to master branch 1 year ago.
> Since then there have been bug fixes which stabilize the feature.
> Some customers have been using it at PB scale.
> Here is discussion thread on dev mailing list:
> http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+
> This issue is to backport MOB feature to branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174729#comment-15174729 ] stack commented on HBASE-15370: --- I'm going to close this issue if my note on the MOB thread is not addressed; i.e. the note on the end of the thread cited in the description above. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174722#comment-15174722 ] Andrew Purtell commented on HBASE-15370: A 731kb patch is too large to review here, mind putting it up on reviews.a.o ? > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: HBASE-15370-branch-1.v1.patch > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15370) Backport Moderate Object Storage (MOB) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174097#comment-15174097 ] Ted Yu commented on HBASE-15370: I am working on the backport patch and running test suite based on the patch. Will post the patch after test run. > Backport Moderate Object Storage (MOB) to branch-1 > -- > > Key: HBASE-15370 > URL: https://issues.apache.org/jira/browse/HBASE-15370 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > > MOB feature was integrated to master branch 1 year ago. > Since then there have been bug fixes which stabilize the feature. > Some customers have been using it at PB scale. > Here is discussion thread on dev mailing list: > http://search-hadoop.com/m/YGbbDSqxD1PYXK62/hbase+MOB+in+branch-1&subj=Re+MOB+in+branch+1+Re+RESULT+VOTE+Merge+branch+hbase+11339+HBase+MOB+to+trunk+ > This issue is to backport MOB feature to branch-1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
