[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250305#comment-15250305 ] Hudson commented on HBASE-15507: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1205 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1205/]) HBASE-15647 Backport HBASE-15507 (update_peer_config) to 0.98 (apurtell: rev c9b9f7f660519bc9576f73f5a79ef27f55475651) * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java * hbase-shell/src/main/ruby/shell.rb * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java * hbase-shell/src/main/ruby/shell/commands/update_peer_config.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfigListener.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeers.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationSerDeHelper.java * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507-v3.patch, HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250249#comment-15250249 ] Hudson commented on HBASE-15507: FAILURE: Integrated in HBase-0.98-matrix #333 (See [https://builds.apache.org/job/HBase-0.98-matrix/333/]) HBASE-15647 Backport HBASE-15507 (update_peer_config) to 0.98 (apurtell: rev c9b9f7f660519bc9576f73f5a79ef27f55475651) * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java * hbase-shell/src/main/ruby/shell.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationSerDeHelper.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeers.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java * hbase-shell/src/main/ruby/shell/commands/update_peer_config.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfigListener.java > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507-v3.patch, HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239133#comment-15239133 ] Hudson commented on HBASE-15507: FAILURE: Integrated in HBase-1.4 #85 (See [https://builds.apache.org/job/HBase-1.4/85/]) HBASE-15633 Backport HBASE-15507 to branch-1 (Geoffrey Jacoby) (tedyu: rev 85f2caf1843c03703f7326b55b163623ca734c73) * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationSerDeHelper.java * hbase-shell/src/main/ruby/shell/commands/update_peer_config.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeers.java * hbase-shell/src/main/ruby/shell.rb * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfigListener.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507-v3.patch, HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233472#comment-15233472 ] Hudson commented on HBASE-15507: FAILURE: Integrated in HBase-Trunk_matrix #834 (See [https://builds.apache.org/job/HBase-Trunk_matrix/834/]) HBASE-15507 Online modification of enabled ReplicationPeerConfig (tedyu: rev e0f31ba6e68416db359d31eee21750cd7559909f) * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfigListener.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java * hbase-shell/src/main/ruby/shell/commands/update_peer_config.rb * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeers.java * hbase-shell/src/main/ruby/shell.rb * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507-v3.patch, HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[
https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233282#comment-15233282
]
Ted Yu commented on HBASE-15507:
Usual flaky test failures.
{code}
-rw-r--r-- 1 tyu staff 2283 Apr 8 18:41
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java.rej
-rw-r--r-- 1 tyu staff 2050 Apr 8 18:41
./hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java.rej
-rw-r--r-- 1 tyu staff 685 Apr 8 18:41
./hbase-shell/src/main/ruby/hbase/replication_admin.rb.rej
{code}
Mind attaching patch for branch-1, Geoffrey ?
Thanks
> Online modification of enabled ReplicationPeerConfig
>
>
> Key: HBASE-15507
> URL: https://issues.apache.org/jira/browse/HBASE-15507
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
> Labels: Replication, shell
> Fix For: 2.0.0
>
> Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch,
> HBASE-15507-v3.patch, HBASE-15507.patch
>
>
> It's currently possible to update the table CFs for a replication peer while
> it's running, but not the peer configuration or data maps introduced as part
> of custom replication endpoints in HBASE-11367.
> This means that if you have a custom endpoint that depends on some
> configuration parameter, you have to remove the peer and recreate it in order
> to change the param. In some use cases that's not possible without risking
> data loss.
> HBASE-11393, which will consolidate tableCFs in the same znode as the rest of
> ReplicationPeerConfig, may help here, but with or without it it still seems
> like there needs to be further work to add update config/data API support to
> ReplicationAdmin and a callback mechanism to notify the endpoints of config
> parameter changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[
https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233276#comment-15233276
]
Hadoop QA commented on HBASE-15507:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 1s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 1s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
48s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 56s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 9s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 9m
58s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
19s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
37s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 21s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 4s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
27s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 36s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 7s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
53s {color} | {color:green} hbase-client: patch generated 0 new + 99 unchanged
- 3 fixed = 99 total (was 102) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
39s {color} | {color:green} hbase-client: patch generated 0 new + 99 unchanged
- 3 fixed = 99 total (was 102) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
40s {color} | {color:green} hbase-server: patch generated 0 new + 99 unchanged
- 3 fixed = 99 total (was 102) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
33s {color} | {color:green} hbase-server: patch generated 0 new + 99 unchanged
- 3 fixed = 99 total (was 102) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
32s {color} | {color:green} hbase-shell: patch generated 0 new + 99 unchanged -
3 fixed = 99 total (was 102) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
35s {color} | {color:green} hbase-shell: patch generated 0 new + 99 unchanged -
3 fixed = 99 total (was 102) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 24s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
40s {color} | {
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232867#comment-15232867 ] Geoffrey Jacoby commented on HBASE-15507: - That's in the v3 patch as well; I believe it just wanted me to add a 'synchronized' to PeerConfigTracker.setListener. Given there's a 1:1 mapping between Endpoint and Peer, and it's only called during init which should be single-threaded, I'm not sure it's necessary. But having it shouldn't hurt for the same reason, I could be wrong, and it protects against future problems, so I put it in. > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507-v3.patch, HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232855#comment-15232855 ] Ted Yu commented on HBASE-15507: Can you fix FindBugs warning as well ? Thanks > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507-v3.patch, HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232802#comment-15232802 ] Ted Yu commented on HBASE-15507: Mind fixing checkstyle warnings ? > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[
https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231659#comment-15231659
]
Hadoop QA commented on HBASE-15507:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 4s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 4s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 19s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 5s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 13m
36s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
5s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
47s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 34s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 12s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 24s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m 24s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 54s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 54s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 38s
{color} | {color:red} hbase-client: patch generated 36 new + 99 unchanged - 3
fixed = 135 total (was 102) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 0s
{color} | {color:red} hbase-client: patch generated 36 new + 99 unchanged - 3
fixed = 135 total (was 102) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 26s
{color} | {color:red} hbase-server: patch generated 36 new + 99 unchanged - 3
fixed = 135 total (was 102) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 26s
{color} | {color:red} hbase-server: patch generated 36 new + 99 unchanged - 3
fixed = 135 total (was 102) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 47s
{color} | {color:red} hbase-shell: patch generated 36 new + 99 unchanged - 3
fixed = 135 total (was 102) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 48s
{color} | {color:red} hbase-shell: patch generated 36 new + 99 unchanged - 3
fixed = 135 total (was 102) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 9s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 58s
{color} | {color:red} hbase-client generated 1 new
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231244#comment-15231244 ] Ted Yu commented on HBASE-15507: Gone over patch v2. lgtm Let's see what Hadoop QA says. > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[
https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230905#comment-15230905
]
Ted Yu commented on HBASE-15507:
Please fix compilation error in latest patch :
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on
project hbase-client: Compilation failure: Compilation failure:
[ERROR]
/Users/tyu/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java:[74,31]
cannot find symbol
[ERROR] symbol: class ReplicationPeerConfigListener
[ERROR] location: interface org.apache.hadoop.hbase.replication.ReplicationPeer
[ERROR]
/Users/tyu/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[167,38]
cannot find symbol
[ERROR] symbol: class ReplicationPeerConfigListener
[ERROR] location: class
org.apache.hadoop.hbase.replication.ReplicationPeerZKImpl
[ERROR]
/Users/tyu/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[271,5]
cannot find symbol
[ERROR] symbol: class ReplicationPeerConfigListener
[ERROR] location: class
org.apache.hadoop.hbase.replication.ReplicationPeerZKImpl.PeerConfigTracker
[ERROR]
/Users/tyu/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[278,29]
cannot find symbol
[ERROR] symbol: class ReplicationPeerConfigListener
[ERROR] location: class
org.apache.hadoop.hbase.replication.ReplicationPeerZKImpl.PeerConfigTracker
{code}
> Online modification of enabled ReplicationPeerConfig
>
>
> Key: HBASE-15507
> URL: https://issues.apache.org/jira/browse/HBASE-15507
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
> Labels: Replication, shell
> Fix For: 2.0.0
>
> Attachments: HBASE-15507-v1.patch, HBASE-15507.patch
>
>
> It's currently possible to update the table CFs for a replication peer while
> it's running, but not the peer configuration or data maps introduced as part
> of custom replication endpoints in HBASE-11367.
> This means that if you have a custom endpoint that depends on some
> configuration parameter, you have to remove the peer and recreate it in order
> to change the param. In some use cases that's not possible without risking
> data loss.
> HBASE-11393, which will consolidate tableCFs in the same znode as the rest of
> ReplicationPeerConfig, may help here, but with or without it it still seems
> like there needs to be further work to add update config/data API support to
> ReplicationAdmin and a callback mechanism to notify the endpoints of config
> parameter changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[
https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230890#comment-15230890
]
Hadoop QA commented on HBASE-15507:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 1s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 1s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 40s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 5s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
19s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
37s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 33s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 58s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 14s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 14s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 21s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 21s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 17s
{color} | {color:red} hbase-client in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 24s
{color} | {color:red} hbase-client in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 34s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 23s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 17s {color}
| {color:red} hbase-client in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 24s {color}
| {color:red} hbase-client in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 34s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 23s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 14s
{color} | {color:red} hbase-client in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 14s
{color} | {color:red} hbase-client in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 22s
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 22s
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{co
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206450#comment-15206450 ] Heng Chen commented on HBASE-15507: --- Sounds great. In HBASE-11393, there will be a zk tracker for ReplicationPeerConfig, i think it will satisfy your needs. > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205332#comment-15205332 ] Enis Soztutar commented on HBASE-15507: --- Sounds good. Make this a part of Replication 2.0 parent jira? bq. HBASE-11393, which will consolidate tableCFs in the same znode as the rest of ReplicationPeerConfig, may help here, but with or without it it still seems like there needs to be further work to add update config/data API support to ReplicationAdmin and a callback mechanism to notify the endpoints of config parameter changes. [~chenheng] can say more. We have a zk tracker now, but you are right that we need the ReplicationEndpoint to be notified. > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
