[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250329#comment-16250329 ] Hudson commented on HBASE-15518: FAILURE: Integrated in Jenkins build HBase-2.0 #848 (See [https://builds.apache.org/job/HBase-2.0/848/]) HBASE-19244 Fix simple typos in HBASE-15518 descriptions (Clay B.) (tedyu: rev 31287d8931c8e1f3c92806a688d2c3ff6cfd5f7e) * (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSource.java > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518-v2.patch, > HBASE-15518-v3.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250264#comment-16250264 ] Hudson commented on HBASE-15518: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4048 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4048/]) HBASE-19244 Fix simple typos in HBASE-15518 descriptions (Clay B.) (tedyu: rev 3b8d95ad8b46ba9d71bb564bce624f6990b3e287) * (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSource.java > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518-v2.patch, > HBASE-15518-v3.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251273#comment-15251273 ] Hudson commented on HBASE-15518: FAILURE: Integrated in HBase-Trunk_matrix #860 (See [https://builds.apache.org/job/HBase-Trunk_matrix/860/]) HBASE-15518 Add Per-Table metrics back (Alicia Ying Shu) (enis: rev 18d70bc680856877a039e6613a3493793fc5960d) * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableAggregateSource.java * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableSourceImpl.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactoryImpl.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableAggregateSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregateImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableAggregate.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperStub.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTable.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregate.java > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518-v2.patch, > HBASE-15518-v3.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251180#comment-15251180 ] Hudson commented on HBASE-15518: FAILURE: Integrated in HBase-1.3 #662 (See [https://builds.apache.org/job/HBase-1.3/662/]) HBASE-15518 Add Per-Table metrics back (Alicia Ying Shu) (enis: rev f58652bc074a218705819cda501851e4e3127fe4) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregateImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperStub.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableAggregate.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTable.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableAggregateSource.java * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSource.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableAggregateSourceImpl.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactoryImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregate.java > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518-v2.patch, > HBASE-15518-v3.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251112#comment-15251112 ] Hudson commented on HBASE-15518: FAILURE: Integrated in HBase-1.4 #105 (See [https://builds.apache.org/job/HBase-1.4/105/]) HBASE-15518 Add Per-Table metrics back (Alicia Ying Shu) (enis: rev 1311e25171a19b369a51b06c199ce6f14eace983) * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactoryImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregateImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableAggregate.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregate.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTable.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperStub.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableAggregateSource.java * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSource.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableAggregateSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518-v2.patch, > HBASE-15518-v3.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250967#comment-15250967 ] Hudson commented on HBASE-15518: SUCCESS: Integrated in HBase-1.3-IT #626 (See [https://builds.apache.org/job/HBase-1.3-IT/626/]) HBASE-15518 Add Per-Table metrics back (Alicia Ying Shu) (enis: rev f58652bc074a218705819cda501851e4e3127fe4) * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableAggregateSource.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableAggregate.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableAggregateSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregate.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTable.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactoryImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregateImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperStub.java > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518-v2.patch, > HBASE-15518-v3.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248876#comment-15248876
]
Enis Soztutar commented on HBASE-15518:
---
I have tested this with YCSB to see whether there is any perf impact. As
expected (since aggregation happens in a backgroun thread, no metrics update
inline) I could not find any significant difference in 3 runs with 3M records,
10M ops and average 90K gets/s (all from block cache).
Here are the raw results:
{code}
with patch results
Run 1
[OVERALL], RunTime(ms), 109634.0
[OVERALL], Throughput(ops/sec), 91212.58003903898
[READ], Operations, 1.0E7
[READ], AverageLatency(us), 1058.0882089
[READ], MinLatency(us), 187.0
[READ], MaxLatency(us), 393471.0
[READ], 95thPercentileLatency(us), 2621.0
[READ], 99thPercentileLatency(us), 5367.0
[READ], Return=OK, 1000
Run 2
[OVERALL], RunTime(ms), 110720.0
[OVERALL], Throughput(ops/sec), 90317.91907514451
[READ], Operations, 1.0E7
[READ], AverageLatency(us), 1066.0874503
[READ], MinLatency(us), 193.0
[READ], MaxLatency(us), 586751.0
[READ], 95thPercentileLatency(us), 2707.0
[READ], 99thPercentileLatency(us), 5391.0
[READ], Return=OK, 1000
Run 3
[OVERALL], RunTime(ms), 42.0
[OVERALL], Throughput(ops/sec), 89974.9869536269
[READ], Operations, 1.0E7
[READ], AverageLatency(us), 1071.664219
[READ], MinLatency(us), 200.0
[READ], MaxLatency(us), 500223.0
[READ], 95thPercentileLatency(us), 2707.0
[READ], 99thPercentileLatency(us), 5583.0
[READ], Return=OK, 1000
Runtime avg:(109634.0 + 110720.0 + 42.0) / 3 = 110498.667
Throughput avg: (91212.58003903898 + 90317.91907514451 + 89974.9869536269) / 3
= 90501.82868927013
Without patch:
Run 1
[OVERALL], RunTime(ms), 108801.0
[OVERALL], Throughput(ops/sec), 91910.91993639764
[READ], Operations, 1.0E7
[READ], AverageLatency(us), 1048.1014036
[READ], MinLatency(us), 187.0
[READ], MaxLatency(us), 514815.0
[READ], 95thPercentileLatency(us), 2733.0
[READ], 99thPercentileLatency(us), 5743.0
[READ], Return=OK, 1000
Run 2
[OVERALL], RunTime(ms), 109120.0
[OVERALL], Throughput(ops/sec), 91642.22873900294
[READ], Operations, 1.0E7
[READ], AverageLatency(us), 1062.9898565
[READ], MinLatency(us), 192.0
[READ], MaxLatency(us), 321791.0
[READ], 95thPercentileLatency(us), 2713.0
[READ], 99thPercentileLatency(us), 5707.0
[READ], Return=OK, 1000
Run 3
[OVERALL], RunTime(ms), 109543.0
[OVERALL], Throughput(ops/sec), 91288.35251910209
[READ], Operations, 1.0E7
[READ], AverageLatency(us), 1067.1782325
[READ], MinLatency(us), 196.0
[READ], MaxLatency(us), 435711.0
[READ], 95thPercentileLatency(us), 2805.0
[READ], 99thPercentileLatency(us), 5831.0
[READ], Return=OK, 1000
Runtime avg:(108801.0 + 109120.0 + 109543.0) / 3 = 109154.667
Throughput avg: (91910.91993639764 + 91642.22873900294 + 91288.35251910209) / 3
= 91613.8337315009
{code}
Example output from JMX will be:
{code}
{
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Tables",
"modelerType" : "RegionServer,sub=Tables",
"tag.Context" : "regionserver",
"tag.Hostname" : "cn017.l42scl.hortonworks.com",
"Namespace_hbase_table_meta_metric_readRequestCount" : 4510,
"Namespace_hbase_table_meta_metric_writeRequestCount" : 218,
"Namespace_hbase_table_meta_metric_totalRequestCount" : 4728,
"Namespace_hbase_table_namespace_metric_readRequestCount" : 4,
"Namespace_hbase_table_namespace_metric_writeRequestCount" : 0,
"Namespace_hbase_table_namespace_metric_totalRequestCount" : 4,
"Namespace_default_table_tsdb-uid_metric_readRequestCount" : 0,
"Namespace_default_table_tsdb-uid_metric_writeRequestCount" : 0,
"Namespace_default_table_tsdb-uid_metric_totalRequestCount" : 0,
"Namespace_default_table_tsdb-meta_metric_readRequestCount" : 0,
"Namespace_default_table_tsdb-meta_metric_writeRequestCount" : 0,
"Namespace_default_table_tsdb-meta_metric_totalRequestCount" : 0,
"Namespace_default_table_usertable_metric_readRequestCount" : 8000,
"Namespace_default_table_usertable_metric_writeRequestCount" : 0,
"Namespace_default_table_usertable_metric_totalRequestCount" : 8000,
"Namespace_default_table_tsdb-tree_metric_readRequestCount" : 0,
"Namespace_default_table_tsdb-tree_metric_writeRequestCount" : 0,
"Namespace_default_table_tsdb-tree_metric_totalRequestCount" : 0,
"Namespace_default_table_TestTable_metric_readRequestCount" : 0,
"Namespace_default_table_TestTable_metric_writeRequestCount" : 0,
"Namespace_default_table_TestTable_metric_totalRequestCount" : 0,
"Namespace_default_table_tsdb_metric_readRequestCount" : 0,
"Namespace_default_table_tsdb_metric_writeRequestCount" : 0,
"Namespace_default_table_tsdb_metric_totalRequestCount" : 0,
"Namespace_default_table_usertable-empty_metric_readRequestCount" : 0,
"Namespace_default_table_usertable-empty_metric_writeRequ
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236903#comment-15236903
]
Hadoop QA commented on HBASE-15518:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 35s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
42s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 57s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
53s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 45s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 2s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 22s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 22s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s {color} | {color:green} hbase-hadoop-compat: patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s {color} | {color:green} hbase-hadoop2-compat: patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged -
1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 17s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 41s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s
{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s
{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 133m 6s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
53s {c
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236662#comment-15236662 ] Alicia Ying Shu commented on HBASE-15518: - Fixed the test issue in the revised patch. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518-v2.patch, > HBASE-15518-v3.patch, HBASE-15518.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235613#comment-15235613
]
Hadoop QA commented on HBASE-15518:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
13s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 59s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
44s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 35s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s {color} | {color:green} hbase-hadoop-compat: patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s {color} | {color:green} hbase-hadoop2-compat: patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged -
1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
37s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 31s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 5s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 52s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 12s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s
{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 32s
{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 34s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflic
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233346#comment-15233346 ] Alicia Ying Shu commented on HBASE-15518: - Ok. Found the issue. Will upload a patch later. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232424#comment-15232424 ] Alicia Ying Shu commented on HBASE-15518: - [~enis] Regarding to "Something wrong with the aggregation for table names "usertable" and "usertable-empty". They are showing the same values, versus only "usertable" should be having read requests." The problem is not from my patch, the numbers came from Region metrics data. It is an existing issue. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231293#comment-15231293
]
Hadoop QA commented on HBASE-15518:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
49s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 46s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 45s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 14s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 51s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 35s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 44s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 44s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s {color} | {color:green} hbase-hadoop-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} hbase-hadoop-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} hbase-hadoop2-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} hbase-hadoop2-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged -
3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged -
3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
5s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 21s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 9s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 50
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230888#comment-15230888
]
Enis Soztutar commented on HBASE-15518:
---
I've put this in a cluster to test. There is an issue it seems:
{code}
{
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Tables",
"modelerType" : "RegionServer,sub=Tables",
"tag.Context" : "regionserver",
"tag.Hostname" : "cn017.l42scl.hortonworks.com",
"Namespace_hbase_table_meta_metric_readRequestCount" : 2837518,
"Namespace_hbase_table_meta_metric_writeRequestCount" : 218,
"Namespace_hbase_table_meta_metric_totalRequestCount" : 2837736,
"Namespace_default_table_tsdb-meta_metric_readRequestCount" : 509116,
"Namespace_default_table_tsdb-meta_metric_writeRequestCount" : 0,
"Namespace_default_table_tsdb-meta_metric_totalRequestCount" : 509116,
"Namespace_hbase_table_namespace_metric_readRequestCount" : 341886,
"Namespace_hbase_table_namespace_metric_writeRequestCount" : 0,
"Namespace_hbase_table_namespace_metric_totalRequestCount" : 341886,
"Namespace_default_table_usertable_metric_readRequestCount" : 3200321,
"Namespace_default_table_usertable_metric_writeRequestCount" : 218,
"Namespace_default_table_usertable_metric_totalRequestCount" : 3200539,
"Namespace_default_table_tsdb-tree_metric_readRequestCount" : 1849882,
"Namespace_default_table_tsdb-tree_metric_writeRequestCount" : 0,
"Namespace_default_table_tsdb-tree_metric_totalRequestCount" : 1849882,
"Namespace_default_table_tsdb_metric_readRequestCount" : 2276253,
"Namespace_default_table_tsdb_metric_writeRequestCount" : 0,
"Namespace_default_table_tsdb_metric_totalRequestCount" : 2276253,
"Namespace_default_table_tsdb-uid_metric_readRequestCount" : 1520945,
"Namespace_default_table_tsdb-uid_metric_writeRequestCount" : 0,
"Namespace_default_table_tsdb-uid_metric_totalRequestCount" : 1520945,
"Namespace_default_table_usertable-empty_metric_readRequestCount" : 3200321,
"Namespace_default_table_usertable-empty_metric_writeRequestCount" : 218,
"Namespace_default_table_usertable-empty_metric_totalRequestCount" :
3200539,
"Namespace_default_table_TestTable_metric_readRequestCount" : 3076442,
"Namespace_default_table_TestTable_metric_writeRequestCount" : 218,
"Namespace_default_table_TestTable_metric_totalRequestCount" : 3076660,
"numTables" : 9
}
{code}
Something wrong with the aggregation for table names "usertable" and
"usertable-empty". They are showing the same values, versus only "usertable"
should be having read requests.
Also, look at this:
{code}
"Namespace_default_table_tsdb-tree_metric_readRequestCount" : 1849882,
{code}
However, the region metrics for this table {{tsdb-tree}} is:
{code}
"Namespace_default_table_tsdb-tree_region_8cbc7ef45755eed3206858da0d8caa3e_metric_readRequestCount"
: 0,
{code}
[~aliciashu] can you please check what is going on. Thanks.
> Add Per-Table metrics back
> --
>
> Key: HBASE-15518
> URL: https://issues.apache.org/jira/browse/HBASE-15518
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Alicia Ying Shu
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-15518-v1.patch, HBASE-15518.patch
>
>
> We used to have per-table metrics, but it was removed in some restructuring.
> We have per-region metrics, and per-regionserver metrics, but nothing in
> between.
> For majority of users, per-region is too granular, they are mostly interested
> in table level aggregates. This is especially useful in multi-tenant cases
> where a table's disk usage, number of requests, etc can be made much more
> visible.
> In this jira, we'll add the basic infrastructure to add a single (or a few)
> per-table metrics. Than we can improve on that by adding remaining metrics
> from the region server level.
> The plan is to NOT aggregate per-table metrics at master for now. Just
> aggregation of per-region metrics at the per-table level for every
> regionserver.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230723#comment-15230723 ] Alicia Ying Shu commented on HBASE-15518: - The test hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures passed on my local box. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230339#comment-15230339
]
Hadoop QA commented on HBASE-15518:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 46s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 2s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 13s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 47s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 35s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 48s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s {color} | {color:green} hbase-hadoop-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} hbase-hadoop-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} hbase-hadoop2-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} hbase-hadoop2-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged -
3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged -
3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
4s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 58s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 14s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:gre
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229099#comment-15229099
]
Hadoop QA commented on HBASE-15518:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 31s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 44s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
4s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
11s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 9s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 46s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 39s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 39s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 43s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 43s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s {color} | {color:green} hbase-hadoop-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} hbase-hadoop-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} hbase-hadoop2-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} hbase-hadoop2-compat: patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged -
3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged -
3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
4s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 11 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 3s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 13s
{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed = 1
total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 12s
{color} | {color:red} hbase-server generated 1 new + 0 unchange
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228561#comment-15228561 ] Alicia Ying Shu commented on HBASE-15518: - [~enis] Thanks for the review. Uploaded a revised patch. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-15518-v1.patch, HBASE-15518.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225559#comment-15225559
]
Enis Soztutar commented on HBASE-15518:
---
Thanks [~aliciashu] for the patch. Couple of comments:
- Please check the above hadoopqa warnings, and address those.
- Having both {{num}} and {{Count}} in the metric name does not make sense.
Lets use {{readRequestCount}} / {{writeRequestCount}} to be consistent with
RS-level metric names. Same thing for total request count.
{code}+ String NUM_READ_REQUESTS_COUNT = "numReadRequestsCount";
- Move this class inside the MetricsTableWrapperAggregateImpl. No need to be
top level. It should be declared private.
{code}
+public class MetricsTableValues {
{code}
- Instead of using the table aggregate wrapper directly in the regionserver,
lets do a wrapper like the MetricsTable to hold the aggregate source and
aggregate wrapper. We can instantiate that in the regionserver level.
{code}
+ MetricsTableWrapperAggregate metricsTableWrapperAgg;
{code}
- You don't need this ConcurrentHashMap for metricsTableMap. It should be a
locally allocated map inside the method that uses it.
{code}
+ private ConcurrentHashMap metricsTableMap =
new ConcurrentHashMap<>();
{code}
- otherwise looks good.
- Let me test this patch with my ycsb setup.
> Add Per-Table metrics back
> --
>
> Key: HBASE-15518
> URL: https://issues.apache.org/jira/browse/HBASE-15518
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Alicia Ying Shu
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-15518.patch
>
>
> We used to have per-table metrics, but it was removed in some restructuring.
> We have per-region metrics, and per-regionserver metrics, but nothing in
> between.
> For majority of users, per-region is too granular, they are mostly interested
> in table level aggregates. This is especially useful in multi-tenant cases
> where a table's disk usage, number of requests, etc can be made much more
> visible.
> In this jira, we'll add the basic infrastructure to add a single (or a few)
> per-table metrics. Than we can improve on that by adding remaining metrics
> from the region server level.
> The plan is to NOT aggregate per-table metrics at master for now. Just
> aggregation of per-region metrics at the per-table level for every
> regionserver.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[
https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225472#comment-15225472
]
Hadoop QA commented on HBASE-15518:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 24s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 32s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 43s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
7s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 9s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 24s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 46s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 24s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 26s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 26s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 40s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 26s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 40s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 25s
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 25s
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 25s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 25s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 16s
{color} | {color:red} hbase-hadoop-compat: patch generated 3 new + 3 unchanged
- 0 fixed = 6 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s
{color} | {color:red} hbase-hadoop-compat: patch generated 3 new + 3 unchanged
- 0 fixed = 6 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s
{color} | {color:red} hbase-hadoop2-compat: patch generated 3 new + 3 unchanged
- 0 fixed = 6 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s
{color} | {color:red} hbase-hadoop2-compat: patch generated 3 new + 3 unchanged
- 0 fixed = 6 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s
{color} | {color:red} hbase-server: patch generated 3 new + 3 unchanged - 0
fixed = 6 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s
{color} | {color:red} hbase-server: patch generated 3 new + 3 unchanged - 0
fixed = 6 total (was 3) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {c
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225368#comment-15225368 ] Alicia Ying Shu commented on HBASE-15518: - Uploaded a patch for table level stats. It implemented the flow to get and publish the table level stats. Currently it includes three metrics to display besides the number of tables that are being tracked: numReadRequestsCount, numWriteRequestsCount and numTotalRequestsCount. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-15518.patch > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213351#comment-15213351 ] Andrew Purtell commented on HBASE-15518: There is also HBASE-11062 as a potential consumer. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207284#comment-15207284 ] Enis Soztutar commented on HBASE-15518: --- Per-region does not help unless there are already existing tools for doing aggregations at the table level from per-region level metrics. Per-table+per-regionserver however, is very easily aggregated with out-of-box tools like opentsdb, graphite, etc so that you can get a per-table aggregated view across the cluster. And usually, per-region metrics is already disabled because of the very large number of metrics being generated versus, per table metrics is 10x-1000x less. I agree that we should be careful in making sure that the metrics collection or aggregation at the per-table level should not be in the hot path. Since we already have per-region metrics, simply aggregating them at the wrapper layer should be good enough that regular code path is not affected. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15518) Add Per-Table metrics back
[ https://issues.apache.org/jira/browse/HBASE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207035#comment-15207035 ] Elliott Clark commented on HBASE-15518: --- They were removed explicitly because they give very skewed numbers based on how many regions are on each region server. If one regionserver has 10 regions of a table and another has 5 then the numbers become almost nonsensical. You then need to normalize them per number of regions and you're back at a per region metrics. If a user is interested in per table across the whole cluster then aggregating the region metrics is the best way. If they are looking for a certain region server then not aggregating is the correct thing. On top of all that the other reason they were removed is because it caused a whole lot of contention for the debatable gains. Per region metrics are much less contented so adding them is lower cost. Per server metrics are contended so we should only add the minimum set of metrics needed there. > Add Per-Table metrics back > -- > > Key: HBASE-15518 > URL: https://issues.apache.org/jira/browse/HBASE-15518 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Alicia Ying Shu > Fix For: 2.0.0, 1.4.0 > > > We used to have per-table metrics, but it was removed in some restructuring. > We have per-region metrics, and per-regionserver metrics, but nothing in > between. > For majority of users, per-region is too granular, they are mostly interested > in table level aggregates. This is especially useful in multi-tenant cases > where a table's disk usage, number of requests, etc can be made much more > visible. > In this jira, we'll add the basic infrastructure to add a single (or a few) > per-table metrics. Than we can improve on that by adding remaining metrics > from the region server level. > The plan is to NOT aggregate per-table metrics at master for now. Just > aggregation of per-region metrics at the per-table level for every > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
