[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347345#comment-15347345 ] Hudson commented on HBASE-15725: SUCCESS: Integrated in HBase-1.4 #241 (See [https://builds.apache.org/job/HBase-1.4/241/]) HBASE-15725 make_patch.sh should add the branch name when -b is passed. (eclark: rev c7e5672d4d3d6a44ac01c0a56e122a58994846de) * dev-support/make_patch.sh HBASE-15725 make_patch.sh should add the branch name when -b is passed. (eclark: rev b6e2bc5ad127c68dd6c933eba273a02f0455c8c1) * dev-support/make_patch.sh > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch, > HBASE-15725.v6-addendum.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287453#comment-15287453 ] Hudson commented on HBASE-15725: FAILURE: Integrated in HBase-Trunk_matrix #924 (See [https://builds.apache.org/job/HBase-Trunk_matrix/924/]) HBASE-15725 make_patch.sh should add the branch name when -b is passed. (eclark: rev c12eaa5cc48a616518a11278586083f32aa3f60c) * dev-support/make_patch.sh > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch, > HBASE-15725.v6-addendum.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285137#comment-15285137 ] Elliott Clark commented on HBASE-15725: --- Trying it out in HBASE-15826 I'll commit if that run pick up all the information correctly. > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch, > HBASE-15725.v6-addendum.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285101#comment-15285101 ] Hadoop QA commented on HBASE-15725: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 3s {color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 2s {color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 11m 9s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 38s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12804230/HBASE-15725.v6-addendum.patch | | JIRA Issue | HBASE-15725 | | Optional Tests | asflicense shellcheck shelldocs | | uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh | | git revision | master / c3223a5 | | shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider upgrading.) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1908/console | | Powered by | Apache Yetus 0.2.1 http://yetus.apache.org | This message was automatically generated. > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch, > HBASE-15725.v6-addendum.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285094#comment-15285094 ] Sean Busbey commented on HBASE-15725: - sounds like a variant YETUS-274, maybe? If doing "." separated parts for branches with "-" in the name works, then +1 from me. > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch, > HBASE-15725.v6-addendum.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283402#comment-15283402 ] Hudson commented on HBASE-15725: FAILURE: Integrated in HBase-Trunk_matrix #918 (See [https://builds.apache.org/job/HBase-Trunk_matrix/918/]) HBASE-15725 make_patch.sh should add the branch name when -b is passed. (eclark: rev 0e281e1929fbd8332001ef5a2a44091d790a67bb) * dev-support/make_patch.sh > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283112#comment-15283112 ] Sean Busbey commented on HBASE-15725: - +1 (curious why precommit did pick up v4, but this hasn't been through shellcheck before so I'm fine not waiting.) > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283114#comment-15283114 ] Sean Busbey commented on HBASE-15725: - speak of Yetus and it shall appear. ;) > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283107#comment-15283107 ] Hadoop QA commented on HBASE-15725: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 4s {color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 1s {color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 11m 33s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 12m 4s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12803932/HBASE-15725-v5.patch | | JIRA Issue | HBASE-15725 | | Optional Tests | asflicense shellcheck shelldocs | | uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh | | git revision | master / b353e38 | | shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider upgrading.) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1886/console | | Powered by | Apache Yetus 0.2.1 http://yetus.apache.org | This message was automatically generated. > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283098#comment-15283098 ] Elliott Clark commented on HBASE-15725: --- [~stack] [~misty] or [~busbey] any thoughts on this one? Trying to get making a patch for a branch just as easy as for master. > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 2.0.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0 > > Attachments: HBASE-15725-v4.patch, HBASE-15725-v5.patch > > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15725) make_patch.sh should add the branch name when -b is passed.
[ https://issues.apache.org/jira/browse/HBASE-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281804#comment-15281804 ] Elliott Clark commented on HBASE-15725: --- Picking this up. > make_patch.sh should add the branch name when -b is passed. > --- > > Key: HBASE-15725 > URL: https://issues.apache.org/jira/browse/HBASE-15725 > Project: HBase > Issue Type: Bug >Reporter: Elliott Clark >Assignee: Elliott Clark > > When using something other than master as the base branch we should default > to adding the branch name to the patch file name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)