[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304434#comment-15304434
]
Hudson commented on HBASE-15740:
FAILURE: Integrated in HBase-0.98-matrix #348 (See
[https://builds.apache.org/job/HBase-0.98-matrix/348/])
HBASE-15740 Replication source.shippedKBs metric is undercounting (apurtell:
rev 1822bd3ec57d40a2cb682500a8a5cff5df9c9e08)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
*
hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
*
hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
*
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0, 0.98.20
>
> Attachments: HBASE-15740-0.98.patch, hbase-15740_v1.patch,
> hbase-15740_v2.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304384#comment-15304384
]
Hudson commented on HBASE-15740:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1220 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1220/])
HBASE-15740 Replication source.shippedKBs metric is undercounting (apurtell:
rev 1822bd3ec57d40a2cb682500a8a5cff5df9c9e08)
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
*
hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
*
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
*
hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0, 0.98.20
>
> Attachments: HBASE-15740-0.98.patch, hbase-15740_v1.patch,
> hbase-15740_v2.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277482#comment-15277482
]
Hudson commented on HBASE-15740:
FAILURE: Integrated in HBase-Trunk_matrix #909 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/909/])
HBASE-15740 Replication source.shippedKBs metric is undercounting (enis: rev
b75b2268046d8b3e872060505260289d8ee43dd5)
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
*
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: hbase-15740_v1.patch, hbase-15740_v2.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277344#comment-15277344
]
Hudson commented on HBASE-15740:
SUCCESS: Integrated in HBase-1.4 #144 (See
[https://builds.apache.org/job/HBase-1.4/144/])
HBASE-15740 Replication source.shippedKBs metric is undercounting (enis: rev
d07d31611395ae4e0befc04a0b8cc67adcacacb9)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
*
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: hbase-15740_v1.patch, hbase-15740_v2.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277285#comment-15277285
]
Hudson commented on HBASE-15740:
SUCCESS: Integrated in HBase-1.3 #692 (See
[https://builds.apache.org/job/HBase-1.3/692/])
HBASE-15740 Replication source.shippedKBs metric is undercounting (enis: rev
4c214b50c6efae02c0eb054b5ddf514469776a9f)
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
*
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: hbase-15740_v1.patch, hbase-15740_v2.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276850#comment-15276850
]
Hudson commented on HBASE-15740:
SUCCESS: Integrated in HBase-1.3-IT #655 (See
[https://builds.apache.org/job/HBase-1.3-IT/655/])
HBASE-15740 Replication source.shippedKBs metric is undercounting (enis: rev
4c214b50c6efae02c0eb054b5ddf514469776a9f)
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
*
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: hbase-15740_v1.patch, hbase-15740_v2.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276211#comment-15276211
]
Heng Chen commented on HBASE-15740:
---
LGTM. +1
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: hbase-15740_v1.patch, hbase-15740_v2.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269949#comment-15269949
]
Hadoop QA commented on HBASE-15740:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 15s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
41s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 58s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 58s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 6s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 20s
{color} | {color:red} hbase-hadoop-compat: patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s
{color} | {color:red} hbase-hadoop2-compat: patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s
{color} | {color:red} hbase-server: patch generated 1 new + 0 unchanged - 0
fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 43s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.1 2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 45s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 18s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 17s
{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s
{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 139m 48s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265104#comment-15265104
]
Hadoop QA commented on HBASE-15740:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
33s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 45s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
37s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 9s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 41s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 41s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 18s
{color} | {color:red} hbase-hadoop-compat: patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s
{color} | {color:red} hbase-hadoop2-compat: patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s
{color} | {color:red} hbase-server: patch generated 1 new + 0 unchanged - 0
fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 23s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.1 2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 4s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 17s
{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 25s
{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 138m 51s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{col
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265019#comment-15265019
]
Heng Chen commented on HBASE-15740:
---
{code}
- @Override public void incrShippedKBs(long size) {
+ @Override public void incrShippedBytes(long size) {
shippedKBsCounter.incr(size);
+MetricsReplicationGlobalSourceSource
+ .incrementKBsCounter(shippedBytesCounter, shippedKBsCounter);
}
{code}
shippedKBsCounter -> shippedBytesCounter ?
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: hbase-15740_v1.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15740) Replication source.shippedKBs metric is undercounting because it is in KB
[
https://issues.apache.org/jira/browse/HBASE-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264976#comment-15264976
]
Enis Soztutar commented on HBASE-15740:
---
Also simple math reveals that a long can carry 8191 PB of data counted in
bytes. There is literally no reason to count / emit any metric in MBs or KBs.
> Replication source.shippedKBs metric is undercounting because it is in KB
> -
>
> Key: HBASE-15740
> URL: https://issues.apache.org/jira/browse/HBASE-15740
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: hbase-15740_v1.patch
>
>
> In a cluster where there is replication going on, I've noticed that this is
> always 0:
> {code}
> "source.shippedKBs" : 0,
> {code}
> Looking at the source reveals why:
> {code}
> metrics.shipBatch(currentNbOperations, currentSize / 1024,
> currentNbHFiles);
> {code}
> It is always undercounting because we discard remaining bytes after KB
> boundary. This is specially a problem when we are always shipping small
> batches <1KB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
