[jira] [Commented] (HBASE-15930) Make IntegrationTestReplication's waitForReplication() smarter
[ https://issues.apache.org/jira/browse/HBASE-15930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023197#comment-16023197 ] Jonathan Hsieh commented on HBASE-15930: Did you test the pre-setup case? line 190 seems backwards. -- shouldn't it be 'if (!tableCFs.getcolumnFamilyMap(0.isEmpty()) ' ? {code} 187 Admin admin = source.getConnection().getAdmin(); 188 for (TableCFs tableCFs : admin.listReplicatedTableCFs()) { 189 if (tableCFs.getTable().equals(expected)) { 190 if (tableCFs.getColumnFamilyMap().isEmpty()) { 191 // Replicating at least one CF is good enough 192 return; 193 } 194 } 195 } 196 throw new RuntimeException("Aborting test: replication not configured and we were instructed to not set it up."); 197 } finally { {code} > Make IntegrationTestReplication's waitForReplication() smarter > -- > > Key: HBASE-15930 > URL: https://issues.apache.org/jira/browse/HBASE-15930 > Project: HBase > Issue Type: Improvement > Components: integration tests >Reporter: Dima Spivak >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-15930.patch > > > {{IntegrationTestReplication}} is a great test, but can improved by changing > how we handle waiting between generation of the linked list on the source > cluster and verifying the linked list on the destination cluster. [Even the > code suggests this should be > done|https://github.com/apache/hbase/blob/master/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestReplication.java#L251-252], > so I'd like to take it on. [~mbertozzi] and [~busbey] have both suggested a > simple solution wherein we write a row into each region on the source cluster > after the linked list generation and then assume replication has gone through > once these rows are detected on the destination cluster. > Since you lads at Facebook are some of the heaviest users, [~eclark], would > you prefer I maintain the API and add a new command line option (say {{\-c | > \-\-check-replication}}) that would run before any {{--generateVerifyGap}} > sleep is carried out as it is now? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15930) Make IntegrationTestReplication's waitForReplication() smarter
[ https://issues.apache.org/jira/browse/HBASE-15930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019989#comment-16019989 ] Hadoop QA commented on HBASE-15930: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 31s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 6s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 35s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 0s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 38s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 32s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 67m 40s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 0s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s {color} | {color:green} hbase-it in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 81m 22s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12869291/HBASE-15930.patch | | JIRA Issue | HBASE-15930 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 63be2f7d4ced 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / 23ea2c3 | | Default Java | 1.8.0_131 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6876/testReport/ | | modules | C: hbase-it U: hbase-it | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6876/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Make IntegrationTestReplication's waitForReplication() smarter > -- > > Key: HBASE-15930 > URL: https://issues.apache.org/jira/browse/HBASE-15930 > Project: HBase > Issue Type: Improvement > Components: integration tests >Reporter: Dima Spivak >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-15930.patch > > > {{IntegrationTestReplication}} is a great
[jira] [Commented] (HBASE-15930) Make IntegrationTestReplication's waitForReplication() smarter
[ https://issues.apache.org/jira/browse/HBASE-15930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008827#comment-16008827 ] Mike Drob commented on HBASE-15930: --- Hey [~dimaspivak] - I recently ran into issues with this test and was looking at making some improvements. Do you mind if I take this on while I'm in the area? > Make IntegrationTestReplication's waitForReplication() smarter > -- > > Key: HBASE-15930 > URL: https://issues.apache.org/jira/browse/HBASE-15930 > Project: HBase > Issue Type: Improvement > Components: integration tests >Reporter: Dima Spivak >Assignee: Dima Spivak > Fix For: 2.0.0 > > > {{IntegrationTestReplication}} is a great test, but can improved by changing > how we handle waiting between generation of the linked list on the source > cluster and verifying the linked list on the destination cluster. [Even the > code suggests this should be > done|https://github.com/apache/hbase/blob/master/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestReplication.java#L251-252], > so I'd like to take it on. [~mbertozzi] and [~busbey] have both suggested a > simple solution wherein we write a row into each region on the source cluster > after the linked list generation and then assume replication has gone through > once these rows are detected on the destination cluster. > Since you lads at Facebook are some of the heaviest users, [~eclark], would > you prefer I maintain the API and add a new command line option (say {{\-c | > \-\-check-replication}}) that would run before any {{--generateVerifyGap}} > sleep is carried out as it is now? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15930) Make IntegrationTestReplication's waitForReplication() smarter
[ https://issues.apache.org/jira/browse/HBASE-15930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310634#comment-15310634 ] Elliott Clark commented on HBASE-15930: --- It's a test. I'm totally ok with any breaking change as long as the benefits are there. So I don't think that we need to worry about backward compat. Just do whatever you think is the best api and I'll change our test rig when it goes in. > Make IntegrationTestReplication's waitForReplication() smarter > -- > > Key: HBASE-15930 > URL: https://issues.apache.org/jira/browse/HBASE-15930 > Project: HBase > Issue Type: Improvement > Components: integration tests >Reporter: Dima Spivak >Assignee: Dima Spivak > > {{IntegrationTestReplication}} is a great test, but can improved by changing > how we handle waiting between generation of the linked list on the source > cluster and verifying the linked list on the destination cluster. [Even the > code suggests this should be > done|https://github.com/apache/hbase/blob/master/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestReplication.java#L251-252], > so I'd like to take it on. [~mbertozzi] and [~busbey] have both suggested a > simple solution wherein we write a row into each region on the source cluster > after the linked list generation and then assume replication has gone through > once these rows are detected on the destination cluster. > Since you lads at Facebook are some of the heaviest users, [~eclark], would > you prefer I maintain the API and add a new command line option (say {{\-c | > \-\-check-replication}}) that would run before any {{--generateVerifyGap}} > sleep is carried out as it is now? -- This message was sent by Atlassian JIRA (v6.3.4#6332)