[jira] [Commented] (HBASE-15945) Patch for Cell
[ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410365#comment-15410365 ] Enis Soztutar commented on HBASE-15945: --- Thanks, should have git pull'ed first. > Patch for Cell > -- > > Key: HBASE-15945 > URL: https://issues.apache.org/jira/browse/HBASE-15945 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-15945-HBASE-14850.v2.patch, > HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, > HBASE-15945.HBASE-14850.v1.patch, HBASE-15945.HBASE-14850.v5.patch, > HBASE-15945.HBASE-14850.v6.patch > > > This patch contains an implementation of Key Value, Bytes and Cell modeled on > the lines of Java implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15945) Patch for Cell
[ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410360#comment-15410360 ] Elliott Clark commented on HBASE-15945: --- https://github.com/apache/hbase/commit/fa3ab420d19bba853d96576176257b5c12f1a48f Isn't that it ? It appears to be there on my git checkout ? > Patch for Cell > -- > > Key: HBASE-15945 > URL: https://issues.apache.org/jira/browse/HBASE-15945 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-15945-HBASE-14850.v2.patch, > HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, > HBASE-15945.HBASE-14850.v1.patch, HBASE-15945.HBASE-14850.v5.patch, > HBASE-15945.HBASE-14850.v6.patch > > > This patch contains an implementation of Key Value, Bytes and Cell modeled on > the lines of Java implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15945) Patch for Cell
[ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410358#comment-15410358 ] Enis Soztutar commented on HBASE-15945: --- I thought [~eclark] pushed it, but it does not seem to be there in branch HBASE-14850. > Patch for Cell > -- > > Key: HBASE-15945 > URL: https://issues.apache.org/jira/browse/HBASE-15945 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-15945-HBASE-14850.v2.patch, > HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, > HBASE-15945.HBASE-14850.v1.patch, HBASE-15945.HBASE-14850.v5.patch, > HBASE-15945.HBASE-14850.v6.patch > > > This patch contains an implementation of Key Value, Bytes and Cell modeled on > the lines of Java implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15945) Patch for Cell
[ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408859#comment-15408859 ] Xiang Li commented on HBASE-15945: -- Hi all, is this JIRA committed？I was not able to find it in git log. > Patch for Cell > -- > > Key: HBASE-15945 > URL: https://issues.apache.org/jira/browse/HBASE-15945 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-15945-HBASE-14850.v2.patch, > HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, > HBASE-15945.HBASE-14850.v1.patch, HBASE-15945.HBASE-14850.v5.patch, > HBASE-15945.HBASE-14850.v6.patch > > > This patch contains an implementation of Key Value, Bytes and Cell modeled on > the lines of Java implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15945) Patch for Cell and CellImpl
[ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362779#comment-15362779 ] Elliott Clark commented on HBASE-15945: --- +1 lgtm > Patch for Cell and CellImpl > --- > > Key: HBASE-15945 > URL: https://issues.apache.org/jira/browse/HBASE-15945 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-15945-HBASE-14850.v2.patch, > HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, > HBASE-15945.HBASE-14850.v1.patch, HBASE-15945.HBASE-14850.v5.patch, > HBASE-15945.HBASE-14850.v6.patch > > > This patch contains an implementation of Key Value, Bytes and Cell modeled on > the lines of Java implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15945) Patch for Cell and CellImpl
[ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361173#comment-15361173 ] Sudeep Sunthankar commented on HBASE-15945: --- Thanks for the feedback Elliott. We have uploaded a patch based on your inputs. > Patch for Cell and CellImpl > --- > > Key: HBASE-15945 > URL: https://issues.apache.org/jira/browse/HBASE-15945 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-15945-HBASE-14850.v2.patch, > HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, > HBASE-15945.HBASE-14850.v1.patch, HBASE-15945.HBASE-14850.v5.patch, > HBASE-15945.HBASE-14850.v6.patch > > > This patch contains an implementation of Key Value, Bytes and Cell modeled on > the lines of Java implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15945) Patch for Cell and CellImpl
[ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360397#comment-15360397 ] Elliott Clark commented on HBASE-15945: --- No need for the interface and the implementation because of how hard getting c++ abi compatibility is. I'd prefer a patch that hooks everything up, rather than just adding orphaned classes. > Patch for Cell and CellImpl > --- > > Key: HBASE-15945 > URL: https://issues.apache.org/jira/browse/HBASE-15945 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-15945-HBASE-14850.v2.patch, > HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, > HBASE-15945.HBASE-14850.v1.patch, HBASE-15945.HBASE-14850.v5.patch > > > This patch contains an implementation of Key Value, Bytes and Cell modeled on > the lines of Java implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15945) Patch for Cell and CellImpl
[ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359864#comment-15359864 ] Enis Soztutar commented on HBASE-15945: --- +1. [~eclark] wdyt? > Patch for Cell and CellImpl > --- > > Key: HBASE-15945 > URL: https://issues.apache.org/jira/browse/HBASE-15945 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-15945-HBASE-14850.v2.patch, > HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, > HBASE-15945.HBASE-14850.v1.patch, HBASE-15945.HBASE-14850.v5.patch > > > This patch contains an implementation of Key Value, Bytes and Cell modeled on > the lines of Java implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
