[jira] [Commented] (HBASE-16198) Enhance backup history command
[ https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410281#comment-15410281 ] Ted Yu commented on HBASE-16198: Looks like TestBackupSystemTable#testBackupHistory() should be covered by other two tests. > Enhance backup history command > -- > > Key: HBASE-16198 > URL: https://issues.apache.org/jira/browse/HBASE-16198 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0 >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch, > HBASE-16198-v3.patch, HBASE-16198-v4.patch, HBASE-16198-v5.patch > > > We need history per table and ability to run command on a fully disabled > cluster (using info from backup file system only). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410240#comment-15410240
]
Ted Yu commented on HBASE-16198:
+ public void testBackupHistory() throws Exception {
There are 3 sub-tests with the same name:
TestBackupShowHistoryFromBackupDestination, TestBackupShowHistory and
TestBackupSystemTable
Is it possible to consolidate them ?
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch,
> HBASE-16198-v3.patch, HBASE-16198-v4.patch, HBASE-16198-v5.patch
>
>
> We need history per table and ability to run command on a fully disabled
> cluster (using info from backup file system only).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[ https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410201#comment-15410201 ] Vladimir Rodionov commented on HBASE-16198: --- Yes, you are right. > Enhance backup history command > -- > > Key: HBASE-16198 > URL: https://issues.apache.org/jira/browse/HBASE-16198 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0 >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch, > HBASE-16198-v3.patch, HBASE-16198-v4.patch > > > We need history per table and ability to run command on a fully disabled > cluster (using info from backup file system only). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410187#comment-15410187
]
Ted Yu commented on HBASE-16198:
{code}
+private Path getBackupRootPath() {
+ String value = cmdline.getOptionValue("t");
+ if (value == null) return null;
+ return new Path(value);
+}
+
+private TableName getTableName() {
+ String value = cmdline.getOptionValue("t");
{code}
I don't think backup root should be using the same option value as that of
table name.
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch,
> HBASE-16198-v3.patch, HBASE-16198-v4.patch
>
>
> We need history per table and ability to run command on a fully disabled
> cluster (using info from backup file system only).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410120#comment-15410120
]
Vladimir Rodionov commented on HBASE-16198:
---
{quote}
Is the above right ? "t" is for table name, right ?
{quote}
Yes. This is table name.
No changes to BackupManifest structure, only some code: new ctor and
toBackuInfo method
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch,
> HBASE-16198-v3.patch, HBASE-16198-v4.patch
>
>
> We need history per table and ability to run command on a fully disabled
> cluster (using info from backup file system only).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409869#comment-15409869
]
Ted Yu commented on HBASE-16198:
In patch v4, I still see:
{code}
+private Path getBackupRootPath() {
+ String value = cmdline.getOptionValue("t");
{code}
Is there any change in BackupManifest.java ?
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch,
> HBASE-16198-v3.patch, HBASE-16198-v4.patch
>
>
> We need history per table and ability to run command on a fully disabled
> cluster (using info from backup file system only).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408407#comment-15408407
]
Vladimir Rodionov commented on HBASE-16198:
---
{quote}
Is it possible to pass n into the above method so that fewer rows are retrieved
from backup table ?
{quote}
Currently, it is not possible. We have to load all history then filter it to
include particular table.
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch,
> HBASE-16198-v3.patch, HBASE-16198-v4.patch
>
>
> We need history per table and ability to run command on a fully disabled
> cluster (using info from backup file system only).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[ https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408133#comment-15408133 ] Vladimir Rodionov commented on HBASE-16198: --- Ted, this is going to be v4. Although this patch does not use hbase:backup table it still requires HBase cluster connection (Admin). > Enhance backup history command > -- > > Key: HBASE-16198 > URL: https://issues.apache.org/jira/browse/HBASE-16198 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0 >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch, > HBASE-16198-v3.patch > > > We need history per table and ability to run command on a fully disabled > cluster (using info from backup file system only). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408066#comment-15408066
]
Ted Yu commented on HBASE-16198:
{code}
+ private static final String HISTORY_CMD_USAGE = "Usage: hbase backup history
[-path BACKUP_ROOT] [-n N] [-t table]\n"
{code}
Wrap long line.
{code}
+private Path getBackupRootPath() {
+ String value = cmdline.getOptionValue("t");
{code}
Is the above right ? "t" is for table name, right ?
Is there any change in BackupManifest.java since it is moved to hbase-client
package.
{code}
+ public static List getHistory(Configuration conn, Path
backupRootPath) throws IOException {
{code}
Please name Configuration parameter conf (or similar).
{code}
+} else {
+ //TODO
+ return -1;
{code}
What's the plan for the above case ?
{code}
+ List history = table.getBackupHistoryForTable(name);
{code}
Is it possible to pass n into the above method so that fewer rows are retrieved
from backup table ?
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch,
> HBASE-16198-v3.patch
>
>
> We need history per table and ability to run command on a fully disabled
> cluster (using info from backup file system only).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383287#comment-15383287
]
Hadoop QA commented on HBASE-16198:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s {color}
| {color:red} HBASE-16198 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.2.1/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12818673/HBASE-16198-v2.patch |
| JIRA Issue | HBASE-16198 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/2671/console |
| Powered by | Apache Yetus 0.2.1 http://yetus.apache.org |
This message was automatically generated.
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch
>
>
> We need history per table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377623#comment-15377623
]
Ted Yu commented on HBASE-16198:
{code}
415 return TableName.valueOf(value);
416 } catch (Exception e){
{code}
Catching IllegalArgumentException should be enough.
For BackupAdmin.java :
{code}
111* @param naem - table's name
{code}
naem: typo
{code}
146 List history = table.getBackupHistory();
{code}
Can variant of getBackupHistory() be added which takes TableName as parameter ?
This would limit the amount of data retrieved.
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch
>
>
> We need history per table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374280#comment-15374280
]
Hadoop QA commented on HBASE-16198:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s {color}
| {color:red} HBASE-16198 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.2.1/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12817074/HBASE-16198-v1.patch |
| JIRA Issue | HBASE-16198 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/2621/console |
| Powered by | Apache Yetus 0.2.1 http://yetus.apache.org |
This message was automatically generated.
> Enhance backup history command
> --
>
> Key: HBASE-16198
> URL: https://issues.apache.org/jira/browse/HBASE-16198
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-16198-v1.patch
>
>
> We need history per table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16198) Enhance backup history command
[ https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371050#comment-15371050 ] Vladimir Rodionov commented on HBASE-16198: --- cc:[~tedyu] > Enhance backup history command > -- > > Key: HBASE-16198 > URL: https://issues.apache.org/jira/browse/HBASE-16198 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0 >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-16198-v1.patch > > > We need history per table. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
