[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392947#comment-15392947 ] Hudson commented on HBASE-16266: FAILURE: Integrated in HBase-1.1-JDK7 #1753 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1753/]) HBASE-16266 Do not throw ScannerTimeoutException when catch (zhangduo: rev 4e8ec680feb4981ff9991372136dc646eb0e4af2) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392876#comment-15392876 ] Hudson commented on HBASE-16266: FAILURE: Integrated in HBase-1.1-JDK8 #1839 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1839/]) HBASE-16266 Do not throw ScannerTimeoutException when catch (zhangduo: rev 4e8ec680feb4981ff9991372136dc646eb0e4af2) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392767#comment-15392767 ] Hudson commented on HBASE-16266: SUCCESS: Integrated in HBase-1.2-IT #562 (See [https://builds.apache.org/job/HBase-1.2-IT/562/]) HBASE-16266 Do not throw ScannerTimeoutException when catch (zhangduo: rev 53f7dfccf9980b061063ef01c24c5bbc1369bf6e) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392762#comment-15392762 ] Hudson commented on HBASE-16266: SUCCESS: Integrated in HBase-1.3-IT #764 (See [https://builds.apache.org/job/HBase-1.3-IT/764/]) HBASE-16266 Do not throw ScannerTimeoutException when catch (zhangduo: rev 36e99c04892bde5d8273146c7c445fea04a525cd) * hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392589#comment-15392589 ] Hudson commented on HBASE-16266: SUCCESS: Integrated in HBase-1.2 #680 (See [https://builds.apache.org/job/HBase-1.2/680/]) HBASE-16266 Do not throw ScannerTimeoutException when catch (zhangduo: rev 53f7dfccf9980b061063ef01c24c5bbc1369bf6e) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392529#comment-15392529 ] Hudson commented on HBASE-16266: FAILURE: Integrated in HBase-Trunk_matrix #1294 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1294/]) HBASE-16266 Do not throw ScannerTimeoutException when catch (zhangduo: rev 6dbce2a8cb3cf5a0a07b6c3f9825a99af03a6962) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392432#comment-15392432 ] Hudson commented on HBASE-16266: FAILURE: Integrated in HBase-1.3 #794 (See [https://builds.apache.org/job/HBase-1.3/794/]) HBASE-16266 Do not throw ScannerTimeoutException when catch (zhangduo: rev 36e99c04892bde5d8273146c7c445fea04a525cd) * hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392427#comment-15392427 ] Hudson commented on HBASE-16266: FAILURE: Integrated in HBase-1.4 #306 (See [https://builds.apache.org/job/HBase-1.4/306/]) HBASE-16266 Do not throw ScannerTimeoutException when catch (zhangduo: rev f35b2c45d4a87bf03d70d541fa105b82ddd3ac97) * hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392113#comment-15392113 ] stack commented on HBASE-16266: --- Thanks [~Apache9] (and thanks for the considered fix [~yangzhe1991]) > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.3, 1.1.7 > > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391238#comment-15391238 ] Duo Zhang commented on HBASE-16266: --- This is not a big change so let's finish it. Will commit if no objections till this evening. Thanks. > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 1.1.5, 1.2.2 >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390508#comment-15390508 ] Duo Zhang commented on HBASE-16266: --- Let's commit and resolve this issue? [~stack] Thanks. > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 1.1.5, 1.2.2 >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[
https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389464#comment-15389464
]
Phil Yang commented on HBASE-16266:
---
Thanks for reviewing.
{quote}
What is an example scenario that makes the below?
{quote}
At server if the scanner reaches size limit or time limit, partial result or
heartbeat will be responded to the client, then the client will send a new rpc
call until the client get at least a whole row and can return a Result to user.
So the total time of blocking on ResultScanner.next() depends on how many rpc
requests in loadCache() and may be longer than a single rpc timeout
> Do not throw ScannerTimeoutException when catch UnknownScannerException
> ---
>
> Key: HBASE-16266
> URL: https://issues.apache.org/jira/browse/HBASE-16266
> Project: HBase
> Issue Type: Improvement
> Components: Client, Scanners
>Affects Versions: 1.1.5, 1.2.2
>Reporter: Phil Yang
>Assignee: Phil Yang
> Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch,
> HBASE-16266-v3.patch
>
>
> Now in scanner we have heartbeat to prevent timeout. The time blocked on
> ResultScanner.next() may much longer than scanner timeout. So it is no need
> any more to throw ScannerTimeoutException when server throws
> UnknownScannerException, we can just reset the scanner like
> NotServingRegionException
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389448#comment-15389448 ] stack commented on HBASE-16266: --- Patch looks nice [~yangzhe1991] What is an example scenario that makes the below? bq. The time blocked on ResultScanner.next() may much longer than scanner timeout. Thanks (could put it in release note -- this look likes a nice fix) > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 1.1.5, 1.2.2 >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: HBASE-16266-v1.patch, HBASE-16266-v2.patch, > HBASE-16266-v3.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[
https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389009#comment-15389009
]
Hadoop QA commented on HBASE-16266:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 22s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
59s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
4s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 10s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 40s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 59s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 97m 11s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 148m 21s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.security.token.TestGenerateDelegationToken |
| | hadoop.hbase.client.TestScannerTimeout |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12819551/HBASE-16266-v2.patch |
| JIRA Issue | HBASE-16266 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388842#comment-15388842 ] Duo Zhang commented on HBASE-16266: --- Add a UT to verify that the modification works? > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 1.1.5, 1.2.2 >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: HBASE-16266-v1.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[ https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387512#comment-15387512 ] Phil Yang commented on HBASE-16266: --- The patch can be applied to all branches (1.1+). Thanks > Do not throw ScannerTimeoutException when catch UnknownScannerException > --- > > Key: HBASE-16266 > URL: https://issues.apache.org/jira/browse/HBASE-16266 > Project: HBase > Issue Type: Improvement > Components: Client, Scanners >Affects Versions: 1.1.5, 1.2.2 >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: HBASE-16266-v1.patch > > > Now in scanner we have heartbeat to prevent timeout. The time blocked on > ResultScanner.next() may much longer than scanner timeout. So it is no need > any more to throw ScannerTimeoutException when server throws > UnknownScannerException, we can just reset the scanner like > NotServingRegionException -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16266) Do not throw ScannerTimeoutException when catch UnknownScannerException
[
https://issues.apache.org/jira/browse/HBASE-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387501#comment-15387501
]
Hadoop QA commented on HBASE-16266:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
13s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 3s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 28s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 59s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 3s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 53s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12819294/HBASE-16266-v1.patch |
| JIRA Issue | HBASE-16266 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / ce657d5 |
| Default Java | 1.7.0_80 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
