[jira] [Commented] (HBASE-16356) REST API scanner: row prefix filter and custom filter parameter are mutually exclusive
[
https://issues.apache.org/jira/browse/HBASE-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002806#comment-16002806
]
Ben Watson commented on HBASE-16356:
Is there a process I need to follow to get this progressed?
> REST API scanner: row prefix filter and custom filter parameter are mutually
> exclusive
> --
>
> Key: HBASE-16356
> URL: https://issues.apache.org/jira/browse/HBASE-16356
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 1.1.2
> Environment: Not environment specific (tested on HDP 2.4.2)
>Reporter: Bjorn Olsen
>Assignee: Ben Watson
>Priority: Minor
> Attachments: TableResource-HBASE-16356.patch
>
>
> A user can optionally specify a row PrefixFilter, or a list of custom
> filters, to the REST API scanner.
> Prefix filter example:
> /123*?startrow=0=9
> Custom filters example:
> /*?startrow=0=9=RowFilter(=,'substring:456)
> This works when specified separately, like above.
> However, specifying both a prefix filter and a list of custom filters causes
> the API to ignore the prefix filter.
> Example using both parameters:
> /123*?startrow=0=9=RowFilter(=,'substring:456)
> It appears that code in the TableResource.getScanResource function is causing
> this issue as follows:
> (see
> https://hbase.apache.org/devapidocs/src-html/org/apache/hadoop/hbase/rest/TableResource.html#line.196
> )
> if (filterList != null) {
> tableScan.setFilter(filterList); /*comes from custom filters parameter*/
> } else if (filter != null) {
> tableScan.setFilter(filter);
> /*comes from row prefix parameter*/
> }
> This should probably be changed to use a single filterList for both
> parameters. The prefix filter can be "Popped" onto the filter list and then
> these parameters will work even when both are specified.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-16356) REST API scanner: row prefix filter and custom filter parameter are mutually exclusive
[
https://issues.apache.org/jira/browse/HBASE-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940112#comment-15940112
]
Hadoop QA commented on HBASE-16356:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
16s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 29s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 51s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 14s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 32s
{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 54s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12860313/TableResource-HBASE-16356.patch
|
| JIRA Issue | HBASE-16356 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 0e1747c26969 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f1c1f25 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/6211/testReport/ |
| modules | C: hbase-client hbase-rest U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/6211/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> REST API scanner: row prefix filter and custom
[jira] [Commented] (HBASE-16356) REST API scanner: row prefix filter and custom filter parameter are mutually exclusive
[
https://issues.apache.org/jira/browse/HBASE-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930299#comment-15930299
]
Ben Watson commented on HBASE-16356:
I have a patch for this ticket. I presume I need to be added as the Assignee to
be able to submit it, so please could someone add me?
> REST API scanner: row prefix filter and custom filter parameter are mutually
> exclusive
> --
>
> Key: HBASE-16356
> URL: https://issues.apache.org/jira/browse/HBASE-16356
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 1.1.2
> Environment: Not environment specific (tested on HDP 2.4.2)
>Reporter: Bjorn Olsen
>Priority: Minor
>
> A user can optionally specify a row PrefixFilter, or a list of custom
> filters, to the REST API scanner.
> Prefix filter example:
> /123*?startrow=0=9
> Custom filters example:
> /*?startrow=0=9=RowFilter(=,'substring:456)
> This works when specified separately, like above.
> However, specifying both a prefix filter and a list of custom filters causes
> the API to ignore the prefix filter.
> Example using both parameters:
> /123*?startrow=0=9=RowFilter(=,'substring:456)
> It appears that code in the TableResource.getScanResource function is causing
> this issue as follows:
> (see
> https://hbase.apache.org/devapidocs/src-html/org/apache/hadoop/hbase/rest/TableResource.html#line.196
> )
> if (filterList != null) {
> tableScan.setFilter(filterList); /*comes from custom filters parameter*/
> } else if (filter != null) {
> tableScan.setFilter(filter);
> /*comes from row prefix parameter*/
> }
> This should probably be changed to use a single filterList for both
> parameters. The prefix filter can be "Popped" onto the filter list and then
> these parameters will work even when both are specified.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
