[jira] [Commented] (HBASE-16620) Command-line tool usability issues

2016-09-13 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487664#comment-15487664
 ] 

Ted Yu commented on HBASE-16620:


{code}
87+ " -t  table name. If specified, only backup 
images, which contain this table\n "
{code}
The above should start with '-t table' to match synopsis.
{code}
+if (tables == null) {
+  System.out.println("ERROR: Backup set '" + setName+ "' is either 
empty or does not exist");
{code}
System.err should be used when exit code is negative, right ?
{code}
+  } catch(IllegalArgumentException e) {
+System.out.println("ERROR: Illegal argument for backup root path: "+ 
value);
{code}
Add space between catch and (.
Please use System.err



> Command-line tool usability issues
> --
>
> Key: HBASE-16620
> URL: https://issues.apache.org/jira/browse/HBASE-16620
> Project: HBase
>  Issue Type: Bug
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Attachments: HBASE-16620-v1.patch
>
>
> We need to address issues found by [~saint@gmail.com]
> https://issues.apache.org/jira/browse/HBASE-7912?focusedCommentId=15484865&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15484865



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16620) Command-line tool usability issues

2016-09-13 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488581#comment-15488581
 ] 

Ted Yu commented on HBASE-16620:


Ran TestBackupShowHistory with patch v2 which passed.

> Command-line tool usability issues
> --
>
> Key: HBASE-16620
> URL: https://issues.apache.org/jira/browse/HBASE-16620
> Project: HBase
>  Issue Type: Bug
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Attachments: 16620-v2.patch, HBASE-16620-v1.patch
>
>
> We need to address issues found by [~saint@gmail.com]
> https://issues.apache.org/jira/browse/HBASE-7912?focusedCommentId=15484865&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15484865



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16620) Command-line tool usability issues

2016-09-13 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489305#comment-15489305
 ] 

Ted Yu commented on HBASE-16620:


Apart from adding tests in v3, any other change(s) ?

Thanks

> Command-line tool usability issues
> --
>
> Key: HBASE-16620
> URL: https://issues.apache.org/jira/browse/HBASE-16620
> Project: HBase
>  Issue Type: Bug
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Attachments: 16620-v2.patch, HBASE-16620-v1.patch, 
> HBASE-16620-v3.patch
>
>
> We need to address issues found by [~saint@gmail.com]
> https://issues.apache.org/jira/browse/HBASE-7912?focusedCommentId=15484865&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15484865



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16620) Command-line tool usability issues

2016-09-13 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489307#comment-15489307
 ] 

Ted Yu commented on HBASE-16620:


{code}
+  public void backupDriverDeleteHelp () throws Exception {
{code}
Please name the sub-test testBackupDriverDeleteHelp().

Same with other new tests.

> Command-line tool usability issues
> --
>
> Key: HBASE-16620
> URL: https://issues.apache.org/jira/browse/HBASE-16620
> Project: HBase
>  Issue Type: Bug
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Attachments: 16620-v2.patch, HBASE-16620-v1.patch, 
> HBASE-16620-v3.patch
>
>
> We need to address issues found by [~saint@gmail.com]
> https://issues.apache.org/jira/browse/HBASE-7912?focusedCommentId=15484865&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15484865



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)