[jira] [Commented] (HBASE-16640) TimeoutBlockingQueue#remove() should return whether the entry is removed
[ https://issues.apache.org/jira/browse/HBASE-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495492#comment-15495492 ] Hudson commented on HBASE-16640: FAILURE: Integrated in Jenkins build HBase-1.4 #417 (See [https://builds.apache.org/job/HBase-1.4/417/]) HBASE-16640 TimeoutBlockingQueue#remove() should return whether the (tedyu: rev 76a07602691fd5b63390b9dbde0a84672602c0be) * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/util/TimeoutBlockingQueue.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java * (edit) hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/util/TestTimeoutBlockingQueue.java > TimeoutBlockingQueue#remove() should return whether the entry is removed > > > Key: HBASE-16640 > URL: https://issues.apache.org/jira/browse/HBASE-16640 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: 16640.v1.txt, 16640.v2.txt > > > Currently return type of TimeoutBlockingQueue#remove() is void. > The caller has no way of knowing whether the entry is really removed. > This issue changes the return type to boolean. True is returned when entry is > removed, false is returned otherwise. > The change was proposed first in HBASE-16639. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16640) TimeoutBlockingQueue#remove() should return whether the entry is removed
[ https://issues.apache.org/jira/browse/HBASE-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495237#comment-15495237 ] Hudson commented on HBASE-16640: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1609 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1609/]) HBASE-16640 TimeoutBlockingQueue#remove() should return whether the (tedyu: rev e782d0bbdf265fddfcce5754cf2e2dbcc4ea) * (edit) hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/util/TestTimeoutBlockingQueue.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/util/TimeoutBlockingQueue.java > TimeoutBlockingQueue#remove() should return whether the entry is removed > > > Key: HBASE-16640 > URL: https://issues.apache.org/jira/browse/HBASE-16640 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: 16640.v1.txt, 16640.v2.txt > > > Currently return type of TimeoutBlockingQueue#remove() is void. > The caller has no way of knowing whether the entry is really removed. > This issue changes the return type to boolean. True is returned when entry is > removed, false is returned otherwise. > The change was proposed first in HBASE-16639. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16640) TimeoutBlockingQueue#remove() should return whether the entry is removed
[
https://issues.apache.org/jira/browse/HBASE-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494854#comment-15494854
]
Hadoop QA commented on HBASE-16640:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
48s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
8s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
22s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 26s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
6s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 55s
{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 7s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828754/16640.v2.txt |
| JIRA Issue | HBASE-16640 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 57e80be6be51 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 8c4b09d |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/3568/testReport/ |
| modules | C: hbase-procedure U: hbase-procedure |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3568/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> TimeoutBlockingQueue#remove() should return whether the entry is removed
>
>
> Key: HBASE-16640
> URL:
[jira] [Commented] (HBASE-16640) TimeoutBlockingQueue#remove() should return whether the entry is removed
[
https://issues.apache.org/jira/browse/HBASE-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494824#comment-15494824
]
Hadoop QA commented on HBASE-16640:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 3s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
19s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 10s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 15s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 55s
{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 1s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828747/16640.v1.txt |
| JIRA Issue | HBASE-16640 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux afcfc982ff42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 8c4b09d |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/3567/testReport/ |
| modules | C: hbase-procedure U: hbase-procedure |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3567/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> TimeoutBlockingQueue#remove() should return whether the entry is removed
>
>
> Key: HBASE-16640
> URL:
[jira] [Commented] (HBASE-16640) TimeoutBlockingQueue#remove() should return whether the entry is removed
[ https://issues.apache.org/jira/browse/HBASE-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494798#comment-15494798 ] Matteo Bertozzi commented on HBASE-16640: - +1 > TimeoutBlockingQueue#remove() should return whether the entry is removed > > > Key: HBASE-16640 > URL: https://issues.apache.org/jira/browse/HBASE-16640 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 16640.v1.txt, 16640.v2.txt > > > Currently return type of TimeoutBlockingQueue#remove() is void. > The caller has no way of knowing whether the entry is really removed. > This issue changes the return type to boolean. True is returned when entry is > removed, false is returned otherwise. > The change was proposed first in HBASE-16639. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16640) TimeoutBlockingQueue#remove() should return whether the entry is removed
[ https://issues.apache.org/jira/browse/HBASE-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494774#comment-15494774 ] Matteo Bertozzi commented on HBASE-16640: - can you add one more assert with assertFalse() for an object that does not exist? > TimeoutBlockingQueue#remove() should return whether the entry is removed > > > Key: HBASE-16640 > URL: https://issues.apache.org/jira/browse/HBASE-16640 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 16640.v1.txt > > > Currently return type of TimeoutBlockingQueue#remove() is void. > The caller has no way of knowing whether the entry is really removed. > This issue changes the return type to boolean. True is returned when entry is > removed, false is returned otherwise. > The change was proposed first in HBASE-16639. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
