[jira] [Commented] (HBASE-17250) For Get and scan in one case, checkFamily can be skipped in Region#getScanner
[
https://issues.apache.org/jira/browse/HBASE-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1667#comment-1667
]
Hadoop QA commented on HBASE-17250:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-17250 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-17250 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12844265/HBASE-17250-master-002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7891/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> For Get and scan in one case, checkFamily can be skipped in Region#getScanner
> -
>
> Key: HBASE-17250
> URL: https://issues.apache.org/jira/browse/HBASE-17250
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Attachments: HBASE-17250-master-001.patch,
> HBASE-17250-master-002.patch
>
>
> For get(), checkFamily is done in prepareGet(), so checkFamily can be skipped
> in Region#getScanner(). For scan(), if there is no Family configured in scan,
> the families are from table descriptor, so checkFamily in
> Region#getScanner(). can be skipped in this case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17250) For Get and scan in one case, checkFamily can be skipped in Region#getScanner
[ https://issues.apache.org/jira/browse/HBASE-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1654#comment-1654 ] Chia-Ping Tsai commented on HBASE-17250: Is this similar to HBASE-11034? > For Get and scan in one case, checkFamily can be skipped in Region#getScanner > - > > Key: HBASE-17250 > URL: https://issues.apache.org/jira/browse/HBASE-17250 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Attachments: HBASE-17250-master-001.patch, > HBASE-17250-master-002.patch > > > For get(), checkFamily is done in prepareGet(), so checkFamily can be skipped > in Region#getScanner(). For scan(), if there is no Family configured in scan, > the families are from table descriptor, so checkFamily in > Region#getScanner(). can be skipped in this case. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17250) For Get and scan in one case, checkFamily can be skipped in Region#getScanner
[ https://issues.apache.org/jira/browse/HBASE-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723826#comment-15723826 ] Matteo Bertozzi commented on HBASE-17250: - [~tedyu] I don't think scan.setAttribute() is the right place for it. from the patch looks like the "skipCheckFamily" is specific on how we implemented the get() code. we are using that getScanner() in both scan() and get() but in get we already checked the families before calling getScanner(). maybe an alternative to the flag, is that in both cases we check the families before doing anything. since in both cases we call the coprocessors with the scan or get object, and in theory we want to make sure the families are correct. in this case we check early and getScanner() will end up without any check. but this means that coprocessors that are using directly region.getScanner() should do validation.. so maybe the skipCheckFamily flag is safe for compatibility and clarity > For Get and scan in one case, checkFamily can be skipped in Region#getScanner > - > > Key: HBASE-17250 > URL: https://issues.apache.org/jira/browse/HBASE-17250 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Attachments: HBASE-17250-master-001.patch > > > For get(), checkFamily is done in prepareGet(), so checkFamily can be skipped > in Region#getScanner(). For scan(), if there is no Family configured in scan, > the families are from table descriptor, so checkFamily in > Region#getScanner(). can be skipped in this case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17250) For Get and scan in one case, checkFamily can be skipped in Region#getScanner
[ https://issues.apache.org/jira/browse/HBASE-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723799#comment-15723799 ] Ted Yu commented on HBASE-17250: How about passing the boolean through scan.setAttribute() ? > For Get and scan in one case, checkFamily can be skipped in Region#getScanner > - > > Key: HBASE-17250 > URL: https://issues.apache.org/jira/browse/HBASE-17250 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Attachments: HBASE-17250-master-001.patch > > > For get(), checkFamily is done in prepareGet(), so checkFamily can be skipped > in Region#getScanner(). For scan(), if there is no Family configured in scan, > the families are from table descriptor, so checkFamily in > Region#getScanner(). can be skipped in this case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
