[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020884#comment-16020884
]
Hudson commented on HBASE-17428:
FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #244 (See
[https://builds.apache.org/job/HBase-HBASE-14614/244/])
HBASE-17428 Implement informational RPCs for space quotas (elserj: rev
80a1f8fa2aec6687774ffeb03178efcdda2e136b)
* (edit) hbase-shell/src/test/ruby/hbase/quotas_test.rb
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/QuotaProtos.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* (edit)
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/RegionServerStatusProtos.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Admin.proto
* (edit) hbase-shell/src/main/ruby/shell.rb
* (add) hbase-shell/src/main/ruby/shell/commands/list_quota_snapshots.rb
* (add) hbase-shell/src/main/ruby/shell/commands/list_quota_violations.rb
* (edit)
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/AdminProtos.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/ActivePolicyEnforcement.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Quota.proto
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) hbase-shell/src/main/ruby/hbase/quotas.rb
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
* (edit)
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/MasterProtos.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* (add) hbase-shell/src/main/ruby/shell/commands/list_quota_table_sizes.rb
* (add) hbase-shell/src/test/ruby/hbase/quotas_test_no_cluster.rb
* (add)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/QuotaStatusCalls.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitMasterConnection.java
* (edit)
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/QuotaProtos.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Master.proto
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaStatusRPCs.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
> Expand on shell commands for detailed insight
> -
>
> Key: HBASE-17428
> URL: https://issues.apache.org/jira/browse/HBASE-17428
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: HBASE-16961
>
> Attachments: HBASE-17428.001.patch, HBASE-17428.002.patch,
> HBASE-17428.003.HBASE-16961.patch, HBASE-17428.004.HBASE-16961.patch
>
>
> Was talking over how to build some tests with [~romil.choksi], and what kind
> of information we capture and expose via some more shell commands.
> * Current SpaceQuotaSnapshots that the Master sees
> * Current SpaceQuotaSnapshots that a RS sees (or all RSs)
> * Current SpaceViolationPolicyEnforcements that a RS has enabled
> We can build out on the {{status}} command, with some options for different
> levels of detail, perhaps. Shouldn't be too tricky -- we have the info, just
> need to wire up java API, RPC, and shell command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020302#comment-16020302
]
Hudson commented on HBASE-17428:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3059 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3059/])
HBASE-17428 Implement informational RPCs for space quotas (elserj: rev
80a1f8fa2aec6687774ffeb03178efcdda2e136b)
* (edit) hbase-protocol-shaded/src/main/protobuf/Admin.proto
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Master.proto
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* (edit) hbase-shell/src/main/ruby/shell.rb
* (add) hbase-shell/src/main/ruby/shell/commands/list_quota_table_sizes.rb
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit)
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/QuotaProtos.java
* (edit) hbase-shell/src/main/ruby/hbase/quotas.rb
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitMasterConnection.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaStatusRPCs.java
* (add) hbase-shell/src/test/ruby/hbase/quotas_test_no_cluster.rb
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* (edit)
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/AdminProtos.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/QuotaProtos.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java
* (edit)
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/RegionServerStatusProtos.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/ActivePolicyEnforcement.java
* (add) hbase-shell/src/main/ruby/shell/commands/list_quota_snapshots.rb
* (edit)
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/MasterProtos.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Quota.proto
* (add) hbase-shell/src/main/ruby/shell/commands/list_quota_violations.rb
* (edit) hbase-shell/src/test/ruby/hbase/quotas_test.rb
* (add)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/QuotaStatusCalls.java
> Expand on shell commands for detailed insight
> -
>
> Key: HBASE-17428
> URL: https://issues.apache.org/jira/browse/HBASE-17428
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: HBASE-16961
>
> Attachments: HBASE-17428.001.patch, HBASE-17428.002.patch,
> HBASE-17428.003.HBASE-16961.patch, HBASE-17428.004.HBASE-16961.patch
>
>
> Was talking over how to build some tests with [~romil.choksi], and what kind
> of information we capture and expose via some more shell commands.
> * Current SpaceQuotaSnapshots that the Master sees
> * Current SpaceQuotaSnapshots that a RS sees (or all RSs)
> * Current SpaceViolationPolicyEnforcements that a RS has enabled
> We can build out on the {{status}} command, with some options for different
> levels of detail, perhaps. Shouldn't be too tricky -- we have the info, just
> need to wire up java API, RPC, and shell command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886623#comment-15886623
]
Josh Elser commented on HBASE-17428:
Test failures are due to a race condition on the HTTP port bind inside of
MiniDFSCluster (the NN's http server, specifically). Going to commit to the
{{HBASE-16961}} branch shortly.
> Expand on shell commands for detailed insight
> -
>
> Key: HBASE-17428
> URL: https://issues.apache.org/jira/browse/HBASE-17428
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: HBASE-16961
>
> Attachments: HBASE-17428.001.patch, HBASE-17428.002.patch,
> HBASE-17428.003.HBASE-16961.patch, HBASE-17428.004.HBASE-16961.patch
>
>
> Was talking over how to build some tests with [~romil.choksi], and what kind
> of information we capture and expose via some more shell commands.
> * Current SpaceQuotaSnapshots that the Master sees
> * Current SpaceQuotaSnapshots that a RS sees (or all RSs)
> * Current SpaceViolationPolicyEnforcements that a RS has enabled
> We can build out on the {{status}} command, with some options for different
> levels of detail, perhaps. Shouldn't be too tricky -- we have the info, just
> need to wire up java API, RPC, and shell command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885150#comment-15885150
]
Hadoop QA commented on HBASE-17428:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 22s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 24s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
0s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 30s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 14m
13s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
48s {color} | {color:green} HBASE-16961 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 57s
{color} | {color:red} hbase-protocol-shaded in HBASE-16961 has 24 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
39s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 14m
30s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
48s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 14s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 24s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 28s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 33s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 38s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s
{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 5s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 88m 39s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit
[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883569#comment-15883569
]
Ted Yu commented on HBASE-17428:
+1 on latest patch, pending QA.
> Expand on shell commands for detailed insight
> -
>
> Key: HBASE-17428
> URL: https://issues.apache.org/jira/browse/HBASE-17428
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: HBASE-16961
>
> Attachments: HBASE-17428.001.patch, HBASE-17428.002.patch,
> HBASE-17428.003.HBASE-16961.patch
>
>
> Was talking over how to build some tests with [~romil.choksi], and what kind
> of information we capture and expose via some more shell commands.
> * Current SpaceQuotaSnapshots that the Master sees
> * Current SpaceQuotaSnapshots that a RS sees (or all RSs)
> * Current SpaceViolationPolicyEnforcements that a RS has enabled
> We can build out on the {{status}} command, with some options for different
> levels of detail, perhaps. Shouldn't be too tricky -- we have the info, just
> need to wire up java API, RPC, and shell command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879832#comment-15879832
]
Josh Elser commented on HBASE-17428:
https://reviews.apache.org/r/56966/
> Expand on shell commands for detailed insight
> -
>
> Key: HBASE-17428
> URL: https://issues.apache.org/jira/browse/HBASE-17428
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: HBASE-16961
>
> Attachments: HBASE-17428.001.patch, HBASE-17428.002.patch,
> HBASE-17428.003.HBASE-16961.patch
>
>
> Was talking over how to build some tests with [~romil.choksi], and what kind
> of information we capture and expose via some more shell commands.
> * Current SpaceQuotaSnapshots that the Master sees
> * Current SpaceQuotaSnapshots that a RS sees (or all RSs)
> * Current SpaceViolationPolicyEnforcements that a RS has enabled
> We can build out on the {{status}} command, with some options for different
> levels of detail, perhaps. Shouldn't be too tricky -- we have the info, just
> need to wire up java API, RPC, and shell command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879829#comment-15879829
]
Josh Elser commented on HBASE-17428:
{quote}
The patch is sizable.
Can you put it on review board ?
{quote}
Sure, not a problem. Lots of generated code, so I didn't initially think to do
that :)
> Expand on shell commands for detailed insight
> -
>
> Key: HBASE-17428
> URL: https://issues.apache.org/jira/browse/HBASE-17428
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: HBASE-16961
>
> Attachments: HBASE-17428.001.patch, HBASE-17428.002.patch,
> HBASE-17428.003.HBASE-16961.patch
>
>
> Was talking over how to build some tests with [~romil.choksi], and what kind
> of information we capture and expose via some more shell commands.
> * Current SpaceQuotaSnapshots that the Master sees
> * Current SpaceQuotaSnapshots that a RS sees (or all RSs)
> * Current SpaceViolationPolicyEnforcements that a RS has enabled
> We can build out on the {{status}} command, with some options for different
> levels of detail, perhaps. Shouldn't be too tricky -- we have the info, just
> need to wire up java API, RPC, and shell command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879684#comment-15879684
]
Ted Yu commented on HBASE-17428:
The patch is sizable.
Can you put it on review board ?
> Expand on shell commands for detailed insight
> -
>
> Key: HBASE-17428
> URL: https://issues.apache.org/jira/browse/HBASE-17428
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: HBASE-16961
>
> Attachments: HBASE-17428.001.patch, HBASE-17428.002.patch,
> HBASE-17428.003.HBASE-16961.patch
>
>
> Was talking over how to build some tests with [~romil.choksi], and what kind
> of information we capture and expose via some more shell commands.
> * Current SpaceQuotaSnapshots that the Master sees
> * Current SpaceQuotaSnapshots that a RS sees (or all RSs)
> * Current SpaceViolationPolicyEnforcements that a RS has enabled
> We can build out on the {{status}} command, with some options for different
> levels of detail, perhaps. Shouldn't be too tricky -- we have the info, just
> need to wire up java API, RPC, and shell command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17428) Expand on shell commands for detailed insight
[
https://issues.apache.org/jira/browse/HBASE-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819099#comment-15819099
]
Hadoop QA commented on HBASE-17428:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color}
| {color:red} HBASE-17428 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12846964/HBASE-17428.002.patch
|
| JIRA Issue | HBASE-17428 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5242/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Expand on shell commands for detailed insight
> -
>
> Key: HBASE-17428
> URL: https://issues.apache.org/jira/browse/HBASE-17428
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Josh Elser
>Assignee: Josh Elser
> Attachments: HBASE-17428.001.patch, HBASE-17428.002.patch
>
>
> Was talking over how to build some tests with [~romil.choksi], and what kind
> of information we capture and expose via some more shell commands.
> * Current SpaceQuotaSnapshots that the Master sees
> * Current SpaceQuotaSnapshots that a RS sees (or all RSs)
> * Current SpaceViolationPolicyEnforcements that a RS has enabled
> We can build out on the {{status}} command, with some options for different
> levels of detail, perhaps. Shouldn't be too tricky -- we have the info, just
> need to wire up java API, RPC, and shell command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
