[jira] [Commented] (HBASE-17496) RSGroup shell commands:get_server_rsgroup don't work and commands display an incorrect result size
[ https://issues.apache.org/jira/browse/HBASE-17496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831094#comment-15831094 ] stack commented on HBASE-17496: --- Patch LGTM. See what hadoopqa says. Thanks [~andrewcheng] > RSGroup shell commands:get_server_rsgroup don't work and commands display an > incorrect result size > -- > > Key: HBASE-17496 > URL: https://issues.apache.org/jira/browse/HBASE-17496 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.0.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Labels: rsgroup > Fix For: 2.0.0 > > Attachments: HBASE-17496-master-v1.patch > > > scenario as follows: > {code} > hbase(main):001:0> get_server_rsgroup 'hbase-01:16030' > ERROR: undefined method `getRSGroupOfServer' for > # > Here is some help for this command: > Get the group name the given region server is a member of. > hbase> get_server_rsgroup 'server1:port1' > Took 0.0160 seconds > {code} > {code} > hbase(main):002:0> list_rsgroups > GROUPS > default > 1484874115 row(s) > Took 0.3830 seconds > {code} > {code} > hbase(main):003:0> get_table_rsgroup 't1' > default > 1484874133 row(s) > Took 0.0100 seconds > {code} > {code} > hbase(main):004:0> get_rsgroup 'default' > GROUP INFORMATION > Servers: > hbase-01:16030 > Tables: > hbase:meta > t1 > hbase:namespace > hbase:rsgroup > 1484874150 row(s) > Took 0.0140 seconds > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17496) RSGroup shell commands:get_server_rsgroup don't work and commands display an incorrect result size
[ https://issues.apache.org/jira/browse/HBASE-17496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831176#comment-15831176 ] Hadoop QA commented on HBASE-17496: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 1s {color} | {color:blue} rubocop was not available. {color} | | {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 1s {color} | {color:blue} Ruby-lint was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 28s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 27m 34s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 33s {color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 7s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 6s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12848451/HBASE-17496-master-v1.patch | | JIRA Issue | HBASE-17496 | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux c286b4771b20 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 4fdd6ff | | Default Java | 1.8.0_111 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/5357/testReport/ | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5357/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > RSGroup shell commands:get_server_rsgroup don't work and commands display an > incorrect result size > -- > > Key: HBASE-17496 > URL: https://issues.apache.org/jira/browse/HBASE-17496 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.0.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Labels: rsgroup > Fix For: 2.0.0 > > Attachments: HBASE-17496-master-v1.patch > > > scenario as follows: > {code} > hbase(main):001:0> get_server_rsgroup 'hbase-01:16030' > ERROR: undefined method `getRSGroupOfServer' for > # > Here is some help for this command: > Get the group name the given region server is a member of. > hbase> get_server_rsgroup 'server1:port1' > Took 0.0160 seconds > {code} > {code} > hbase(main):002:0> list_rsgroups > GROUPS > default > 1484874115 row(s) > Took 0.3830 seconds > {code} > {code} > hbase(main):003:0> get_table_rsgroup 't1' > default > 1484874133 row(s) > Took 0.0100 seconds > {code} > {code} > hbase(main):004:0> get_rsg
[jira] [Commented] (HBASE-17496) RSGroup shell commands:get_server_rsgroup don't work and commands display an incorrect result size
[ https://issues.apache.org/jira/browse/HBASE-17496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831193#comment-15831193 ] stack commented on HBASE-17496: --- Can you paste examples of the patch working please [~andrewcheng] so I can commit it? > RSGroup shell commands:get_server_rsgroup don't work and commands display an > incorrect result size > -- > > Key: HBASE-17496 > URL: https://issues.apache.org/jira/browse/HBASE-17496 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.0.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Labels: rsgroup > Fix For: 2.0.0 > > Attachments: HBASE-17496-master-v1.patch > > > scenario as follows: > {code} > hbase(main):001:0> get_server_rsgroup 'hbase-01:16030' > ERROR: undefined method `getRSGroupOfServer' for > # > Here is some help for this command: > Get the group name the given region server is a member of. > hbase> get_server_rsgroup 'server1:port1' > Took 0.0160 seconds > {code} > {code} > hbase(main):002:0> list_rsgroups > GROUPS > default > 1484874115 row(s) > Took 0.3830 seconds > {code} > {code} > hbase(main):003:0> get_table_rsgroup 't1' > default > 1484874133 row(s) > Took 0.0100 seconds > {code} > {code} > hbase(main):004:0> get_rsgroup 'default' > GROUP INFORMATION > Servers: > hbase-01:16030 > Tables: > hbase:meta > t1 > hbase:namespace > hbase:rsgroup > 1484874150 row(s) > Took 0.0140 seconds > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17496) RSGroup shell commands:get_server_rsgroup don't work and commands display an incorrect result size
[ https://issues.apache.org/jira/browse/HBASE-17496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831214#comment-15831214 ] Guangxu Cheng commented on HBASE-17496: --- After merge the patch as follows: {code} hbase(main):001:0> get_server_rsgroup '10.57.22.78:60020' default 1 row(s) Took 0.3950 seconds {code} {code} hbase(main):002:0> list_rsgroups GROUPS default 1 row(s) Took 0.0130 seconds {code} {code} hbase(main):003:0> get_table_rsgroup 't1' default 1 row(s) Took 0.0130 seconds {code} {code} hbase(main):004:0> get_rsgroup 'default' GROUP INFORMATION Servers: 10.57.22.78:60020 Tables: hbase:meta t1 hbase:namespace hbase:rsgroup 7 row(s) Took 0.0130 seconds {code} > RSGroup shell commands:get_server_rsgroup don't work and commands display an > incorrect result size > -- > > Key: HBASE-17496 > URL: https://issues.apache.org/jira/browse/HBASE-17496 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.0.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Labels: rsgroup > Fix For: 2.0.0 > > Attachments: HBASE-17496-master-v1.patch > > > scenario as follows: > {code} > hbase(main):001:0> get_server_rsgroup 'hbase-01:16030' > ERROR: undefined method `getRSGroupOfServer' for > # > Here is some help for this command: > Get the group name the given region server is a member of. > hbase> get_server_rsgroup 'server1:port1' > Took 0.0160 seconds > {code} > {code} > hbase(main):002:0> list_rsgroups > GROUPS > default > 1484874115 row(s) > Took 0.3830 seconds > {code} > {code} > hbase(main):003:0> get_table_rsgroup 't1' > default > 1484874133 row(s) > Took 0.0100 seconds > {code} > {code} > hbase(main):004:0> get_rsgroup 'default' > GROUP INFORMATION > Servers: > hbase-01:16030 > Tables: > hbase:meta > t1 > hbase:namespace > hbase:rsgroup > 1484874150 row(s) > Took 0.0140 seconds > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17496) RSGroup shell commands:get_server_rsgroup don't work and commands display an incorrect result size
[ https://issues.apache.org/jira/browse/HBASE-17496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831219#comment-15831219 ] Guangxu Cheng commented on HBASE-17496: --- [~stack] Example of the patch has been pasted in the previous message.Thanks for your reviewing. > RSGroup shell commands:get_server_rsgroup don't work and commands display an > incorrect result size > -- > > Key: HBASE-17496 > URL: https://issues.apache.org/jira/browse/HBASE-17496 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.0.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Labels: rsgroup > Fix For: 2.0.0 > > Attachments: HBASE-17496-master-v1.patch > > > scenario as follows: > {code} > hbase(main):001:0> get_server_rsgroup 'hbase-01:16030' > ERROR: undefined method `getRSGroupOfServer' for > # > Here is some help for this command: > Get the group name the given region server is a member of. > hbase> get_server_rsgroup 'server1:port1' > Took 0.0160 seconds > {code} > {code} > hbase(main):002:0> list_rsgroups > GROUPS > default > 1484874115 row(s) > Took 0.3830 seconds > {code} > {code} > hbase(main):003:0> get_table_rsgroup 't1' > default > 1484874133 row(s) > Took 0.0100 seconds > {code} > {code} > hbase(main):004:0> get_rsgroup 'default' > GROUP INFORMATION > Servers: > hbase-01:16030 > Tables: > hbase:meta > t1 > hbase:namespace > hbase:rsgroup > 1484874150 row(s) > Took 0.0140 seconds > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17496) RSGroup shell commands:get_server_rsgroup don't work and commands display an incorrect result size
[ https://issues.apache.org/jira/browse/HBASE-17496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832398#comment-15832398 ] Hudson commented on HBASE-17496: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2354 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2354/]) HBASE-17496 RSGroup shell commands:get_server_rsgroup don't work and (stack: rev 31f3e8f833b65d87bb70dd47268213ff03be20b9) * (edit) hbase-shell/src/main/ruby/shell/commands/get_server_rsgroup.rb * (edit) hbase-shell/src/main/ruby/shell/commands/get_table_rsgroup.rb * (edit) hbase-shell/src/main/ruby/shell/commands/list_rsgroups.rb * (edit) hbase-shell/src/main/ruby/shell/commands/get_rsgroup.rb > RSGroup shell commands:get_server_rsgroup don't work and commands display an > incorrect result size > -- > > Key: HBASE-17496 > URL: https://issues.apache.org/jira/browse/HBASE-17496 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.0.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Labels: rsgroup > Fix For: 2.0.0 > > Attachments: HBASE-17496-master-v1.patch > > > scenario as follows: > {code} > hbase(main):001:0> get_server_rsgroup 'hbase-01:16030' > ERROR: undefined method `getRSGroupOfServer' for > # > Here is some help for this command: > Get the group name the given region server is a member of. > hbase> get_server_rsgroup 'server1:port1' > Took 0.0160 seconds > {code} > {code} > hbase(main):002:0> list_rsgroups > GROUPS > default > 1484874115 row(s) > Took 0.3830 seconds > {code} > {code} > hbase(main):003:0> get_table_rsgroup 't1' > default > 1484874133 row(s) > Took 0.0100 seconds > {code} > {code} > hbase(main):004:0> get_rsgroup 'default' > GROUP INFORMATION > Servers: > hbase-01:16030 > Tables: > hbase:meta > t1 > hbase:namespace > hbase:rsgroup > 1484874150 row(s) > Took 0.0140 seconds > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)