[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880276#comment-15880276 ] Hudson commented on HBASE-17677: FAILURE: Integrated in Jenkins build HBase-1.2-IT #604 (See [https://builds.apache.org/job/HBase-1.2-IT/604/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 7314575a2e734abedcf9445b1c02e6533fbc8a05) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880192#comment-15880192 ] Hudson commented on HBASE-17677: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #99 (See [https://builds.apache.org/job/HBase-1.2-JDK8/99/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 7314575a2e734abedcf9445b1c02e6533fbc8a05) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880181#comment-15880181 ] Hudson commented on HBASE-17677: FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #122 (See [https://builds.apache.org/job/HBase-1.3-JDK8/122/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 8b0fabf1bb2333ef7b6085368b32d60bc9b3014b) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880114#comment-15880114 ] Hudson commented on HBASE-17677: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #112 (See [https://builds.apache.org/job/HBase-1.3-JDK7/112/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 8b0fabf1bb2333ef7b6085368b32d60bc9b3014b) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880090#comment-15880090 ] Hudson commented on HBASE-17677: SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1848 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1848/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 76879ded89e5ff0fb00bf9fc31bb90f0489ce2e0) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880068#comment-15880068 ] Hudson commented on HBASE-17677: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2555 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2555/]) HBASE-17677 ServerName parsing from directory name should be more robust (busbey: rev 040b2f186a08222fc0a0b3bd5c97ccef9cf45368) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880061#comment-15880061 ] Hudson commented on HBASE-17677: SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #1932 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1932/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 76879ded89e5ff0fb00bf9fc31bb90f0489ce2e0) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880005#comment-15880005 ] Hudson commented on HBASE-17677: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #837 (See [https://builds.apache.org/job/HBase-1.3-IT/837/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 7314575a2e734abedcf9445b1c02e6533fbc8a05) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879969#comment-15879969 ] Hudson commented on HBASE-17677: SUCCESS: Integrated in Jenkins build HBase-1.4 #642 (See [https://builds.apache.org/job/HBase-1.4/642/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 7917314477fcbadcd761e617fdf472a262274443) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879945#comment-15879945 ] Hudson commented on HBASE-17677: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #106 (See [https://builds.apache.org/job/HBase-1.2-JDK7/106/]) HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 7314575a2e734abedcf9445b1c02e6533fbc8a05) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[
https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879374#comment-15879374
]
Hadoop QA commented on HBASE-17677:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
5s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
48s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 7s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
48s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 98m 44s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 138m 30s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12854051/HBASE-17677.1.patch |
| JIRA Issue | HBASE-17677 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux f0302af6a0bb 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f037f23 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/5803/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5803/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> ServerName parsing from directory name should be more robust to errors from
> guava's HostAndPort
> ---
>
> Key: HBASE-17677
> URL: https://issues.apache.org/jira/browse/HBASE-17677
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee
[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
[ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879127#comment-15879127 ] stack commented on HBASE-17677: --- +1 Thanks [~busbey] Good test. > ServerName parsing from directory name should be more robust to errors from > guava's HostAndPort > --- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures > from the underlying Guava implementation. Right now when we parse a > ServerName from a WAL directory we properly handle if guava gives us an > IllegalArgumentException but we do not handle if it gives us a > IllegalStateException. e.g. it uses the former for "I couldn't parse anything > out of this string" and the latter for "I parsed a host name but didn't see a > port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
