[jira] [Commented] (HBASE-17935) NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client

2017-04-18 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973528#comment-15973528
 ] 

Ted Yu commented on HBASE-17935:


For unit test, refer to TestFastFail where HBASE_CLIENT_FAST_FAIL_MODE_ENABLED 
is set true.

See if namespaceExists() triggers the NPE.

> NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client
> ---
>
> Key: HBASE-17935
> URL: https://issues.apache.org/jira/browse/HBASE-17935
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.1.2
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Minor
> Attachments: HBASE-17935.master.001.patch
>
>
> When setting hbase.client.fast.fail.mode.enabled=true and using the admin 
> client, got a NPE:
> java.lang.NullPointerException
> at 
> java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:115)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:376)
> at 
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:135)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getNamespaceDescriptor(HBaseAdmin.java:3009)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.namespaceExists(HBaseConnectionFactory.java:146)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.createHTable(HBaseConnectionFactory.java:116)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.declareTable(HBaseConnectionFactory.java:97)
> at 
> com.yammer.feedie.core.index.calmie.MessageCalmieIndex.(MessageCalmieIndex.java:46)
> at com.yammer.feedie.core.MessageStore.init(MessageStore.java:108)
> at com.yammer.feedie.core.MessageStore.(MessageStore.java:89)
> at com.yammer.feedie.FeedieService.setup(FeedieService.java:148)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:315)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:65)
> at 
> com.yammer.dropwizard.cli.EnvironmentCommand.run(EnvironmentCommand.java:38)
> at 
> com.yammer.dropwizard.cli.ConfiguredCommand.run(ConfiguredCommand.java:58)
> at com.yammer.dropwizard.cli.Cli.run(Cli.java:53)
> at com.yammer.dropwizard.Service.run(Service.java:61)
> at com.yammer.feedie.FeedieService.main(FeedieService.java:84)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17935) NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client

2017-04-17 Thread Duo Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972056#comment-15972056
 ] 

Duo Zhang commented on HBASE-17935:
---

Got it. Please add a comment to the null check about this.

And mind writing a UT to cover this?

Thanks.

> NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client
> ---
>
> Key: HBASE-17935
> URL: https://issues.apache.org/jira/browse/HBASE-17935
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.1.2
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Minor
> Attachments: HBASE-17935.master.001.patch
>
>
> When setting hbase.client.fast.fail.mode.enabled=true and using the admin 
> client, got a NPE:
> java.lang.NullPointerException
> at 
> java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:115)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:376)
> at 
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:135)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getNamespaceDescriptor(HBaseAdmin.java:3009)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.namespaceExists(HBaseConnectionFactory.java:146)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.createHTable(HBaseConnectionFactory.java:116)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.declareTable(HBaseConnectionFactory.java:97)
> at 
> com.yammer.feedie.core.index.calmie.MessageCalmieIndex.(MessageCalmieIndex.java:46)
> at com.yammer.feedie.core.MessageStore.init(MessageStore.java:108)
> at com.yammer.feedie.core.MessageStore.(MessageStore.java:89)
> at com.yammer.feedie.FeedieService.setup(FeedieService.java:148)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:315)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:65)
> at 
> com.yammer.dropwizard.cli.EnvironmentCommand.run(EnvironmentCommand.java:38)
> at 
> com.yammer.dropwizard.cli.ConfiguredCommand.run(ConfiguredCommand.java:58)
> at com.yammer.dropwizard.cli.Cli.run(Cli.java:53)
> at com.yammer.dropwizard.Service.run(Service.java:61)
> at com.yammer.feedie.FeedieService.main(FeedieService.java:84)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17935) NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client

2017-04-17 Thread Robert Yokota (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972036#comment-15972036
 ] 

Robert Yokota commented on HBASE-17935:
---

During FastFailInterceptorContext.prepare, the server is only set if the 
callable is an instance of RegionServerCallable, which is not the case for all 
admin ops

{code:java}
  public FastFailInterceptorContext prepare(RetryingCallable callable,
  int tries) {
if (callable instanceof RegionServerCallable) {
  RegionServerCallable retryingCallable = (RegionServerCallable) 
callable;
  server = retryingCallable.getLocation().getServerName();
}
this.tries = tries;
return this;
  }
{code}



> NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client
> ---
>
> Key: HBASE-17935
> URL: https://issues.apache.org/jira/browse/HBASE-17935
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.1.2
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Minor
> Attachments: HBASE-17935.master.001.patch
>
>
> When setting hbase.client.fast.fail.mode.enabled=true and using the admin 
> client, got a NPE:
> java.lang.NullPointerException
> at 
> java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:115)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:376)
> at 
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:135)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getNamespaceDescriptor(HBaseAdmin.java:3009)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.namespaceExists(HBaseConnectionFactory.java:146)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.createHTable(HBaseConnectionFactory.java:116)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.declareTable(HBaseConnectionFactory.java:97)
> at 
> com.yammer.feedie.core.index.calmie.MessageCalmieIndex.(MessageCalmieIndex.java:46)
> at com.yammer.feedie.core.MessageStore.init(MessageStore.java:108)
> at com.yammer.feedie.core.MessageStore.(MessageStore.java:89)
> at com.yammer.feedie.FeedieService.setup(FeedieService.java:148)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:315)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:65)
> at 
> com.yammer.dropwizard.cli.EnvironmentCommand.run(EnvironmentCommand.java:38)
> at 
> com.yammer.dropwizard.cli.ConfiguredCommand.run(ConfiguredCommand.java:58)
> at com.yammer.dropwizard.cli.Cli.run(Cli.java:53)
> at com.yammer.dropwizard.Service.run(Service.java:61)
> at com.yammer.feedie.FeedieService.main(FeedieService.java:84)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17935) NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client

2017-04-17 Thread Duo Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971945#comment-15971945
 ] 

Duo Zhang commented on HBASE-17935:
---

Any explanation on why context.getServer could be null?

Thanks.

> NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client
> ---
>
> Key: HBASE-17935
> URL: https://issues.apache.org/jira/browse/HBASE-17935
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.1.2
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Minor
> Attachments: HBASE-17935.master.001.patch
>
>
> When setting hbase.client.fast.fail.mode.enabled=true and using the admin 
> client, got a NPE:
> java.lang.NullPointerException
> at 
> java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:115)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:376)
> at 
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:135)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getNamespaceDescriptor(HBaseAdmin.java:3009)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.namespaceExists(HBaseConnectionFactory.java:146)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.createHTable(HBaseConnectionFactory.java:116)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.declareTable(HBaseConnectionFactory.java:97)
> at 
> com.yammer.feedie.core.index.calmie.MessageCalmieIndex.(MessageCalmieIndex.java:46)
> at com.yammer.feedie.core.MessageStore.init(MessageStore.java:108)
> at com.yammer.feedie.core.MessageStore.(MessageStore.java:89)
> at com.yammer.feedie.FeedieService.setup(FeedieService.java:148)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:315)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:65)
> at 
> com.yammer.dropwizard.cli.EnvironmentCommand.run(EnvironmentCommand.java:38)
> at 
> com.yammer.dropwizard.cli.ConfiguredCommand.run(ConfiguredCommand.java:58)
> at com.yammer.dropwizard.cli.Cli.run(Cli.java:53)
> at com.yammer.dropwizard.Service.run(Service.java:61)
> at com.yammer.feedie.FeedieService.main(FeedieService.java:84)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17935) NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client

2017-04-17 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971905#comment-15971905
 ] 

Hadoop QA commented on HBASE-17935:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 32s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 
24s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
53s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
20s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
13s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 44s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
53s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
64m 44s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 5s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 10s 
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
11s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 86m 50s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12863699/HBASE-17935.master.001.patch
 |
| JIRA Issue | HBASE-17935 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux e6945bc3ab03 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / ecdfb82 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6472/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6472/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client
> ---
>
> Key: HBASE-17935
> URL: https://issues.apache.org/jira/browse/HBASE-17935
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affect

[jira] [Commented] (HBASE-17935) NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client

2017-04-17 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971795#comment-15971795
 ] 

Ted Yu commented on HBASE-17935:


lgtm

Any chance of adding a test ?

> NPE when using PreemptiveFastFailInterceptor with HBaseAdmin client
> ---
>
> Key: HBASE-17935
> URL: https://issues.apache.org/jira/browse/HBASE-17935
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.1.2
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Minor
> Attachments: HBASE-17935.master.001.patch
>
>
> When setting hbase.client.fast.fail.mode.enabled=true and using the admin 
> client, got a NPE:
> java.lang.NullPointerException
> at 
> java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:115)
> at 
> org.apache.hadoop.hbase.client.PreemptiveFastFailInterceptor.intercept(PreemptiveFastFailInterceptor.java:376)
> at 
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:135)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getNamespaceDescriptor(HBaseAdmin.java:3009)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.namespaceExists(HBaseConnectionFactory.java:146)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.createHTable(HBaseConnectionFactory.java:116)
> at 
> com.yammer.calmie.store.hbase.HBaseConnectionFactory.declareTable(HBaseConnectionFactory.java:97)
> at 
> com.yammer.feedie.core.index.calmie.MessageCalmieIndex.(MessageCalmieIndex.java:46)
> at com.yammer.feedie.core.MessageStore.init(MessageStore.java:108)
> at com.yammer.feedie.core.MessageStore.(MessageStore.java:89)
> at com.yammer.feedie.FeedieService.setup(FeedieService.java:148)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:315)
> at com.yammer.feedie.FeedieService.run(FeedieService.java:65)
> at 
> com.yammer.dropwizard.cli.EnvironmentCommand.run(EnvironmentCommand.java:38)
> at 
> com.yammer.dropwizard.cli.ConfiguredCommand.run(ConfiguredCommand.java:58)
> at com.yammer.dropwizard.cli.Cli.run(Cli.java:53)
> at com.yammer.dropwizard.Service.run(Service.java:61)
> at com.yammer.feedie.FeedieService.main(FeedieService.java:84)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)